Skip to contentSkip to conversation

eeprom_93cx6: Add comment for 1us delay after pulse

PATCH In review Ivo van Doorn 2 participants 2 messages May 14, 2007 – May 15, 2007 Char and misc drivers

lore
Share & tools
lore

Ivo van Doorn

author
#0 lore raw

PATCH 1/1 eeprom_93cx6: Add comment for 1us delay after pulse

This will add a comment for the 1us delay which is taken after the pulse has been switched. The 1us delay is based on the specifications so that should be made clear.

Signed-off-by Ivo van Doorn <[email protected]>

---

drivers/misc/eeprom_93cx6.c +12 -0
index a948ddc..8c8b43f 100644
@@ -39,6 +39,12 @@ static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
 {
 	eeprom->reg_data_clock = 1;
 	eeprom->register_write(eeprom);
+
+	/*
+	 * Add a short delay for the pulse to work.
+	 * According to the specifications the minimal time
+	 * should be 450ns so a 1us delay is sufficient.
+	 */
 	udelay(1);
 }
 

@@ -46,6 +52,12 @@ static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
 {
 	eeprom->reg_data_clock = 0;
 	eeprom->register_write(eeprom);
+
+	/*
+	 * Add a short delay for the pulse to work.
+	 * According to the specifications the minimal time
+	 * should be 450ns so a 1us delay is sufficient.
+	 */
 	udelay(1);
 }
#1 lore raw
Quoted 26 lines · Ivo van Doorn

This will add a comment for the 1us delay which is taken after the pulse has been switched. The 1us delay is based on the specifications so that should be made clear.

Signed-off-by Ivo van Doorn <[email protected]>

---

drivers/misc/eeprom_93cx6.c +6 -0
index a948ddc..8c8b43f 100644
@@ -39,6 +39,12 @@ static inline void eeprom_93cx6_pulse_high(struct eeprom_93cx6 *eeprom)
 {
 	eeprom->reg_data_clock = 1;
 	eeprom->register_write(eeprom);
+
+	/*
+	 * Add a short delay for the pulse to work.
+	 * According to the specifications the minimal time
+	 * should be 450ns so a 1us delay is sufficient.
+	 */
 	udelay(1);
 }

drivers/misc/eeprom_93cx6.c static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom) · line 61

Quoted 10 lines
drivers/misc/eeprom_93cx6.c +6 -0
@@ -46,6 +52,12 @@ static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
 {
 	eeprom->reg_data_clock = 0;
 	eeprom->register_write(eeprom);
+
+	/*
+	 * Add a short delay for the pulse to work.
+	 * According to the specifications the minimal time
+	 * should be 450ns so a 1us delay is sufficient.
+	 */
 	udelay(1);

why not ndelay(450)?

Jeff