Fix section conflict of ia64_mlogbuf_finish
Building with GCC 4.2, I get the following error:
CC arch/ia64/kernel/mca.oarch/ia64/kernel/mca.c:275: error: __ksymtab_ia64_mlogbuf_finish causes a section type conflict
This is because ia64_mlogbuf_finish is both declared static and exported.
arch/ia64/kernel/mca.c renamed from arch/ia64/kernel/mca.c~ +1 -1
@@ -254,7 +254,7 @@* invoked, long-wait rendezvous etc.) * NOTE: this should be called from monarch. */ -static void ia64_mlogbuf_finish (int wait) +void ia64_mlogbuf_finish (int wait) {BREAK_LOGLEVEL (console_loglevel);
Signature · 2 lines
Martin Michlmayr http://www.cyrius.com/
Quoted 4 lines
CC
arch/ia64/kernel/mca.oarch/ia64/kernel/mca.c:275: error:__ksymtab_ia64_mlogbuf_finishcauses a section type conflictThis is because
ia64_mlogbuf_finishis both declared static and exported.
Why is it exported? mca_drv.c (our only mca related module) doesn't use it. Perhaps the fix should be to drop the EXPORT?
-Tony
Quoted 8 lines · Tony Luck
Quoted 5 lines
CC
arch/ia64/kernel/mca.oarch/ia64/kernel/mca.c:275: error:__ksymtab_ia64_mlogbuf_finishcauses a section type conflictThis is because
ia64_mlogbuf_finishis both declared static and exported.Why is it exported?
mca_drv.c(our only mca related module) doesn't use it. Perhaps the fix should be to drop the EXPORT?
I suspect EXPORT is left over from the initial development/debug. Either change is fine with me.
Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc [email protected]
Quoted 2 lines · Russ Anderson
I suspect EXPORT is left over from the initial development/debug. Either change is fine with me.
OK, then let's use this one instead:
Subject: Fix section conflict of ia64_mlogbuf_finish
Building with GCC 4.2, I get the following error:
CC arch/ia64/kernel/mca.oarch/ia64/kernel/mca.c:275: error: __ksymtab_ia64_mlogbuf_finish causes a section type conflict
This is because ia64_mlogbuf_finish is both declared static and exported.
arch/ia64/kernel/mca.c +0 -1
@@ -272,7 +272,6 @@ static void ia64_mlogbuf_finish(int wait) mlogbuf_finished =1 ; } -EXPORT_SYMBOL (ia64_mlogbuf_finish);/* * Print buffered messages from INIT context.
Signature · 2 lines
Martin Michlmayr http://www.cyrius.com/
Quoted 1 line
Quoted 1 line
I suspect EXPORT is left over from the initial development/debug.
Yes, that's right.
The reason why the EXPORT was there is that I supposed a optional use of ia64_mlogbuf_finish expecting that there would be some non-standard mca recovery module, module relating kdump or something. However such module is not there at the moment.
Thanks,
H.Seto
Quoted 30 lines · Martin Michlmayr
Quoted 2 lines · Russ Anderson
I suspect EXPORT is left over from the initial development/debug. Either change is fine with me.
OK, then let's use this one instead:
Subject: Fix section conflict of
ia64_mlogbuf_finishBuilding with GCC 4.2, I get the following error:
CC
arch/ia64/kernel/mca.oarch/ia64/kernel/mca.c:275: error:__ksymtab_ia64_mlogbuf_finishcauses a section type conflictThis is because
ia64_mlogbuf_finishis both declared static and exported.Signed-off-by Martin Michlmayr <[email protected]>arch/ia64/kernel/mca.c +0
-1@@ -272,7 +272,6 @@ static void ia64_mlogbuf_finish(int wait) mlogbuf_finished =1 ; } -EXPORT_SYMBOL (ia64_mlogbuf_finish);/* * Print buffered messages from INIT context.