Skip to contentSkip to conversation

rpadlpar breakage - fallout of struct subsystem removal]

PATCH In review Al Viro 5 participants 5 messages May 15, 2007 – May 16, 2007

Subsystems (3)
PowerPC PCI IBM Power io dlpar Driver for RPA-compliant PPC64 platform
lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 rpadlpar breakage - fallout of struct subsystem removal]

[oops - typo in Cc in original posting]

Signed-off-by Al Viro <[email protected]>
---
 drivers/pci/hotplug/rpadlpar_sysfs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/pci/hotplug/rpadlpar_sysfs.c +3 -2
index 6c5be3f..df07606 100644
@@ -129,8 +129,9 @@ struct kobj_type ktype_dlpar_io = {
 };
 
 struct kset dlpar_io_kset = {
-	.subsys = &pci_hotplug_slots_subsys,
-	.kobj = {.name = DLPAR_KOBJ_NAME, .ktype=&ktype_dlpar_io,},
+	.kobj = {.name = DLPAR_KOBJ_NAME,
+		 .ktype = &ktype_dlpar_io,
+		 .parent = &pci_hotplug_slots_subsys.kobj},
 	.ktype = &ktype_dlpar_io,
 };
Signature · 10 lines
1.5.0-rc2.GIT


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

----- End forwarded message -----
#1 lore raw
Quoted 12 lines · Al Viro

[oops - typo in Cc in original posting]

Signed-off-by Al Viro <[email protected]>
---
 drivers/pci/hotplug/rpadlpar_sysfs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/pci/hotplug/rpadlpar_sysfs.c +0 -0
index 6c5be3f..df07606 100644

drivers/pci/hotplug/rpadlpar_sysfs.c struct kobj_type ktype_dlpar_io = { · line 136

Quoted 10 lines
drivers/pci/hotplug/rpadlpar_sysfs.c +3 -2
@@ -129,8 +129,9 @@ struct kobj_type ktype_dlpar_io = {
 };
 
 struct kset dlpar_io_kset = {
-	.subsys = &pci_hotplug_slots_subsys,
-	.kobj = {.name = DLPAR_KOBJ_NAME, .ktype=&ktype_dlpar_io,},
+	.kobj = {.name = DLPAR_KOBJ_NAME,
+		 .ktype = &ktype_dlpar_io,
+		 .parent = &pci_hotplug_slots_subsys.kobj},
 	.ktype = &ktype_dlpar_io,
 };

That seems to work, I get 'add_slot' and 'remove_slot' under /sys/bus/pci/slots/control again.

cheers

Signature · 8 lines
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
#2 lore raw
Quoted 3 lines

That seems to work, I get 'add_slot' and 'remove_slot' under /sys/bus/pci/slots/control again.

I verified that PCI hotplug actually works with that patch.

Ben.

#3 lore raw
Quoted 5 lines · Benjamin Herrenschmidt
Quoted 3 lines

That seems to work, I get 'add_slot' and 'remove_slot' under /sys/bus/pci/slots/control again.

I verified that PCI hotplug actually works with that patch.

Thanks for testing, and Al, thanks for the patch, the rpadlpar code was doing something different from what I expected...

thanks,

greg k-h