Make ISDN CAPI use seq_list_xxx helpers
Karsten Keil
Acked-byThe similar code exists here and is called capi_driver_get_idx(). Use generic helpers now and remember to convert list_head to struct capi_driver in .show callback.
Acked-by Karsten Keil <[email protected]>
Signed-off-by Pavel Emelianov <[email protected]>
---
drivers/isdn/capi/kcapi_proc.c +4 -24
@@ -243,36 +243,15 @@ create_seq_entry(char *name, mode_t mode// --------------------------------------------------------------------------- - -static __inline__struct capi_driver *capi_driver_get_idx (loff_t pos) -{ -struct capi_driver *drv =NULL ; -struct list_head *l; -loff_t i; - - i =0 ; -list_for_each (l, &capi_drivers) { - drv = list_entry(l, struct capi_driver, list); -if (i++ == pos) -return drv; - } -return NULL ; -} -static void *capi_driver_start (struct seq_file *seq,loff_t *pos) { -struct capi_driver *drv;read_lock (&capi_drivers_list_lock); - drv =capi_driver_get_idx (*pos); -return drv; +return seq_list_start (&capi_drivers, *pos); }static void *capi_driver_next (struct seq_file *seq,void *v,loff_t *pos) { -struct capi_driver *drv = (struct capi_driver *)v; - ++*pos; -if (drv->list.next == &capi_drivers)return NULL ; - return list_entry(drv->list.next, struct capi_driver, list); +return seq_list_next (v, &capi_drivers, pos); }static void capi_driver_stop (struct seq_file *seq,void *v)
@@ -282,7 +261,8 @@ static void capi_driver_stop(struct seq_static int capi_driver_show (struct seq_file *seq,void *v) { -struct capi_driver *drv = (struct capi_driver *)v; + struct capi_driver *drv = list_entry(v, struct capi_driver, list); +seq_printf (seq,"%-32s %s\n" , drv->name, drv->revision);return 0 ; }
Signature · 4 lines
Karsten Keil SuSE Labs ISDN and VOIP development SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)