Skip to contentSkip to conversation

i386, x86-64: show that CONFIG_HOTPLUG_CPU is required for suspend on SMP

PATCH New Rafael J. Wysocki 1 participant 1 message May 20, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386, x86-64: show that CONFIG_HOTPLUG_CPU is required for suspend on SMP

From: Stefan Richter <[email protected]>

It's not sufficiently documented that CONFIG_HOTPLUG_CPU is required for suspend/hibernation on SMP.

Point out the non-obvious.

---
 arch/i386/Kconfig   |    2 +-
 arch/x86_64/Kconfig |    7 +++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
arch/i386/Kconfig +1 -1
Index: linux-2.6.22-rc2/arch/i386/Kconfig
===================================================================
@@ -891,7 +891,7 @@ config PHYSICAL_ALIGN
 	  Don't change this unless you know what you are doing.
 
 config HOTPLUG_CPU
-	bool "Support for hot-pluggable CPUs (EXPERIMENTAL)"
+	bool "Support for suspend on SMP and hot-pluggable CPUs (EXPERIMENTAL)"
 	depends on SMP && HOTPLUG && EXPERIMENTAL && !X86_VOYAGER
 	---help---
 	  Say Y here to experiment with turning CPUs off and on, and to
arch/x86_64/Kconfig +5 -2
Index: linux-2.6.22-rc2/arch/x86_64/Kconfig
===================================================================
@@ -428,12 +428,15 @@ config NR_CPUS
 	  memory in the static kernel configuration.
 
 config HOTPLUG_CPU
-	bool "Support for hot-pluggable CPUs (EXPERIMENTAL)"
+	bool "Support for suspend on SMP and hot-pluggable CPUs (EXPERIMENTAL)"
 	depends on SMP && HOTPLUG && EXPERIMENTAL
 	help
 		Say Y here to experiment with turning CPUs off and on.  CPUs
 		can be controlled through /sys/devices/system/cpu/cpu#.
-		Say N if you want to disable CPU hotplug.
+		This is also required for suspend/hibernation on SMP systems.
+
+		Say N if you want to disable CPU hotplug and don't need to
+		suspend.
 
 config ARCH_ENABLE_MEMORY_HOTPLUG
 	def_bool y