Skip to contentSkip to conversation

: Fix overloaded use of apic= on bootline

PATCH New Prarit Bhargava 1 participant 1 message May 21, 2007 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Fix overloaded use of apic= on bootline

Andrew, I've submitted this a couple of times and it's had a review by Randy. Any chance we can get this in?

Thanks,

P.

The use of "apic=" on the boot line is overloaded. It is used once to override the type of genapic, and then later on it is used to determine a debug level. Because of this a bogus error message is sent to the console when using the debug option:

Unknown genapic `apic=debug' specified.

This patch changes the genapic situation to use "genapic=".

Documentation/kernel-parameters.txt +3 -0
index 09220a1..f156b59 100644
@@ -636,6 +636,9 @@ and is between 256 and 4096 characters. It is defined in the file
 
 	gamma=		[HW,DRM]
 
+	genapic=	[APIC,i386] Select a specific genapic type to be used.
+			Format: <name>
+
 	gdth=		[HW,SCSI]
 			See header of drivers/scsi/gdth.c.
 
arch/i386/mach-generic/probe.c +1 -1
index 74f3da6..ce78b15 100644
@@ -49,7 +49,7 @@ static int __init parse_apic(char *arg)
 	/* Parsed again by __setup for debug/verbose */
 	return 0;
 }
-early_param("apic", parse_apic);
+early_param("genapic", parse_apic);
 
 void __init generic_bigsmp_probe(void)
 {