Skip to contentSkip to conversation

RFC: Schedule EFS for removal.

PATCH Dave Jones 4 participants 11 messages May 21, 2007 – May 22, 2007 Documentation

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

EFS aparently is broken (See http://bugzilla.kernel.org/show_bug.cgi?id=1020)
has been so for some time, and attempts to fix it have been rejected. Given there's a userspace app to access these volumes, how
about scheduling it for removal ?

Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt~ +6 -0
@@ -346,3 +346,9 @@ Who:  Tejun Heo <[email protected]>
 
 ---------------------------
 
+What: EFS
+When: 2.6.24
+Why:  Unmaintained for some time, and also doesn't work.
+      Userspace replacement 'efslook' aparently works.
+      (See http://bugzilla.kernel.org/show_bug.cgi?id=1020)
+
Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw
Quoted 4 lines · Dave Jones

EFS aparently is broken (See http://bugzilla.kernel.org/show_bug.cgi?id=1020)
has been so for some time, and attempts to fix it have been rejected. Given there's a userspace app to access these volumes, how
about scheduling it for removal ?

It works perfectly fine, just not with the odd blocksizes on cdroms. SGI Australia folks are using it for exporting their irix cdrom images to various nfs systems for example, and I added that support long after the bug was opened.

So clear NACK for this.

author
#2 lore raw
Quoted 6 lines · Christoph Hellwig
Quoted 4 lines · Dave Jones

EFS aparently is broken (See http://bugzilla.kernel.org/show_bug.cgi?id=1020)
has been so for some time, and attempts to fix it have been rejected. Given there's a userspace app to access these volumes, how
about scheduling it for removal ?

Quoted 6 lines

It works perfectly fine, just not with the odd blocksizes on cdroms. SGI Australia folks are using it for exporting their irix cdrom images to various nfs systems for example, and I added that support long after the bug was opened.

So clear NACK for this.

Ah, that woke people up :-)
Ok, patch rescinded. Any opinion on what to do about that bug?

"use loopback" would be one option I guess.
Given its been an open bug for four years, there's obviously not that much interest in fixing the filesystem.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#3 lore raw
Quoted 5 lines

Ok, patch rescinded. Any opinion on what to do about that bug?

"use loopback" would be one option I guess.
Given its been an open bug for four years, there's obviously not that much interest in fixing the filesystem.

I don't think it's a bug, it's a lacking feature. The error message is quite accurate aswell.

author
#4 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 5 lines

Ok, patch rescinded. Any opinion on what to do about that bug?

"use loopback" would be one option I guess.
Given its been an open bug for four years, there's obviously not that much interest in fixing the filesystem.

I don't think it's a bug, it's a lacking feature. The error message is quite accurate aswell.

It seems to be a regression in 2.6.x though. From the report..

"Under 2.4.21, it doesnt do this."

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#5 lore raw
Quoted 7 lines · Dave Jones
Quoted 6 lines · Christoph Hellwig
Quoted 5 lines

Ok, patch rescinded. Any opinion on what to do about that bug?

"use loopback" would be one option I guess.
Given its been an open bug for four years, there's obviously not that much interest in fixing the filesystem.

Quoted 6 lines
Quoted 2 lines

I don't think it's a bug, it's a lacking feature. The error message is quite accurate aswell.

It seems to be a regression in 2.6.x though. From the report..

"Under 2.4.21, it doesnt do this."

Randy mentioned in bugzilla that 2.4.22 didn't work either, so I'd be very surprised if 2.4.21 works.

author
#6 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 10 lines · Dave Jones
Quoted 8 lines · Christoph Hellwig
Quoted 5 lines

Ok, patch rescinded. Any opinion on what to do about that bug?

"use loopback" would be one option I guess.
Given its been an open bug for four years, there's obviously not that much interest in fixing the filesystem.

I don't think it's a bug, it's a lacking feature. The error message is quite accurate aswell.

Quoted 6 lines
Quoted 3 lines

It seems to be a regression in 2.6.x though. From the report..

"Under 2.4.21, it doesnt do this."

Randy mentioned in bugzilla that 2.4.22 didn't work either, so I'd be very surprised if 2.4.21 works.

good point. I don't see anything obvious in 2.4.22 that would have caused a regression, so this sounds suspect.
I'll close the bugzilla out based on your comments, thanks for looking at it.

Dave

Signature · 1 line
http://www.codemonkey.org.uk
#7 lore raw
Quoted 6 lines · Dave Jones
Quoted 2 lines

Randy mentioned in bugzilla that 2.4.22 didn't work either, so I'd be very surprised if 2.4.21 works.

good point. I don't see anything obvious in 2.4.22 that would have caused a regression, so this sounds suspect.
I'll close the bugzilla out based on your comments, thanks for looking at it.

Btw, I'd like to take a look at Randy's patches for bigger block sizes, it might be quite easy to fix the remaining bits. Does anyone have a copy since the link doesn't work anymore?

#8 lore raw
Quoted 11 lines · On Mon, 21 May 2007 18:12:42 +0100 Christoph Hellwig wrote:
Quoted 6 lines · Dave Jones
Quoted 2 lines

Randy mentioned in bugzilla that 2.4.22 didn't work either, so I'd be very surprised if 2.4.21 works.

good point. I don't see anything obvious in 2.4.22 that would have caused a regression, so this sounds suspect.
I'll close the bugzilla out based on your comments, thanks for looking at it.

Btw, I'd like to take a look at Randy's patches for bigger block sizes, it might be quite easy to fix the remaining bits. Does anyone have a copy since the link doesn't work anymore?

Sorry about that. The patches are back in this dir:
http://www.xenotime.net/linux/efs/

but I don't recall much about them.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#9 lore raw
In reply to Dave Jones
Quoted 14 lines · Dave Jones
Quoted 13 lines · Christoph Hellwig
Quoted 12 lines · Dave Jones
Quoted 8 lines · Christoph Hellwig
Quoted 5 lines

Ok, patch rescinded. Any opinion on what to do about that bug?

"use loopback" would be one option I guess.
Given its been an open bug for four years, there's obviously not that much interest in fixing the filesystem.

I don't think it's a bug, it's a lacking feature. The error message is quite accurate aswell.

It seems to be a regression in 2.6.x though. From the report..

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

"Under 2.4.21, it doesnt do this."

Randy mentioned in bugzilla that 2.4.22 didn't work either, so I'd be very surprised if 2.4.21 works.

good point. I don't see anything obvious in 2.4.22 that would have caused a regression, so this sounds suspect.
I'll close the bugzilla out based on your comments, thanks for looking at it.

In my experience, often when people speak about 2.4.21 (which is quite old), they in fact refer to an RHEL3 kernel, which has a "few" addon patches :-) While I don't think that anything related to EFS might be changed in RHEL, may it be possible that it works as a side effect of a patch in this kernel ?

That's just pure guess anyway.

Cheers,
Willy

author
#10 lore raw
Quoted 9 lines · Willy Tarreau
Quoted 8 lines
Quoted 4 lines
Quoted 1 line

"Under 2.4.21, it doesnt do this."

Randy mentioned in bugzilla that 2.4.22 didn't work either, so I'd be very surprised if 2.4.21 works.

good point. I don't see anything obvious in 2.4.22 that would have caused a regression, so this sounds suspect.
I'll close the bugzilla out based on your comments, thanks for looking at it.

Quoted 7 lines

In my experience, often when people speak about 2.4.21 (which is quite old), they in fact refer to an RHEL3 kernel, which has a "few" addon patches :-) While I don't think that anything related to EFS might be changed in RHEL, may it be possible that it works as a side effect of a patch in this kernel ?

That's just pure guess anyway.

not unless it's a recompiled version. As shipped, RHEL3 has..

# CONFIG_EFS_FS is not set

Dave

Signature · 1 line
http://www.codemonkey.org.uk