UDF: check for allocated memory for data of new inodes v2

PATCH New Cyrill Gorcunov 1 participant 1 message May 21, 2007

lore

Share & tools

lore

Cyrill Gorcunov

author

2007-05-21 15:58 UTC #0 lore raw

PATCH 1/1 UDF: check for allocated memory for data of new inodes v2

This patch adds checking for granted memory for inode data at the moment of it's creation.

Signed-off-by Cyrill Gorcunov <[email protected]>

---

Andrew, it seems my previous patch didn't release mutex so there I've it fixed. Please replace the patch named 'udf-check-for-allocated-memory-for-data-of-new-inodes.patch' with this one.

 ialloc.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

ialloc.c +8 -1

index 8206983..10f3188 100644
@@ -50,7 +50,7 @@ void udf_free_inode(struct inode * inode)
 		else
 			UDF_SB_LVIDIU(sb)->numFiles =
 				cpu_to_le32(le32_to_cpu(UDF_SB_LVIDIU(sb)->numFiles) - 1);
-		
+
 		mark_buffer_dirty(sbi->s_lvidbh);
 	}
 	mutex_unlock(&sbi->s_alloc_mutex);

@@ -136,6 +136,13 @@ struct inode * udf_new_inode (struct inode *dir, int mode, int * err)
 		UDF_I_EFE(inode) = 0;
 		UDF_I_DATA(inode) = kzalloc(inode->i_sb->s_blocksize - sizeof(struct fileEntry), GFP_KERNEL);
 	}
+	if (!UDF_I_DATA(inode))
+	{
+		iput(inode);
+		*err = -ENOMEM;
+		mutex_unlock(&sbi->s_alloc_mutex);
+		return NULL;
+	}
 	if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_USE_AD_IN_ICB))
 		UDF_I_ALLOCTYPE(inode) = ICBTAG_FLAG_AD_IN_ICB;
 	else if (UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_USE_SHORT_AD))