Skip to contentSkip to conversation

add missing 'console' var to default mpc8349itx config

PATCH New Nikita V. Youshchenko 3 participants 3 messages May 23, 2007 – Jun 1, 2007

lore
Share & tools
lore

Nikita V. Youshchenko

author
#0 lore raw

PATCH 1/1 add missing 'console' var to default mpc8349itx config

Default environment defined inside include/configs/MPC8349ITX.h file, references 'console' variable, but does not define it.

This patch fixes this.

Also it adds usage of new CONFIG_CONSOLE macro in default bootargs, for consistency.

Signed-off-by Nikita Youshchenko <[email protected]>
include/configs/MPC8349ITX.h +3 -1
@@ -289,6 +289,7 @@ boards, we say we have two, but don't di
 #define CFG_BAUDRATE_TABLE  \
        {300, 600, 1200, 2400, 4800, 9600, 19200, 38400, 115200}
 
+#define CONFIG_CONSOLE         ttyS0
 #define CONFIG_BAUDRATE                115200
 
 #define CFG_NS16550_COM1       (CFG_IMMR + 0x4500)

@@ -670,9 +679,10 @@ boards, we say we have two, but don't di
        " ip=" MK_STR(CONFIG_IPADDR) ":" MK_STR(CONFIG_SERVERIP) ":"    \
                MK_STR(CONFIG_GATEWAYIP) ":" MK_STR(CONFIG_NETMASK) ":" \
                MK_STR(CONFIG_HOSTNAME) ":" MK_STR(CONFIG_NETDEV) ":off" \
-       " console=ttyS0," MK_STR(CONFIG_BAUDRATE)
+       " console=" MK_STR(CONFIG_CONSOLE) "," MK_STR(CONFIG_BAUDRATE)
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
+       "console=" MK_STR(CONFIG_CONSOLE) "\0"                          \
        "netdev=" MK_STR(CONFIG_NETDEV) "\0"                            \
        "uboot=" MK_STR(CONFIG_UBOOTPATH) "\0"                          \
        "tftpflash=tftpboot $loadaddr $uboot; "                         \

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070523/41eb9b8c/attachment.pgp

#1 lore raw

PATCH 1/1 add missing 'console' var to default mpc8349itx config

Quoted 9 lines · Nikita V. Youshchenko

Default environment defined inside include/configs/MPC8349ITX.h file, references 'console' variable, but does not define it.

This patch fixes this.

Also it adds usage of new CONFIG_CONSOLE macro in default bootargs, for consistency.

Signed-off-by Nikita Youshchenko <[email protected]>
Acked-by Timur Tabi <[email protected]>

Kim, please apply.

Signature · 2 lines
Timur Tabi
Linux Kernel Developer @ Freescale
Applied
#2 lore raw

PATCH 1/1 add missing 'console' var to default mpc8349itx config

In reply to Nikita V. Youshchenko
Quoted 10 lines · On Wed, 23 May 2007 12:45:25 +0400 "Nikita V. Youshchenko" <[email protected]>…

Default environment defined inside include/configs/MPC8349ITX.h file, references 'console' variable, but does not define it.

This patch fixes this.

Also it adds usage of new CONFIG_CONSOLE macro in default bootargs, for consistency.

Signed-off-by Nikita Youshchenko <[email protected]>

applied, thanks.

please don't send patches in nested multipart messages in the future.

Kim