OMAP: 2430SDP: Support LCD display as a FB device

Add glue to control the 2430SDP LCD as a frame buffer device using the existing dispc.c driver under omapfb.

---
diff -Nurd --exclude=Image --exclude=uImage --exclude zImage --exclude vmlinux --exclude System.map --exclude Module.symvers --exclude .version --exclude asm-offsets.h --exclude mach-types.h --exclude .config --exclude .config.old --exclude bzImage --exclude autoconf.h --exclude keywords.c --exclude 'lex.*' --exclude parse.c --exclude parse.h --exclude 'zconf.*' --exclude '*.d' --exclude auto.conf --exclude kernel.release --exclude compile.h --exclude utsrelease.h --exclude version.h --exclude crc32table.h --exclude consolemap_deftbl.c --exclude defkeymap.c --exclude clut_vga16.c --exclude 'logo_*.c' --exclude '*.tmp' --exclude '.tmp_*' --exclude '.missing-*' --exclude '*.gz' --exclude='vmlinux.*' --exclude '*.s' --exclude='*.o' --exclude='*.o.cmd' --exclude '*.a' --exclude '*.ko' --exclude '*.cmd' --exclude '*.mod.c' linux-omap-2.6.orig/arch/arm/mach-omap2/board-2430sdp.c linux-omap-2.6
/arch/arm/mach-omap2/board-2430sdp.c

@@ -113,6 +113,11 @@
 	},
 };
 
+static struct platform_device sdp2430_lcd_device = {
+	.name		= "sdp2430_lcd",
+	.id		= -1,
+};
+
 static struct platform_device sdp2430_smc91x_device = {
 	.name		= "smc91x",
 	.id		= -1,

@@ -123,6 +128,7 @@
 static struct platform_device *sdp2430_devices[] __initdata = {
 	&sdp2430_smc91x_device,
 	&sdp2430_flash_device,
+	&sdp2430_lcd_device,
 };
 
 static struct tsc2046_platform_data tsc2046_config = {

@@ -135,6 +141,10 @@
 	.single_channel = 0,  /* 0: slave, 1: master */
 };
 
+static struct omap_lcd_config sdp2430_lcd_config __initdata = {
+	.ctrl_name	= "internal",
+};
+
 static struct spi_board_info sdp2430_spi_board_info[] __initdata = {
 	[0] = {
 		/*

@@ -221,6 +231,7 @@
 
 static struct omap_board_config_kernel sdp2430_config[] = {
 	{OMAP_TAG_UART, &sdp2430_uart_config},
+	{OMAP_TAG_LCD, &sdp2430_lcd_config},
 };
 
 #if	defined(CONFIG_I2C_OMAP) || defined(CONFIG_I2C_OMAP_MODULE)

diff -Nurd --exclude=Image --exclude=uImage --exclude zImage --exclude vmlinux --exclude System.map --exclude Module.symvers --exclude .version --exclude asm-offsets.h --exclude mach-types.h --exclude .config --exclude .config.old --exclude bzImage --exclude autoconf.h --exclude keywords.c --exclude 'lex.*' --exclude parse.c --exclude parse.h --exclude 'zconf.*' --exclude '*.d' --exclude auto.conf --exclude kernel.release --exclude compile.h --exclude utsrelease.h --exclude version.h --exclude crc32table.h --exclude consolemap_deftbl.c --exclude defkeymap.c --exclude clut_vga16.c --exclude 'logo_*.c' --exclude '*.tmp' --exclude '.tmp_*' --exclude '.missing-*' --exclude '*.gz' --exclude='vmlinux.*' --exclude '*.s' --exclude='*.o' --exclude='*.o.cmd' --exclude '*.a' --exclude '*.ko' --exclude '*.cmd' --exclude '*.mod.c' linux-omap-2.6.orig/drivers/video/omap/Makefile linux-omap-2.6/drivers
/video/omap/Makefile

@@ -28,6 +28,7 @@
 objs-y$(CONFIG_MACH_OMAP_OSK) += lcd_osk.o
 objs-y$(CONFIG_MACH_OMAP_PERSEUS2) += lcd_p2.o
 objs-y$(CONFIG_MACH_OMAP_APOLLON) += lcd_apollon.o
+objs-y$(CONFIG_MACH_OMAP_2430SDP) += lcd_2430sdp.o
 
 objs-y$(CONFIG_FB_OMAP_LCD_MIPID) += lcd_mipid.o
 

diff -Nurd --exclude=Image --exclude=uImage --exclude zImage --exclude vmlinux --exclude System.map --exclude Module.symvers --exclude .version --exclude asm-offsets.h --exclude mach-types.h --exclude .config --exclude .config.old --exclude bzImage --exclude autoconf.h --exclude keywords.c --exclude 'lex.*' --exclude parse.c --exclude parse.h --exclude 'zconf.*' --exclude '*.d' --exclude auto.conf --exclude kernel.release --exclude compile.h --exclude utsrelease.h --exclude version.h --exclude crc32table.h --exclude consolemap_deftbl.c --exclude defkeymap.c --exclude clut_vga16.c --exclude 'logo_*.c' --exclude '*.tmp' --exclude '.tmp_*' --exclude '.missing-*' --exclude '*.gz' --exclude='vmlinux.*' --exclude '*.s' --exclude='*.o' --exclude='*.o.cmd' --exclude '*.a' --exclude '*.ko' --exclude '*.cmd' --exclude '*.mod.c' linux-omap-2.6.orig/drivers/video/omap/lcd_2430sdp.c linux-omap-2.6/dr
ivers/video/omap/lcd_2430sdp.c

Thanks, pushing today.

Tony

Tony,

Why are we having so many board-2430sdp variants? we now have arch/arm/mach-omap2/board-2430sdp.c arch/arm/mach-omap2/board-2430sdp-flash.c arch/arm/mach-omap2/board-2430sdp-usb.c. Now one more... cant we plug these 100 liner codes into board-2430sdp.c?
Regards,
Nishanth Menon

Hmm, the display changes were indeed added to board-2430.c, not to anthoer new file.

Personally, I think the multiple board files are easier to read, and cleaner. Did you notice all the board-n800* files?

Kevin

Yeah eventually we may want to have subdirectories for each board if there are lots of devices to initialize. But let's not do that right now :)

Tony

Sorry, an oversight. This goes on top of the original patch. More potential changes pending the mentioned discussions.

-- Hunyue

@@ -35,11 +35,6 @@
 #define PM_RECEIVER             TWL4030_MODULE_PM_RECIEVER
 #define ENABLE_VAUX2_DEDICATED  0x09
 #define ENABLE_VAUX2_DEV_GRP    0x20
-#define TWL4030_VAUX2_DEV_GRP           0x1B 
-#define TWL4030_VAUX2_DEDICATED         0x1E
-#define TWL4030_MODULE_PM_RECIEVER  0x13
-
-
 
 #define t2_out(c, r, v) twl4030_i2c_write_u8(c, r, v)
 

Generally if we are putting a new file to list, it's better to mark it as an RFC or RFC / PATCH. So that Tony takes up this in his next series of pushes and we get some chance to review the code.

And for 2430 LCD please have discussions on list before working. Imre and I had a discussion a month back but due to other priorities we were not able to sync up again. There are good pointers that we have which can bring the code in a better shape.

We have to work on 2420 2430 3430 Display subsystem for many boards that have different kind of interfaces like parallel, RFBI, DSI etc and software stack interface to FBDEV, V4L, etc.

Lets re-start a thread may be early next week with Imre, Kevin, Hunyue. Let's come up with a framework later who ever gets time can contribute.

Regards,
Khasim

OK, I guess we were a bit premature. I told Hunyue to post this here and gave my signoff, alieit a bit prematurely it appears.

Sounds good. Khasim, could you start up the thread next week, summarizing where you and Imre were in these discussions?

Thanks,

Kevin

Sorry, this was maybe a bit hasty push on my part :)

Sounds like that's a different thread, the LCD panel configuration should still be the same, right?

Tony