LOGO: All logos must be placed into the "logos" directory.

PATCH New Rodolfo Giometti 3 participants 8 messages May 25, 2007 – May 28, 2007

lore

Share & tools

lore

Rodolfo Giometti

author

2007-05-25 14:20 UTC #0 lore raw

PATCH 1/1 LOGO: All logos must be placed into the "logos" directory.

Signed-off-by Rodolfo Giometti <[email protected]>

---
 tools/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

tools/Makefile +3 -3

index 6177f90..14eedf0 100644
@@ -40,7 +40,7 @@ endif
 LOGO_H	= $(OBJTREE)/include/bmp_logo.h
 
 ifeq ($(LOGO_BMP),)
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= denx.bmp
 endif
 
 #-------------------------------------------------------------------------

@@ -203,8 +203,8 @@ $(obj)crc32.c:
 		@rm -f $(obj)crc32.c
 		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
 
-$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
-		$(obj)./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	$(obj)bmp_logo logos/$(LOGO_BMP)
+		$(obj)./bmp_logo logos/$(LOGO_BMP) >$@
 
 #########################################################################

Signature · 1 line

1.5.1.1

Wolfgang Denk

2007-05-25 14:26 UTC #1 lore raw

PATCH 1/1 LOGO: All logos must be placed into the "logos" directory.

Quoted 2 lines · In message <[email protected]> you wrote:

Subject: ... All logos must be placed into the "logos" directory.

Why?

tools/Makefile endif · line 43

Quoted 3 lines

ifeq ($(LOGO_BMP),)
tools/Makefile +1 -1
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= denx.bmp

Which problem is this supposed to fix? I don't see any advantage, but I see the disadvantage that with your patch you cannot chose to place your logo - say - in board/.../ any more.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Landing: a controlled mid-air collision with a planet.

Rodolfo Giometti

2007-05-25 14:52 UTC #2 lore raw

PATCH 1/1 LOGO: All logos must be placed into the "logos" directory.

Quoted 6 lines · Wolfgang Denk

Quoted 2 lines · In message <[email protected]> you wrote:
Subject: ... All logos must be placed into the "logos" directory.
Why?

Quoted 7 lines

tools/Makefile endif · line 43
Quoted 3 lines
ifeq ($(LOGO_BMP),)
tools/Makefile +1 -1
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= denx.bmp
Which problem is this supposed to fix? I don't see any advantage, but I see the disadvantage that with your patch you cannot chose to place your logo - say - in board/.../ any more.

I don't want to fix any problem, I just wish to define some standards... doing like this I force all logo files to be inside tools/logos directory.

Currently logos are supposed to be under tools directory which is not the proper place for them:

   $(LOGO_H):      $(obj)bmp_logo logos/$(LOGO_BMP)
                   $(obj)./bmp_logo logos/$(LOGO_BMP) >$@

Ciao,

Rodolfo

Signature · 4 lines

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127

Wolfgang Denk

2007-05-25 15:43 UTC #3 lore raw

PATCH 1/1 LOGO: All logos must be placed into the "logos" directory.

Quoted 4 lines · In message <[email protected]> you wrote:

I don't want to fix any problem, I just wish to define some standards... doing like this I force all logo files to be inside tools/logos directory.

Why would you want to do that? Unix philosophy is *not* enforcing users to to certain things, but let users decide what's good for them.

Quoted 5 lines

Currently logos are supposed to be under tools directory which is not the proper place for them:
   $(LOGO_H):      $(obj)bmp_logo logos/$(LOGO_BMP)
                   $(obj)./bmp_logo logos/$(LOGO_BMP) >$@

The current code uses LOGO_BMP and defines a default value for it (logos/denx.bmp); it gives the user the freedom to overwrite this default. This is a good thing.

I don't want to lose that freedom, especially not when the new situation brings no advantages.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As in certain cults it is possible to kill a process if you know  its
true name.                      -- Ken Thompson and Dennis M. Ritchie

Rodolfo Giometti

2007-05-25 16:02 UTC #4 lore raw

PATCH 1/1 LOGO: All logos must be placed into the "logos" directory.

Quoted 7 lines · Wolfgang Denk

The current code uses LOGO_BMP and defines a default value for it (logos/denx.bmp); it gives the user the freedom to overwrite this default. This is a good thing.
I don't want to lose that freedom, especially not when the new situation brings no advantages.

Ok, so what should I do to allow developers to define their preferred logos?

Ciao,

Rodolfo

Signature · 4 lines

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127

Rodolfo Giometti

author

2007-05-27 14:58 UTC #5 lore raw

PATCH 1/1 LOGO: Allow each board to define its own logo.

In reply to Wolfgang Denk

This allow developers to define per board logo file into boards' main configuration file (board/*/config.mk) as follow:

	# The logo bitmap
	LOGO_BMP = board/<name>/<logo>.bmp

Signed-off-by Rodolfo Giometti <[email protected]>

---
 tools/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

tools/Makefile +3 -3

index 6177f90..ad2824d 100644
@@ -40,7 +40,7 @@ endif
 LOGO_H	= $(OBJTREE)/include/bmp_logo.h
 
 ifeq ($(LOGO_BMP),)
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= tools/logos/denx.bmp
 endif
 
 #-------------------------------------------------------------------------

@@ -203,8 +203,8 @@ $(obj)crc32.c:
 		@rm -f $(obj)crc32.c
 		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
 
-$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
-		$(obj)./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	$(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
+		$(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@
 
 #########################################################################

Signature · 1 line

1.5.1.1

Wolfgang Denk

2007-05-27 20:58 UTC #6 lore raw

PATCH 1/1 LOGO: Allow each board to define its own logo.

Quoted 2 lines · In message <[email protected]> you wrote:

This allow developers to define per board logo file into boards' main configuration file (board/*/config.mk) as follow:

Sorry, but this is a misconception. The board/*/config.mk is NOT a configuration file intended for such settings. The boards' main con- figuration file is include/configs/<name>.h, and as far as possible all configuration should be set there.

Quoted 13 lines

	# The logo bitmap
	LOGO_BMP = board/<name>/<logo>.bmp

Signed-off-by Rodolfo Giometti <[email protected]>

---
 tools/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

tools/Makefile +0 -0

index 6177f90..ad2824d 100644

tools/Makefile endif · line 46

Quoted 8 lines

tools/Makefile +1 -1

@@ -40,7 +40,7 @@ endif
 LOGO_H	= $(OBJTREE)/include/bmp_logo.h
 
 ifeq ($(LOGO_BMP),)
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= tools/logos/denx.bmp
 endif
 
 #-------------------------------------------------------------------------

Until here, I see no advantage by this patch. I don't think adding another level of subdirectoris is a win.

tools/Makefile $(obj)crc32.c: · line 207

Quoted 8 lines

tools/Makefile +2 -2

@@ -203,8 +203,8 @@ $(obj)crc32.c:
 		@rm -f $(obj)crc32.c
 		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
 
-$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
-		$(obj)./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	$(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
+		$(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@

But this is a change to the worse. Before, I could define (for example on the "make" command line:

LOGO_BMP=/some/other/path/foo.bmp

which will now break as you unconditionally prefix this setting with $(TOPDIR).

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4

Rodolfo Giometti

2007-05-28 07:52 UTC #7 lore raw

PATCH 1/1 LOGO: Allow each board to define its own logo.

Quoted 8 lines · Wolfgang Denk

Quoted 2 lines · In message <[email protected]> you wrote:
This allow developers to define per board logo file into boards' main configuration file (board/*/config.mk) as follow:
Sorry, but this is a misconception. The board/*/config.mk is NOT a configuration file intended for such settings. The boards' main con- figuration file is include/configs/<name>.h, and as far as possible all configuration should be set there.

But doing like this how can I define the file to supply to the logo_bmp utility? This settings is needed to get the file "include/bmp_logo.h" which in turn is used for the compilation stage.

Quoted 9 lines

tools/Makefile endif · line 46
Quoted 6 lines
ifeq ($(LOGO_BMP),)
tools/Makefile +1 -1
-LOGO_BMP= logos/denx.bmp
+LOGO_BMP= tools/logos/denx.bmp
 endif
 
 #-------------------------------------------------------------------------
Until here, I see no advantage by this patch. I don't think adding another level of subdirectoris is a win.

This is due the next change.

Quoted 12 lines

tools/Makefile $(obj)crc32.c: · line 207
Quoted 8 lines
tools/Makefile +2 -2
@@ -203,8 +203,8 @@ $(obj)crc32.c:
 		@rm -f $(obj)crc32.c
 		ln -s $(src)../lib_generic/crc32.c $(obj)crc32.c
 
-$(LOGO_H):	$(obj)bmp_logo $(LOGO_BMP)
-		$(obj)./bmp_logo $(LOGO_BMP) >$@
+$(LOGO_H):	$(obj)bmp_logo $(TOPDIR)/$(LOGO_BMP)
+		$(obj)./bmp_logo $(TOPDIR)/$(LOGO_BMP) >$@
But this is a change to the worse. Before, I could define (for example on the "make" command line:

Quoted 4 lines

LOGO_BMP=/some/other/path/foo.bmp
which will now break as you unconditionally prefix this setting with $(TOPDIR).

I see...

I'm trying to find a good way to allow developers to define their own logos since currently only denx.bmp is used in a not configurable way (or at least I didn't find it).

Ciao,

Rodolfo

Signature · 4 lines

GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127