LOGO: Allow define "LOGO_BMP" to be globally defined.
PATCH 1/1 LOGO: Allow define "LOGO_BMP" to be globally defined.
This allow developers to define per board logo file into main configuration file as follow:
wwpc1100_config : unconfig
@$(MKCONFIG) $(@:_config=) arm pxa wwpc1100 @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk
--- Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
@@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk)) # load ARCH, BOARD, and CPU configuration include $(OBJTREE)/include/config.mk -export ARCH CPU BOARD VENDOR SOC +export ARCH CPU BOARD VENDOR SOC LOGO_BMP ifndef CROSS_COMPILE ifeq ($(HOSTARCH),ppc)
@@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc) CROSS_COMPILE = powerpc-linux- endif ifeq ($(ARCH),arm) -CROSS_COMPILE = arm-eurotech-linux- +CROSS_COMPILE = arm-linux- endif ifeq ($(ARCH),i386) ifeq ($(HOSTARCH),i386)
Signature · 1 line
1.5.1.1
PATCH 1/1 LOGO: Allow define "LOGO_BMP" to be globally defined.
Quoted 6 lines · In message <[email protected]> you wrote:
This allow developers to define per board logo file into main configuration file as follow:
wwpc1100_config: unconfig@$(MKCONFIG) $(@:_config=) arm pxa wwpc1100 @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mk
I don't like this. This adds configuration information into Makefile, where it does not belong.
Please don't do this.
Quoted 3 lines
Makefile +0
-0@@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))
...
Makefile ifeq ($(ARCH),ppc) · line 128
Quoted 5 lines
Makefile +0
-1@@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc) CROSS_COMPILE = powerpc-linux- endif ifeq ($(ARCH),arm) -CROSS_COMPILE = arm-eurotech-linux-
^^^^^^^^^^^^^^^^^^^ What's that?
Makefile ifeq ($(ARCH),ppc) · line 128
Quoted 1 line
Makefile +1
-0+CROSS_COMPILE = arm-linux-
Also, this patch does not apply.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Just think of a computer as hardware you can program." - Nigel de la Tierre
PATCH 1/1 LOGO: Allow define "LOGO_BMP" to be globally defined.
Quoted 4 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:
This allow developers to define per board logo file into main configuration file as follow:
Quoted 8 lines
Quoted 3 lines
wwpc1100_config: unconfig@$(MKCONFIG) $(@:_config=) arm pxa wwpc1100 @echo "LOGO_BMP = wwpc1100.bmp" >> include/config.mkI don't like this. This adds configuration information into
Makefile, where it does not belong.Please don't do this.
So where should I add this info?
Quoted 11 lines
Quoted 4 lines
Makefile +0
-0@@ -115,7 +115,7 @@ ifeq ($(OBJTREE)/include/config.mk,$(wildcard $(OBJTREE)/include/config.mk))...
Makefile ifeq ($(ARCH),ppc) · line 128
Quoted 5 lines
Makefile +0
-1@@ -125,7 +125,7 @@ ifeq ($(ARCH),ppc) CROSS_COMPILE = powerpc-linux- endif ifeq ($(ARCH),arm) -CROSS_COMPILE = arm-eurotech-linux-^^^^^^^^^^^^^^^^^^^ What's that?
Quoted 3 lines
Makefile ifeq ($(ARCH),ppc) · line 128
Quoted 1 line
Makefile +1
-0+CROSS_COMPILE = arm-linux-Also, this patch does not apply.
Ooops! Sorry, that was my fault... :'(
Ciao,
Rodolfo
Signature · 4 lines
GNU/Linux Solutions e-mail: giometti at enneenne.com Linux Device Driver giometti at gnudd.com Embedded Systems giometti at linux.it UNIX programming phone: +39 349 2432127
PATCH 1/1 LOGO: Allow define "LOGO_BMP" to be globally defined.
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 5 lines
I don't like this. This adds configuration information into
Makefile, where it does not belong.Please don't do this.
So where should I add this info?
In your board config file?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de All these theories, diverse as they are, have two things in common: they explain the observed facts, and they are completeley and utterly wrong. - Terry Pratchett, _The Light Fantastic_
PATCH 1/1 LOGO: Allow define "LOGO_BMP" to be globally defined.
Quoted 2 lines · Wolfgang Denk
In your board config file?
Do you mean "board/*/config.mk" files?
Ciao,
Rodolfo
Signature · 4 lines
GNU/Linux Solutions e-mail: giometti at enneenne.com Linux Device Driver giometti at gnudd.com Embedded Systems giometti at linux.it UNIX programming phone: +39 349 2432127
PATCH 1/1 LOGO: Allow define "LOGO_BMP" to be globally defined.
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 2 lines
In your board config file?
Do you mean "
board/*/config.mk" files?
No, I mean include/configs/<board>.h
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de One possible reason that things aren't going according to plan is that there never was a plan in the first place.
PATCH 1/1 LOGO: Allow define "LOGO_BMP" to be globally defined.
Quoted 7 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 2 lines
In your board config file?
Do you mean "
board/*/config.mk" files?No, I mean include/configs/<board>.h
How I can do that? =:-o
Define LOGO_BMP is used into tools/Makefile to generate file include/bmp_logo.h as follow:
$(LOGO_H): $(obj)bmp_logo $(LOGO_BMP)
$(obj)./bmp_logo $(LOGO_BMP) >$@
How I can use it if it must be defined into include/configs/<board>.h?
Ciao,
Rodolfo
Signature · 4 lines
GNU/Linux Solutions e-mail: giometti at enneenne.com Linux Device Driver giometti at gnudd.com Embedded Systems giometti at linux.it UNIX programming phone: +39 349 2432127