Skip to contentSkip to conversation

USB: set default y for CONFIG_USB_DEVICE_CLASS

PATCH Kay Sievers 3 participants 4 messages May 27, 2007 USB

lore
Share & tools
lore
#0 lore raw

From: Kay Sievers <[email protected]>
Subject: USB: set default y for CONFIG_USB_DEVICE_CLASS

---

drivers/usb/core/Kconfig +13 -9
index f493fb1..346fc03 100644
@@ -40,21 +40,25 @@ config USB_DEVICEFS
 config USB_DEVICE_CLASS
 	bool "USB device class-devices (DEPRECATED)"
 	depends on USB
-	default n
+	default y
 	---help---
 	  Userspace access to USB devices is granted by device-nodes exported
 	  directly from the usbdev in sysfs. Old versions of the driver
 	  core and udev needed additional class devices to export device nodes.
 
 	  These additional devices are difficult to handle in userspace, if
-	  information about USB interfaces must be available. One device contains
-	  the device node, the other device contains the interface data. Both
-	  devices are at the same level in sysfs (siblings) and one can't access
-	  the other. The device node created directly by the usbdev is the parent
-	  device of the interface and therefore easily accessible from the interface
-	  event.
-
-	  This option provides backward compatibility if needed.
+	  information about USB interfaces must be available. One device
+	  contains the device node, the other device contains the interface
+	  data. Both devices are at the same level in sysfs (siblings) and one
+	  can't access the other. The device node created directly by the
+	  usb device is the parent device of the interface and therefore
+	  easily accessible from the interface event.
+
+	  This option provides backward compatibility for libusb device
+	  nodes (lsusb) when usbfs is not used, and the following udev rule
+	  doesn't exist:
+	    SUBSYSTEM=="usb", ACTION=="add", ENV{DEVTYPE}=="usb_device", \
+	    NAME="bus/usb/$env{BUSNUM}/$env{DEVNUM}", MODE="0644"
 
 config USB_DYNAMIC_MINORS
 	bool "Dynamic USB minor allocation (EXPERIMENTAL)"
#1 lore raw
Quoted 11 lines · Kay Sievers

From: Kay Sievers <[email protected]>
Subject: USB: set default y for CONFIG_USB_DEVICE_CLASS

---

drivers/usb/core/Kconfig +0 -0
index f493fb1..346fc03 100644

drivers/usb/core/Kconfig config USB_DEVICEFS · line 43

Quoted 5 lines
drivers/usb/core/Kconfig +1 -1
@@ -40,21 +40,25 @@ config USB_DEVICEFS
 config USB_DEVICE_CLASS
        bool "USB device class-devices (DEPRECATED)"
        depends on USB
-       default n
+       default y

It puzzles me why a deprecated option should be default 'Y'...

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#2 lore raw
Quoted 6 lines · Jesper Juhl

drivers/usb/core/Kconfig config USB_DEVICEFS · line 43

Quoted 4 lines

bool "USB device class-devices (DEPRECATED)" depends on USB

drivers/usb/core/Kconfig +1 -1
-       default n
+       default y

It puzzles me why a deprecated option should be default 'Y'...

Because if it defaults to 'n', a 'make oldconfig' will break unmodified userspace on reboot, which is something we don't want to do in a 'stable' series, without announcing it first for a serious length of time.

Bert

Signature · 2 lines
http://www.PowerDNS.com      Open source, database driven DNS Software 
http://netherlabs.nl              Open and Closed source services
#3 lore raw
In reply to Jesper Juhl
Quoted 7 lines · Jesper Juhl
Quoted 6 lines · Kay Sievers

From: Kay Sievers <[email protected]>
Subject: USB: set default y for CONFIG_USB_DEVICE_CLASS

---

Quoted 12 lines

drivers/usb/core/Kconfig config USB_DEVICEFS · line 43

Quoted 10 lines
drivers/usb/core/Kconfig +1 -1
index f493fb1..346fc03 100644
@@ -40,21 +40,25 @@ config USB_DEVICEFS
 config USB_DEVICE_CLASS
        bool "USB device class-devices (DEPRECATED)"
        depends on USB
-       default n
+       default y

It puzzles me why a deprecated option should be default 'Y'...

Because usb_device class devices are kind of broken regarding the event timing, and should not be used anymore. They are replaced by device-nodes created by the real usb-device, but some systems still depend on the class devices:
http://lkml.org/lkml/2007/5/27/56

We better default to y for a while until the users have switched over.

Kay