Block device elevator: use list_for_each_entry() instead of list_for_each()
PATCH 1/1 Block device elevator: use list_for_each_entry() instead of list_for_each()
Use list_for_each_entry() instead of list_for_each() in the block device elevator
--
block/elevator.c +3 -10
@@ -112,12 +112,8 @@ static inline int elv_try_merge(struct request *__rq, struct bio *bio)static struct elevator_type *elevator_find (const char *name) {struct elevator_type *e; -struct list_head *entry; - -list_for_each (entry, &elv_list) { - - e = list_entry(entry, struct elevator_type, list); +list_for_each_entry (e, &elv_list, list) {if (!strcmp (e->elevator_name, name))return e; }
@@ -1116,14 +1112,11 @@ ssize_t elv_iosched_show(request_queue_t *q, char *name) {elevator_t *e = q->elevator;struct elevator_type *elv = e->elevator_type; -struct list_head *entry; +struct elevator_type *__e;int len =0 ;spin_lock (&elv_list_lock); -list_for_each (entry, &elv_list) { -struct elevator_type *__e; - - __e = list_entry(entry, struct elevator_type, list); +list_for_each_entry (__e, &elv_list, list) {if (!strcmp (elv->elevator_name, __e->elevator_name)) len +=sprintf (name+len,"[%s] " , elv->elevator_name);else
Signature · 12 lines
Matthias Kaehlcke
Linux Application Developer
Barcelona
Usually when people are sad, they don't do anything. They just cry over
their condition. But when they get angry, they bring about a change
(Malcolm X)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-it makes sense to what it does.
Quoted 62 lines · Matthias Kaehlcke
Use
list_for_each_entry()instead oflist_for_each()in the block device elevatorSigned-off-by Matthias Kaehlcke <[email protected]>--
block/elevator.c +3
-11@@ -112,12 +112,8 @@ static inline int elv_try_merge(struct request *__rq, struct bio *bio)static struct elevator_type *elevator_find (const char *name) {struct elevator_type *e; -struct list_head *entry; - -list_for_each (entry, &elv_list) { - - e = list_entry(entry, struct elevator_type, list); +list_for_each_entry (e, &elv_list, list) {if (!strcmp (e->elevator_name, name))return e; }@@ -1116,14 +1112,11 @@ ssize_t elv_iosched_show(request_queue_t *q, char *name) {elevator_t *e = q->elevator;struct elevator_type *elv = e->elevator_type; -struct list_head *entry; +struct elevator_type *__e;int len =0 ;spin_lock (&elv_list_lock); -list_for_each (entry, &elv_list) { -struct elevator_type *__e; - - __e = list_entry(entry, struct elevator_type, list); +list_for_each_entry (__e, &elv_list, list) {if (!strcmp (elv->elevator_name, __e->elevator_name)) len +=sprintf (name+len,"[%s] " , elv->elevator_name);else --Matthias Kaehlcke
Linux Application Developer
BarcelonaUsually when people are sad, they don't do anything. They just cry over
their condition. But when they get angry, they bring about a change
(Malcolm X)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
.'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 2 lines
Denis Cheng Linux Application Developer