sun_esp.c build for sparc32 UP
PATCH 1/1 sun_esp.c build for sparc32 UP
A sparc32 UP build of the new ESP driver gives these build errors:
CC drivers/scsi/sun_esp.odrivers/scsi/sun_esp.c: In function `sbus_esp_reset_dma':drivers/scsi/sun_esp.c:294: error: `loops_per_jiffy' undeclared (first use in this function) drivers/scsi/sun_esp.c:294: error: (Each undeclared identifier is reported only once drivers/scsi/sun_esp.c:294: error: for each function it appears in.) drivers/scsi/sun_esp.c: In function `sbus_esp_dma_drain':drivers/scsi/sun_esp.c:364: error: loops_per_jiffy' undeclared (first use in this function) drivers/scsi/sun_esp.c: In function sbus_esp_dma_invalidate':drivers/scsi/sun_esp.c:396: error: `loops_per_jiffy' undeclared (first use in this function) make[2]: *** [drivers/scsi/sun_esp.o] Error 1
These are due to udelay(). The code includes asm/delay.h (indirectly), but that is not enough to make it work.
Martin
---
Index: linux/drivers/scsi/sun_esp.c
=================================--- linux.orig/drivers/scsi/sun_esp.c 2007-05-26 22:16:06.000000000 +0100
+++ linux/drivers/scsi/sun_esp.c 2007-05-27 23:05:52.000000000 +0100
@@ -7,6 +7,7 @@
#include <linux/types.h>
#include <linux/module.h>
#include <linux/init.h>
+#include <linux/delay.h>
#include <asm/irq.h>
#include <asm/io.h>
From: Martin Habets <[email protected]>
Date: Tue, 29 May 2007 00:43:04 +0100
Quoted 2 lines
These are due to
udelay(). The code includesasm/delay.h(indirectly), but that is not enough to make it work.
Indeed, my initial suspicion was right, I have fixed this already in my sparc-2.6 GIT tree since late last week.
I've been meaning to push this fix to Linus along with the rest of my sparc-2.6 GIT tree but it's been waiting on a sparc64 bug fix that haven't been able to complete due to a binutils bug which I only figured out late last night.
So please be patient or use my sparc-2.6 GIT tree :-)