Skip to contentSkip to conversation

: -mm tree remove __exit from loop_exit

PATCH New Prarit Bhargava 1 participant 1 message May 31, 2007 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : -mm tree remove __exit from loop_exit

I sent this to lkml (and a large # of cc's). Tony, please do not pick this up in your tree. I'm posting this here just so SGI users have this info ...

P.

Andrew, please patch ASAP as compile on SGI ia64 is broken. Please note this patch does not address why modpost did not pick up this error.

ie) ./scripts/mod/modpost drivers/block/built-in.o yields no information about the section mismatch. AFAIK, it should spit out a loud WARNING.

Patch against 2.6.22-rc3-mm1.

Current mm tree does not build with sn2_defconfig. Build results in error:

.exit.text' referenced in section .init.text' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o
make: *** [.tmp_vmlinux1] Error 1

__exit loop_exit is now being called from __init loop_init which causes this error.

drivers/block/loop.c renamed from drivers/block/loop.c.orig +1 -1
@@ -1456,7 +1456,7 @@ static struct kobject *loop_probe(dev_t 
 	return kobj;
 }
 
-static void __exit loop_exit(void)
+static void loop_exit(void)
 {
 	unsigned long range;
 	struct loop_device *lo, *next;