Skip to contentSkip to conversation

console: console handover to preferred console

PATCH In review Yinghai Lu 2 participants 3 messages May 31, 2007 – Jun 1, 2007

lore
Share & tools
lore

Yinghai Lu

author
#0 lore raw

PATCH 2/5 console: console handover to preferred console

[PATCH 2/5] console: console handover to preferred console

kernel/printk.c +4 -1
index 0bbdeac..7b96cae 100644
@@ -985,12 +1007,15 @@ void register_console(struct console *console)
 	if (!(console->flags & CON_ENABLED))
 		return;
 
-	if (bootconsole) {
+	if (bootconsole && (console->flags & CON_CONSDEV)) {
 		printk(KERN_INFO "console handover: boot [%s%d] -> real [%s%d]\n",
 		       bootconsole->name, bootconsole->index,
 		       console->name, console->index);
 		unregister_console(bootconsole);
 		console->flags &= ~CON_PRINTBUFFER;
+	} else {
+		printk(KERN_INFO "console [%s%d] enabled\n",
+		       console->name, console->index);
 	}
 
 	/*
#1 lore raw
Quoted 15 lines · On Thu, 31 May 2007 13:58:26 -0700 Yinghai Lu <[email protected]> wrote:

[PATCH 2/5] console: console handover to preferred console

kernel/printk.c +1 -1
index 0bbdeac..7b96cae 100644
@@ -985,12 +1007,15 @@ void register_console(struct console *console)
 	if (!(console->flags & CON_ENABLED))
 		return;
 
-	if (bootconsole) {
+	if (bootconsole && (console->flags & CON_CONSDEV)) {
 		printk(KERN_INFO "console handover: boot [%s%d] -> real [%s%d]\n",

kernel/printk.c void register_console(struct console *console) · line 1021

Quoted 10 lines
kernel/printk.c +3 -0
 		       bootconsole->name, bootconsole->index,
 		       console->name, console->index);
 		unregister_console(bootconsole);
 		console->flags &= ~CON_PRINTBUFFER;
+	} else {
+		printk(KERN_INFO "console [%s%d] enabled\n",
+		       console->name, console->index);
 	}
 
 	/*

What does this change do, and what is the reason for it??

author
#2 lore raw
Quoted 27 lines · Andrew Morton
Quoted 24 lines · On Thu, 31 May 2007 13:58:26 -0700 Yinghai Lu <[email protected]> wrote:

[PATCH 2/5] console: console handover to preferred console

kernel/printk.c +4 -1
index 0bbdeac..7b96cae 100644
@@ -985,12 +1007,15 @@ void register_console(struct console *console)
 	if (!(console->flags & CON_ENABLED))
 		return;
 
-	if (bootconsole) {
+	if (bootconsole && (console->flags & CON_CONSDEV)) {
 		printk(KERN_INFO "console handover: boot [%s%d] -> real [%s%d]\n",
 		       bootconsole->name, bootconsole->index,
 		       console->name, console->index);
 		unregister_console(bootconsole);
 		console->flags &= ~CON_PRINTBUFFER;
+	} else {
+		printk(KERN_INFO "console [%s%d] enabled\n",
+		       console->name, console->index);
 	}
 
Quoted 3 lines

kernel/printk.c void register_console(struct console *console) · line 1021

Quoted 1 line
kernel/printk.c +0 -0
 	/*

What does this change do, and what is the reason for it??

for earlyprintk=ttyS0,9600 console=tty0 console=ttyS0,9600n8

the handover will happen from earlyser0 to tty0. but what we want is to ttyS0.

later with patch4,
console=tty0 console=uart8250,io,0x3f8,9600n8
will handover to ttyS0 instead of tty0.

Maybe can put above lines into commit log.

YH