Skip to contentSkip to conversation

slab: Fix slab debug for non alien caches.

PATCH New Paul Mundt 1 participant 1 message Jun 1, 2007 Memory management

lore
Share & tools
lore

Paul Mundt

author
#0 lore raw

PATCH 1/1 slab: Fix slab debug for non alien caches.

Currently when slab debugging is enabled, the WARN_ON() nodeid checks trigger if we boot with 'noaliencache'. In the noaliencache case the WARN_ON()'s seem to be superfluous, so only bother doing the nodeid comparison if use_alien_caches is set.

--

 mm/slab.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/slab.c +2 -2
index 2e71a32..88db26b 100644
@@ -2663,7 +2663,7 @@ static void *slab_get_obj(struct kmem_cache *cachep, struct slab *slabp,
 	next = slab_bufctl(slabp)[slabp->free];
 #if DEBUG
 	slab_bufctl(slabp)[slabp->free] = BUFCTL_FREE;
-	WARN_ON(slabp->nodeid != nodeid);
+	WARN_ON(use_alien_caches && slabp->nodeid != nodeid);
 #endif
 	slabp->free = next;
 
@@ -2677,7 +2677,7 @@ static void slab_put_obj(struct kmem_cache *cachep, struct slab *slabp,
 
 #if DEBUG
 	/* Verify that the slab belongs to the intended node */
-	WARN_ON(slabp->nodeid != nodeid);
+	WARN_ON(use_alien_caches && slabp->nodeid != nodeid);
 
 	if (slab_bufctl(slabp)[objnr] + 1 <= SLAB_LIMIT + 1) {
 		printk(KERN_ERR "slab: double free detected in cache "

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>