Skip to contentSkip to conversation

fix section mismatch warning in initel_cacheinfo

PATCH New Sam Ravnborg 1 participant 1 message Jun 2, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix section mismatch warning in initel_cacheinfo

Fix following warning:
WARNING: arch/i386/kernel/built-in.o(.init.text+0x3818): Section mismatch: reference to .exit.text:cache_remove_dev (between 'cacheinfo_cpu_callback' and 'cache_sysfs_init')

It points out that a function marked __cpuexit is calling a function marked __cpuinit => oops.
The call happens only in an error-condition which may explain why we have not seen it before.
The offending function was not used anywhere else - so marked it __cpuexit.

---

Note: This warning triggers only with a local copy of modpost
but that version will soon be pushed out.

Sam

arch/i386/kernel/cpu/intel_cacheinfo.c +1 -1
index e5be819..0617bb3 100644
@@ -710,7 +710,7 @@ static int __cpuinit cache_add_dev(struct sys_device * sys_dev)
 	return retval;
 }
 
-static void __cpuexit cache_remove_dev(struct sys_device * sys_dev)
+static void __cpuinit cache_remove_dev(struct sys_device * sys_dev)
 {
 	unsigned int cpu = sys_dev->id;
 	unsigned long i;