Skip to contentSkip to conversation

fix wrapping of index into hash table in nouveau_ht_object_insert()

PATCH New Maurice van der Pot 1 participant 1 message Jun 3, 2007

lore
Share & tools
lore

Maurice van der Pot

author
#0 lore raw

PATCH 1/1 fix wrapping of index into hash table in nouveau_ht_object_insert()

Hi guys,

Just something I noticed while reading the code.

I would be interested to know if you think the problem would occur in normal usage.

Regards,
Maurice.

Signature · 4 lines
Maurice van der Pot

Gentoo Linux Developer   [email protected]     http://www.gentoo.org
Creator of BiteMe!       griffon26-bCGDfOjggl9Wk0Htik3J/[email protected]   http://www.kfk4ever.com
shared-core/nouveau_object.c +1 -1
index ace7c2a..e36568c 100644
@@ -167,7 +167,7 @@ nouveau_ht_object_insert(drm_device_t* dev, int channel, uint32_t handle,
 
 	while (NV_READ(ht_base + ofs) || NV_READ(ht_base + ofs + 4)) {
 		ofs += 8;
-		if (ofs == ht_end) ofs = ht_base;
+		if (ofs == dev_priv->ramht_size) ofs = 0;
 		if (ofs == o_ofs) {
 			DRM_ERROR("no free hash table entries\n");
 			return 1;

_______________________________________________
Nouveau mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/nouveau