Performance Stats: Kernel patch
Subsystems (3)
PATCH 1/1 Performance Stats: Kernel patch
Removed syscall counters from patch.
Patch makes available to the user the following task and process performance statistics:
* Involuntary Context Switches (task_struct->nivcsw)
* Voluntary Context Switches (task_struct->nvcsw)
Statistics information is available from:
1. taskstats interface (Documentation/accounting/)
2. /proc/PID/status (task only).
This data is useful for detecting hyperactivity
patterns between processes.
---
Documentation/accounting/getdelays.c | 19 +++++++++++++++++-- Documentation/accounting/taskstats-struct.txt | 6 ++++++ fs/proc/array.c | 8 ++++++++ include/linux/taskstats.h | 5 ++++- kernel/taskstats.c | 4 ++++ 5 files changed, 39 insertions(+), 3 deletions(-)
Documentation/accounting/getdelays.c +17 -2
@@ -49,6 +49,7 @@ char name[100];int dbg;int print_delays;int print_io_accounting; +int print_task_stats;__u64 stime, utime; #define PRINTF(fmt, arg...) { \
@@ -187,7 +188,7 @@ void print_delayacct(struct taskstats *t)"IO %15s%15s\n" " %15llu%15llu\n" "MEM %15s%15s\n" -" %15llu%15llu\n\n" , +" %15llu%15llu\n" "count" ,"real total" ,"virtual total" ,"delay total" , t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total, t->cpu_delay_total,
@@ -196,6 +197,14 @@ void print_delayacct(struct taskstats *t) "count", "delay total", t->swapin_count, t->swapin_delay_total); } +void print_taskstats (struct taskstats *t) +{ +printf ("\n\nTask %15s%15s\n" +" %15lu%15lu\n" , +"voluntary" ,"nonvoluntary" , + t->nvcsw, t->nivcsw); +} +void print_ioacct (struct taskstats *t) { printf("%s: read=%llu, write=%llu, cancelled_write=%llu\n",
@@ -227,7 +236,7 @@ int main(int argc, char *argv[])struct msgtemplate msg;while (1 ) { - c =getopt (argc, argv,"diw:r:m:t:p:v:l" ); + c =getopt (argc, argv,"qdiw:r:m:t:p:v:l" );if (c <0 )break ;
@@ -240,6 +249,10 @@ int main(int argc, char *argv[])printf ("printing IO accounting\n" ); print_io_accounting =1 ;break ; +case 'q' : +printf ("printing task/process stasistics:\n" ); + print_task_stats =1 ; +break ;case 'w' :strncpy (logfile, optarg,MAX_FILENAME );printf ("write to file %s\n" , logfile);
@@ -381,6 +394,8 @@ int main(int argc, char *argv[])print_delayacct ((struct taskstats *)NLA_DATA (na));if (print_io_accounting)print_ioacct ((struct taskstats *)NLA_DATA (na)); +if (print_task_stats) +print_taskstats ((struct taskstats *)NLA_DATA (na));if (fd) {if (write (fd,NLA_DATA (na), na->nla_len) <0 ) {err (1 ,"write error\n" );
Documentation/accounting/taskstats-struct.txt +6 -0
@@ -22,6 +22,8 @@ There are three different groups of fields in the struct taskstats: /* Extended accounting fields end */ Their values are collected if CONFIG_TASK_XACCT is set. +4) Per-task and per-thread statistics + Future extension should add fields to the end of the taskstats struct, and should not change the relative position of each field within the struct.
@@ -158,4 +160,8 @@ struct taskstats { /* Extended accounting fields end */ +4) Per-task and per-thread statistics + __u64 nvcsw; /* Context voluntary switch counter */ + __u64 nivcsw; /* Context involuntary switch counter */ + }
fs/proc/array.c +8 -0
@@ -290,6 +290,13 @@ static inline char *task_cap(struct task_struct *p, char *buffer)cap_t (p->cap_permitted), cap_t(p->cap_effective)); } +static inline char *task_perf (struct task_struct *p,char *buffer) +{ +return buffer +sprintf (buffer,"voluntary_ctxt_switches:\t%lu\n" +"nonvoluntary_ctxt_switches:\t%lu\n" , + p->nvcsw, + p->nivcsw); +}int proc_pid_status (struct task_struct *task,char * buffer) {
@@ -309,6 +316,7 @@ int proc_pid_status(struct task_struct *task, char * buffer)#if defined(CONFIG_S390 ) buffer =task_show_regs (task, buffer);#endif + buffer =task_perf (task, buffer);return buffer - orig; }
include/linux/taskstats.h +4 -1
@@ -31,7 +31,7 @@*/ -#define TASKSTATS_VERSION 3 +#define TASKSTATS_VERSION 4#define TS_COMM_LEN 32/* should be >= TASK_COMM_LEN * in linux/sched.h */
@@ -146,6 +146,9 @@ struct taskstats {__u64 read_bytes;/* bytes of read I/O */ __u64 write_bytes;/* bytes of write I/O */ __u64 cancelled_write_bytes;/* bytes of cancelled write I/O */ + +__u64 nvcsw;/* voluntary_ctxt_switches */ +__u64 nivcsw;/* nonvoluntary_ctxt_switches */ };
kernel/taskstats.c +4 -0
@@ -196,6 +196,8 @@ static int fill_pid(pid_t pid, struct task_struct *tsk,/* fill in basic acct fields */ stats->version =TASKSTATS_VERSION ; + stats->nvcsw = tsk->nvcsw; + stats->nivcsw = tsk->nivcsw;bacct_add_tsk (stats, tsk);/* fill in extended acct fields */
@@ -242,6 +244,8 @@ static int fill_tgid(pid_t tgid, struct task_struct *first,*/ delayacct_add_tsk (stats, tsk); + stats->nvcsw += tsk->nvcsw; + stats->nivcsw += tsk->nivcsw; }while_each_thread (first, tsk);unlock_task_sighand (first, &flags);
Quoted 11 lines · On Wed, 30 May 2007 18:49:46 +0000 Maxim Uvarov <[email protected]> wrote:
Removed syscall counters from patch.
Patch makes available to the user the following task and process performance statistics:
* Involuntary Context Switches (task_struct->nivcsw)
* Voluntary Context Switches (task_struct->nvcsw)
Quoted 8 lines
Statistics information is available from:
1. taskstats interface (Documentation/accounting/)
2./proc/PID/status(task only).This data is useful for detecting hyperactivity
patterns between processes.Signed-off-by Maxim Uvarov <[email protected]>
A few little things:
Quoted 23 lines
Documentation/accounting/getdelays.c +2
-1@@ -49,6 +49,7 @@ char name[100];int dbg;int print_delays;int print_io_accounting; +int print_task_stats;__u64 stime, utime; #define PRINTF(fmt, arg...) { \@@ -187,7 +188,7 @@ void print_delayacct(struct taskstats *t)"IO %15s%15s\n" " %15llu%15llu\n" "MEM %15s%15s\n" -" %15llu%15llu\n\n" , +" %15llu%15llu\n" "count" ,"real total" ,"virtual total" ,"delay total" , t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total, t->cpu_delay_total,
Documentation/accounting/getdelays.c void print_delayacct(struct taskstats *t) · line 206
Quoted 10 lines
Documentation/accounting/getdelays.c +7
-0@@ -196,6 +197,14 @@ void print_delayacct(struct taskstats *t) "count", "delay total", t->swapin_count, t->swapin_delay_total); } +void print_taskstats (struct taskstats *t) +{ +printf ("\n\nTask %15s%15s\n" +" %15lu%15lu\n" , +"voluntary" ,"nonvoluntary" , + t->nvcsw, t->nivcsw); +}
print_task_stats versus print_taskstats is a bit confusing, but I guess it doesn't matter.
More significantly, the whole idea of calling it "task stats" isn't a good
one: it's far too general. The whole kernel interface is called taskstats, but the additions here are a tiny part of that.
Perhaps task_context_switch_rates would be more appropriate, although rather a lot to type.
Quoted 59 lines
Documentation/accounting/getdelays.c +7
-1void print_ioacct (struct taskstats *t) { printf("%s: read=%llu, write=%llu, cancelled_write=%llu\n",@@ -227,7 +236,7 @@ int main(int argc, char *argv[])struct msgtemplate msg;while (1 ) { - c =getopt (argc, argv,"diw:r:m:t:p:v:l" ); + c =getopt (argc, argv,"qdiw:r:m:t:p:v:l" );if (c <0 )break ;@@ -240,6 +249,10 @@ int main(int argc, char *argv[])printf ("printing IO accounting\n" ); print_io_accounting =1 ;break ; +case 'q' : +printf ("printing task/process stasistics:\n" ); + print_task_stats =1 ; +break ;case 'w' :strncpy (logfile, optarg,MAX_FILENAME );printf ("write to file %s\n" , logfile);@@ -381,6 +394,8 @@ int main(int argc, char *argv[])print_delayacct ((struct taskstats *)NLA_DATA (na));if (print_io_accounting)print_ioacct ((struct taskstats *)NLA_DATA (na)); +if (print_task_stats) +print_taskstats ((struct taskstats *)NLA_DATA (na));if (fd) {if (write (fd,NLA_DATA (na), na->nla_len) <0 ) {err (1 ,"write error\n" );Documentation/accounting/taskstats-struct.txt +6
-0@@ -22,6 +22,8 @@ There are three different groups of fields in the struct taskstats: /* Extended accounting fields end */ Their values are collected if CONFIG_TASK_XACCT is set. +4) Per-task and per-thread statistics + Future extension should add fields to the end of the taskstats struct, and should not change the relative position of each field within the struct.@@ -158,4 +160,8 @@ struct taskstats { /* Extended accounting fields end */ +4) Per-task and per-thread statistics + __u64 nvcsw; /* Context voluntary switch counter */ + __u64 nivcsw; /* Context involuntary switch counter */ + }fs/proc/array.c +0
-0
fs/proc/array.c static inline char *task_cap(struct task_struct *p, char *buffer) · line 299
Quoted 10 lines
fs/proc/array.c +7
-0@@ -290,6 +290,13 @@ static inline char *task_cap(struct task_struct *p, char *buffer)cap_t (p->cap_permitted), cap_t(p->cap_effective)); } +static inline char *task_perf (struct task_struct *p,char *buffer) +{ +return buffer +sprintf (buffer,"voluntary_ctxt_switches:\t%lu\n" +"nonvoluntary_ctxt_switches:\t%lu\n" , + p->nvcsw, + p->nivcsw); +}
And here we call it task_perf, which is inconsistent, and also not very descriptive. Again, task_context_switch_rates would better.
err, except it's not a "rate". How about task_context_switches?
Quoted 48 lines
fs/proc/array.c +1
-0int proc_pid_status (struct task_struct *task,char * buffer) {@@ -309,6 +316,7 @@ int proc_pid_status(struct task_struct *task, char * buffer)#if defined(CONFIG_S390 ) buffer =task_show_regs (task, buffer);#endif + buffer =task_perf (task, buffer);return buffer - orig; }include/linux/taskstats.h +4
-1@@ -31,7 +31,7 @@*/ -#define TASKSTATS_VERSION 3 +#define TASKSTATS_VERSION 4#define TS_COMM_LEN 32/* should be >= TASK_COMM_LEN * in linux/sched.h */ @@ -146,6 +146,9 @@ struct taskstats {__u64 read_bytes;/* bytes of read I/O */ __u64 write_bytes;/* bytes of write I/O */ __u64 cancelled_write_bytes;/* bytes of cancelled write I/O */ + +__u64 nvcsw;/* voluntary_ctxt_switches */ +__u64 nivcsw;/* nonvoluntary_ctxt_switches */ };kernel/taskstats.c +2
-0@@ -196,6 +196,8 @@ static int fill_pid(pid_t pid, struct task_struct *tsk,/* fill in basic acct fields */ stats->version =TASKSTATS_VERSION ; + stats->nvcsw = tsk->nvcsw; + stats->nivcsw = tsk->nivcsw;bacct_add_tsk (stats, tsk);/* fill in extended acct fields */
kernel/taskstats.c static int fill_tgid(pid_t tgid, struct task_struct *first, · line 251
Quoted 8 lines
kernel/taskstats.c +2
-0@@ -242,6 +244,8 @@ static int fill_tgid(pid_t tgid, struct task_struct *first,*/ delayacct_add_tsk (stats, tsk); + stats->nvcsw += tsk->nvcsw; + stats->nivcsw += tsk->nivcsw; }while_each_thread (first, tsk);unlock_task_sighand (first, &flags);
The patch otherwise seems OK. Thoughts:
- Do we need to increment TASKSTATS_VERSION for this? I forget the rules there.
- The lack of context-switch accounting in taskstats is, I think, a simple oversight. It should have been included on day one.
There are perhaps other things which _should_ be in taskstats, but we forgot to add them. Can we think of any such things?
We shouldn't just toss any old random stuff in there: it should be things which make sense, and which Unix or Linux accounting traditionally provides, and it should be something which we expect won't suddenly become unsupportable if people make internal kernel changes.
Add Jonathan Lim to cc, who is working on CSA userland implementation to use the taskstats data that this patch is going to remove.
Thanks,
- jay
Quoted 216 lines · Andrew Morton
Quoted 10 lines · On Wed, 30 May 2007 18:49:46 +0000 Maxim Uvarov <[email protected]> wrote:
Removed syscall counters from patch.
Patch makes available to the user the following task and process performance statistics:
* Involuntary Context Switches (task_struct->nivcsw)
* Voluntary Context Switches (task_struct->nvcsw)Quoted 8 lines
Statistics information is available from:
1. taskstats interface (Documentation/accounting/)
2./proc/PID/status(task only).This data is useful for detecting hyperactivity
patterns between processes.Signed-off-by Maxim Uvarov <[email protected]>A few little things:
Quoted 22 lines
Documentation/accounting/getdelays.c +2
-1@@ -49,6 +49,7 @@ char name[100];int dbg;int print_delays;int print_io_accounting; +int print_task_stats;__u64 stime, utime; #define PRINTF(fmt, arg...) { \@@ -187,7 +188,7 @@ void print_delayacct(struct taskstats *t)"IO %15s%15s\n" " %15llu%15llu\n" "MEM %15s%15s\n" -" %15llu%15llu\n\n" , +" %15llu%15llu\n" "count" ,"real total" ,"virtual total" ,"delay total" , t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total, t->cpu_delay_total,Documentation/accounting/getdelays.c void print_delayacct(struct taskstats *t) · line 206
Quoted 10 lines
Documentation/accounting/getdelays.c +7
-0@@ -196,6 +197,14 @@ void print_delayacct(struct taskstats *t) "count", "delay total", t->swapin_count, t->swapin_delay_total); } +void print_taskstats (struct taskstats *t) +{ +printf ("\n\nTask %15s%15s\n" +" %15lu%15lu\n" , +"voluntary" ,"nonvoluntary" , + t->nvcsw, t->nivcsw); +}
print_task_statsversusprint_taskstatsis a bit confusing, but I guess it doesn't matter.More significantly, the whole idea of calling it "task stats" isn't a good
one: it's far too general. The whole kernel interface is called taskstats, but the additions here are a tiny part of that.Perhaps
task_context_switch_rateswould be more appropriate, although rather a lot to type.Quoted 59 lines
Documentation/accounting/getdelays.c +7
-1void print_ioacct (struct taskstats *t) { printf("%s: read=%llu, write=%llu, cancelled_write=%llu\n",@@ -227,7 +236,7 @@ int main(int argc, char *argv[])struct msgtemplate msg;while (1 ) { - c =getopt (argc, argv,"diw:r:m:t:p:v:l" ); + c =getopt (argc, argv,"qdiw:r:m:t:p:v:l" );if (c <0 )break ;@@ -240,6 +249,10 @@ int main(int argc, char *argv[])printf ("printing IO accounting\n" ); print_io_accounting =1 ;break ; +case 'q' : +printf ("printing task/process stasistics:\n" ); + print_task_stats =1 ; +break ;case 'w' :strncpy (logfile, optarg,MAX_FILENAME );printf ("write to file %s\n" , logfile);@@ -381,6 +394,8 @@ int main(int argc, char *argv[])print_delayacct ((struct taskstats *)NLA_DATA (na));if (print_io_accounting)print_ioacct ((struct taskstats *)NLA_DATA (na)); +if (print_task_stats) +print_taskstats ((struct taskstats *)NLA_DATA (na));if (fd) {if (write (fd,NLA_DATA (na), na->nla_len) <0 ) {err (1 ,"write error\n" );Documentation/accounting/taskstats-struct.txt +6
-0@@ -22,6 +22,8 @@ There are three different groups of fields in the struct taskstats: /* Extended accounting fields end */ Their values are collected if CONFIG_TASK_XACCT is set. +4) Per-task and per-thread statistics + Future extension should add fields to the end of the taskstats struct, and should not change the relative position of each field within the struct.@@ -158,4 +160,8 @@ struct taskstats { /* Extended accounting fields end */ +4) Per-task and per-thread statistics + __u64 nvcsw; /* Context voluntary switch counter */ + __u64 nivcsw; /* Context involuntary switch counter */ + }fs/proc/array.c +0
-0fs/proc/array.c static inline char *task_cap(struct task_struct *p, char *buffer) · line 299
Quoted 10 lines
fs/proc/array.c +7
-0@@ -290,6 +290,13 @@ static inline char *task_cap(struct task_struct *p, char *buffer)cap_t (p->cap_permitted), cap_t(p->cap_effective)); } +static inline char *task_perf (struct task_struct *p,char *buffer) +{ +return buffer +sprintf (buffer,"voluntary_ctxt_switches:\t%lu\n" +"nonvoluntary_ctxt_switches:\t%lu\n" , + p->nvcsw, + p->nivcsw); +}And here we call it
task_perf, which is inconsistent, and also not very descriptive. Again,task_context_switch_rateswould better.err, except it's not a "rate". How about
task_context_switches?Quoted 48 lines
fs/proc/array.c +1
-0int proc_pid_status (struct task_struct *task,char * buffer) {@@ -309,6 +316,7 @@ int proc_pid_status(struct task_struct *task, char * buffer)#if defined(CONFIG_S390 ) buffer =task_show_regs (task, buffer);#endif + buffer =task_perf (task, buffer);return buffer - orig; }include/linux/taskstats.h +4
-1@@ -31,7 +31,7 @@*/ -#define TASKSTATS_VERSION 3 +#define TASKSTATS_VERSION 4#define TS_COMM_LEN 32/* should be >= TASK_COMM_LEN * in linux/sched.h */ @@ -146,6 +146,9 @@ struct taskstats {__u64 read_bytes;/* bytes of read I/O */ __u64 write_bytes;/* bytes of write I/O */ __u64 cancelled_write_bytes;/* bytes of cancelled write I/O */ + +__u64 nvcsw;/* voluntary_ctxt_switches */ +__u64 nivcsw;/* nonvoluntary_ctxt_switches */ };kernel/taskstats.c +2
-0@@ -196,6 +196,8 @@ static int fill_pid(pid_t pid, struct task_struct *tsk,/* fill in basic acct fields */ stats->version =TASKSTATS_VERSION ; + stats->nvcsw = tsk->nvcsw; + stats->nivcsw = tsk->nivcsw;bacct_add_tsk (stats, tsk);/* fill in extended acct fields */ kernel/taskstats.c static int fill_tgid(pid_t tgid, struct task_struct *first, · line 251
Quoted 8 lines
kernel/taskstats.c +2
-0@@ -242,6 +244,8 @@ static int fill_tgid(pid_t tgid, struct task_struct *first,*/ delayacct_add_tsk (stats, tsk); + stats->nvcsw += tsk->nvcsw; + stats->nivcsw += tsk->nivcsw; }while_each_thread (first, tsk);unlock_task_sighand (first, &flags);The patch otherwise seems OK. Thoughts:
- Do we need to increment
TASKSTATS_VERSIONfor this? I forget the rules there.- The lack of context-switch accounting in taskstats is, I think, a simple oversight. It should have been included on day one.
There are perhaps other things which _should_ be in taskstats, but we forgot to add them. Can we think of any such things?
We shouldn't just toss any old random stuff in there: it should be things which make sense, and which Unix or Linux accounting traditionally provides, and it should be something which we expect won't suddenly become unsupportable if people make internal kernel changes.
Looking at the diffs below, I see context switch counters added. What is actually being removed?
Jonathan
Quoted 218 lines · On Mon Jun 4 12:33:15 2007, [email protected] wrote:
Add Jonathan Lim to cc, who is working on CSA userland implementation to use the taskstats data that this patch is going to remove.
Thanks,
- jayQuoted 210 lines · Andrew Morton
Quoted 7 lines · On Wed, 30 May 2007 18:49:46 +0000 Maxim Uvarov <[email protected]> wrote:
Removed syscall counters from patch.
Patch makes available to the user the following task and process performance statistics:
* Involuntary Context Switches (task_struct->nivcsw)
* Voluntary Context Switches (task_struct->nvcsw)Quoted 7 lines
Statistics information is available from:
1. taskstats interface (Documentation/accounting/)
2./proc/PID/status(task only).This data is useful for detecting hyperactivity
patterns between processes.Signed-off-by Maxim Uvarov <[email protected]>A few little things:
Quoted 22 lines
Documentation/accounting/getdelays.c +2
-1@@ -49,6 +49,7 @@ char name[100];int dbg;int print_delays;int print_io_accounting; +int print_task_stats;__u64 stime, utime; #define PRINTF(fmt, arg...) { \@@ -187,7 +188,7 @@ void print_delayacct(struct taskstats *t)"IO %15s%15s\n" " %15llu%15llu\n" "MEM %15s%15s\n" -" %15llu%15llu\n\n" , +" %15llu%15llu\n" "count" ,"real total" ,"virtual total" ,"delay total" , t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total, t->cpu_delay_total,Documentation/accounting/getdelays.c void print_delayacct(struct taskstats *t) · line 206
Quoted 10 lines
Documentation/accounting/getdelays.c +7
-0@@ -196,6 +197,14 @@ void print_delayacct(struct taskstats *t) "count", "delay total", t->swapin_count, t->swapin_delay_total); } +void print_taskstats (struct taskstats *t) +{ +printf ("\n\nTask %15s%15s\n" +" %15lu%15lu\n" , +"voluntary" ,"nonvoluntary" , + t->nvcsw, t->nivcsw); +}
print_task_statsversusprint_taskstatsis a bit confusing, but I guess it doesn't matter.More significantly, the whole idea of calling it "task stats" isn't a good
one: it's far too general. The whole kernel interface is called taskstats, but the additions here are a tiny part of that.Perhaps
task_context_switch_rateswould be more appropriate, although rather a lot to type.Quoted 59 lines
Documentation/accounting/getdelays.c +7
-1void print_ioacct (struct taskstats *t) { printf("%s: read=%llu, write=%llu, cancelled_write=%llu\n",@@ -227,7 +236,7 @@ int main(int argc, char *argv[])struct msgtemplate msg;while (1 ) { - c =getopt (argc, argv,"diw:r:m:t:p:v:l" ); + c =getopt (argc, argv,"qdiw:r:m:t:p:v:l" );if (c <0 )break ;@@ -240,6 +249,10 @@ int main(int argc, char *argv[])printf ("printing IO accounting\n" ); print_io_accounting =1 ;break ; +case 'q' : +printf ("printing task/process stasistics:\n" ); + print_task_stats =1 ; +break ;case 'w' :strncpy (logfile, optarg,MAX_FILENAME );printf ("write to file %s\n" , logfile);@@ -381,6 +394,8 @@ int main(int argc, char *argv[])print_delayacct ((struct taskstats *)NLA_DATA (na));if (print_io_accounting)print_ioacct ((struct taskstats *)NLA_DATA (na)); +if (print_task_stats) +print_taskstats ((struct taskstats *)NLA_DATA (na));if (fd) {if (write (fd,NLA_DATA (na), na->nla_len) <0 ) {err (1 ,"write error\n" );Documentation/accounting/taskstats-struct.txt +6
-0@@ -22,6 +22,8 @@ There are three different groups of fields in the struct taskstats: /* Extended accounting fields end */ Their values are collected if CONFIG_TASK_XACCT is set. +4) Per-task and per-thread statistics + Future extension should add fields to the end of the taskstats struct, and should not change the relative position of each field within the struct.@@ -158,4 +160,8 @@ struct taskstats { /* Extended accounting fields end */ +4) Per-task and per-thread statistics + __u64 nvcsw; /* Context voluntary switch counter */ + __u64 nivcsw; /* Context involuntary switch counter */ + }fs/proc/array.c +0
-0fs/proc/array.c static inline char *task_cap(struct task_struct *p, char *buffer) · line 299
Quoted 10 lines
fs/proc/array.c +7
-0@@ -290,6 +290,13 @@ static inline char *task_cap(struct task_struct *p, char *buffer)cap_t (p->cap_permitted), cap_t(p->cap_effective)); } +static inline char *task_perf (struct task_struct *p,char *buffer) +{ +return buffer +sprintf (buffer,"voluntary_ctxt_switches:\t%lu\n" +"nonvoluntary_ctxt_switches:\t%lu\n" , + p->nvcsw, + p->nivcsw); +}And here we call it
task_perf, which is inconsistent, and also not very descriptive. Again,task_context_switch_rateswould better.err, except it's not a "rate". How about
task_context_switches?Quoted 48 lines
fs/proc/array.c +1
-0int proc_pid_status (struct task_struct *task,char * buffer) {@@ -309,6 +316,7 @@ int proc_pid_status(struct task_struct *task, char * buffer)#if defined(CONFIG_S390 ) buffer =task_show_regs (task, buffer);#endif + buffer =task_perf (task, buffer);return buffer - orig; }include/linux/taskstats.h +4
-1@@ -31,7 +31,7 @@*/ -#define TASKSTATS_VERSION 3 +#define TASKSTATS_VERSION 4#define TS_COMM_LEN 32/* should be >= TASK_COMM_LEN * in linux/sched.h */ @@ -146,6 +146,9 @@ struct taskstats {__u64 read_bytes;/* bytes of read I/O */ __u64 write_bytes;/* bytes of write I/O */ __u64 cancelled_write_bytes;/* bytes of cancelled write I/O */ + +__u64 nvcsw;/* voluntary_ctxt_switches */ +__u64 nivcsw;/* nonvoluntary_ctxt_switches */ };kernel/taskstats.c +2
-0@@ -196,6 +196,8 @@ static int fill_pid(pid_t pid, struct task_struct *tsk,/* fill in basic acct fields */ stats->version =TASKSTATS_VERSION ; + stats->nvcsw = tsk->nvcsw; + stats->nivcsw = tsk->nivcsw;bacct_add_tsk (stats, tsk);/* fill in extended acct fields */ kernel/taskstats.c static int fill_tgid(pid_t tgid, struct task_struct *first, · line 251
Quoted 8 lines
kernel/taskstats.c +2
-0@@ -242,6 +244,8 @@ static int fill_tgid(pid_t tgid, struct task_struct *first,*/ delayacct_add_tsk (stats, tsk); + stats->nvcsw += tsk->nvcsw; + stats->nivcsw += tsk->nivcsw; }while_each_thread (first, tsk);unlock_task_sighand (first, &flags);The patch otherwise seems OK. Thoughts:
- Do we need to increment
TASKSTATS_VERSIONfor this? I forget the rules there.- The lack of context-switch accounting in taskstats is, I think, a simple oversight. It should have been included on day one.
There are perhaps other things which _should_ be in taskstats, but we forgot to add them. Can we think of any such things?
We shouldn't just toss any old random stuff in there: it should be things which make sense, and which Unix or Linux accounting traditionally provides, and it should be something which we expect won't suddenly become unsupportable if people make internal kernel changes.
Quoted 196 lines · Andrew Morton
Quoted 10 lines · On Wed, 30 May 2007 18:49:46 +0000 Maxim Uvarov <[email protected]> wrote:
Removed syscall counters from patch.
Patch makes available to the user the following task and process performance statistics:
* Involuntary Context Switches (task_struct->nivcsw)
* Voluntary Context Switches (task_struct->nvcsw)Quoted 8 lines
Statistics information is available from:
1. taskstats interface (Documentation/accounting/)
2./proc/PID/status(task only).This data is useful for detecting hyperactivity
patterns between processes.Signed-off-by Maxim Uvarov <[email protected]>A few little things:
Quoted 22 lines
Documentation/accounting/getdelays.c +2
-1@@ -49,6 +49,7 @@ char name[100];int dbg;int print_delays;int print_io_accounting; +int print_task_stats;__u64 stime, utime; #define PRINTF(fmt, arg...) { \@@ -187,7 +188,7 @@ void print_delayacct(struct taskstats *t)"IO %15s%15s\n" " %15llu%15llu\n" "MEM %15s%15s\n" -" %15llu%15llu\n\n" , +" %15llu%15llu\n" "count" ,"real total" ,"virtual total" ,"delay total" , t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total, t->cpu_delay_total,Documentation/accounting/getdelays.c void print_delayacct(struct taskstats *t) · line 206
Quoted 10 lines
Documentation/accounting/getdelays.c +7
-0@@ -196,6 +197,14 @@ void print_delayacct(struct taskstats *t) "count", "delay total", t->swapin_count, t->swapin_delay_total); } +void print_taskstats (struct taskstats *t) +{ +printf ("\n\nTask %15s%15s\n" +" %15lu%15lu\n" , +"voluntary" ,"nonvoluntary" , + t->nvcsw, t->nivcsw); +}
print_task_statsversusprint_taskstatsis a bit confusing, but I guess it doesn't matter.More significantly, the whole idea of calling it "task stats" isn't a good
one: it's far too general. The whole kernel interface is called taskstats, but the additions here are a tiny part of that.Perhaps
task_context_switch_rateswould be more appropriate, although rather a lot to type.Quoted 59 lines
Documentation/accounting/getdelays.c +7
-1void print_ioacct (struct taskstats *t) { printf("%s: read=%llu, write=%llu, cancelled_write=%llu\n",@@ -227,7 +236,7 @@ int main(int argc, char *argv[])struct msgtemplate msg;while (1 ) { - c =getopt (argc, argv,"diw:r:m:t:p:v:l" ); + c =getopt (argc, argv,"qdiw:r:m:t:p:v:l" );if (c <0 )break ;@@ -240,6 +249,10 @@ int main(int argc, char *argv[])printf ("printing IO accounting\n" ); print_io_accounting =1 ;break ; +case 'q' : +printf ("printing task/process stasistics:\n" ); + print_task_stats =1 ; +break ;case 'w' :strncpy (logfile, optarg,MAX_FILENAME );printf ("write to file %s\n" , logfile);@@ -381,6 +394,8 @@ int main(int argc, char *argv[])print_delayacct ((struct taskstats *)NLA_DATA (na));if (print_io_accounting)print_ioacct ((struct taskstats *)NLA_DATA (na)); +if (print_task_stats) +print_taskstats ((struct taskstats *)NLA_DATA (na));if (fd) {if (write (fd,NLA_DATA (na), na->nla_len) <0 ) {err (1 ,"write error\n" );Documentation/accounting/taskstats-struct.txt +6
-0@@ -22,6 +22,8 @@ There are three different groups of fields in the struct taskstats: /* Extended accounting fields end */ Their values are collected if CONFIG_TASK_XACCT is set. +4) Per-task and per-thread statistics + Future extension should add fields to the end of the taskstats struct, and should not change the relative position of each field within the struct.@@ -158,4 +160,8 @@ struct taskstats { /* Extended accounting fields end */ +4) Per-task and per-thread statistics + __u64 nvcsw; /* Context voluntary switch counter */ + __u64 nivcsw; /* Context involuntary switch counter */ + }fs/proc/array.c +0
-0fs/proc/array.c static inline char *task_cap(struct task_struct *p, char *buffer) · line 299
Quoted 10 lines
fs/proc/array.c +7
-0@@ -290,6 +290,13 @@ static inline char *task_cap(struct task_struct *p, char *buffer)cap_t (p->cap_permitted), cap_t(p->cap_effective)); } +static inline char *task_perf (struct task_struct *p,char *buffer) +{ +return buffer +sprintf (buffer,"voluntary_ctxt_switches:\t%lu\n" +"nonvoluntary_ctxt_switches:\t%lu\n" , + p->nvcsw, + p->nivcsw); +}And here we call it
task_perf, which is inconsistent, and also not very descriptive. Again,task_context_switch_rateswould better.err, except it's not a "rate". How about
task_context_switches?Quoted 54 lines
fs/proc/array.c +1
-0int proc_pid_status (struct task_struct *task,char * buffer) {@@ -309,6 +316,7 @@ int proc_pid_status(struct task_struct *task, char * buffer)#if defined(CONFIG_S390 ) buffer =task_show_regs (task, buffer);#endif + buffer =task_perf (task, buffer);return buffer - orig; }include/linux/taskstats.h +4
-1@@ -31,7 +31,7 @@*/ -#define TASKSTATS_VERSION 3 +#define TASKSTATS_VERSION 4#define TS_COMM_LEN 32/* should be >= TASK_COMM_LEN * in linux/sched.h */ @@ -146,6 +146,9 @@ struct taskstats {__u64 read_bytes;/* bytes of read I/O */ __u64 write_bytes;/* bytes of write I/O */ __u64 cancelled_write_bytes;/* bytes of cancelled write I/O */ + +__u64 nvcsw;/* voluntary_ctxt_switches */ +__u64 nivcsw;/* nonvoluntary_ctxt_switches */ };kernel/taskstats.c +4
-0@@ -196,6 +196,8 @@ static int fill_pid(pid_t pid, struct task_struct *tsk,/* fill in basic acct fields */ stats->version =TASKSTATS_VERSION ; + stats->nvcsw = tsk->nvcsw; + stats->nivcsw = tsk->nivcsw;bacct_add_tsk (stats, tsk);/* fill in extended acct fields */ @@ -242,6 +244,8 @@ static int fill_tgid(pid_t tgid, struct task_struct *first,*/ delayacct_add_tsk (stats, tsk); + stats->nvcsw += tsk->nvcsw; + stats->nivcsw += tsk->nivcsw; }while_each_thread (first, tsk);
Quoted 7 lines
kernel/taskstats.c static int fill_tgid(pid_t tgid, struct task_struct *first, · line 251
Quoted 2 lines
kernel/taskstats.c +0
-0unlock_task_sighand (first, &flags);The patch otherwise seems OK. Thoughts:
- Do we need to increment
TASKSTATS_VERSIONfor this? I forget the rules there.
As long as we change the size of taskstats struct or the relative position of existing fields, or the taskstats interface, we need to increment the TASKSTATS_VERSION. I guess if we make more than one changes within one 2.6.x release cycle, we can bundle them in one version change. Shailabh or Balbir?
Thanks,
- jay
Quoted 13 lines
- The lack of context-switch accounting in taskstats is, I think, a simple oversight. It should have been included on day one.
There are perhaps other things which _should_ be in taskstats, but we forgot to add them. Can we think of any such things?
We shouldn't just toss any old random stuff in there: it should be things which make sense, and which Unix or Linux accounting traditionally provides, and it should be something which we expect won't suddenly become unsupportable if people make internal kernel changes.
Quoted 14 lines · Andrew Morton
Documentation/accounting/getdelays.c void print_delayacct(struct taskstats *t) · line 206
Quoted 7 lines · On Wed, 30 May 2007 18:49:46 +0000 Maxim Uvarov <[email protected]> wrote:
Documentation/accounting/getdelays.c +7
-0+void print_taskstats (struct taskstats *t) +{ +printf ("\n\nTask %15s%15s\n" +" %15lu%15lu\n" , +"voluntary" ,"nonvoluntary" , + t->nvcsw, t->nivcsw); +}
print_task_statsversusprint_taskstatsis a bit confusing, but I guess it doesn't matter.
Quoted 7 lines
More significantly, the whole idea of calling it "task stats" isn't a good
one: it's far too general. The whole kernel interface is called taskstats, but the additions here are a tiny part of that.Perhaps
task_context_switch_rateswould be more appropriate, although rather a lot to type.
I agree, taskstats is the name given to the genetlink interface.
Quoted 4 lines
The patch otherwise seems OK. Thoughts:
- Do we need to increment
TASKSTATS_VERSIONfor this? I forget the rules there.
Any ABI change should result in a version bump. So the bump is ok
Quoted 4 lines
- The lack of context-switch accounting in taskstats is, I think, a simple oversight. It should have been included on day one.
Yes, it should have been included
Quoted 3 lines
There are perhaps other things which _should_ be in taskstats, but we forgot to add them. Can we think of any such things?
I think it's worth reviewing the data exported. I thought CSA filled out the gaps, but it's definitely worth revisiting.
Quoted 5 lines
We shouldn't just toss any old random stuff in there: it should be things which make sense, and which Unix or Linux accounting traditionally provides, and it should be something which we expect won't suddenly become unsupportable if people make internal kernel changes.
Yes, agreed. The interface must also be open for changes to accounting information that might be useful as a result of new features, like containers, etc.
Signature · 4 lines
Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL