Skip to contentSkip to conversation

intel_agp: Add support for G33, Q33 and Q35 chipsets

AGPGART Wang Zhenyu 1 participant 2 messages Jun 6, 2007 Agpgart driver

lore
Share & tools
lore
#0 lore raw

Dave,

This patch adds pci ids for G33, Q33 and Q35 chips, and update with new GTT size and stolen mem size detect method on these chips.

It bases on below intel-agp patches currently in -mm tree:
intel_agp-cleanup-intel-private-data.patch intel_agp-cleanup-intel-private-data-update.patch intel_agp-use-table-for-device-probe.patch intel_agp-use-table-for-device-probe-update.patch intel_agp-add-support-for-965gme-gle.patch intel_agp-add-support-for-945gme.patch

---
 drivers/char/agp/agp.h       |    6 +++-
 drivers/char/agp/intel-agp.c |   78 ++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 81 insertions(+), 3 deletions(-)
drivers/char/agp/agp.h +5 -1
index fdbca25..35ab1a9 100644
@@ -176,7 +176,7 @@ struct agp_bridge_data {
 #define I830_GMCH_MEM_MASK		0x1
 #define I830_GMCH_MEM_64M		0x1
 #define I830_GMCH_MEM_128M		0
-#define I830_GMCH_GMS_MASK		0x70
+#define I830_GMCH_GMS_MASK		0xF0
 #define I830_GMCH_GMS_DISABLED		0x00
 #define I830_GMCH_GMS_LOCAL		0x10
 #define I830_GMCH_GMS_STOLEN_512	0x20
@@ -231,6 +231,10 @@ struct agp_bridge_data {
 #define I965_PGETBL_SIZE_512KB	(0 << 1)
 #define I965_PGETBL_SIZE_256KB	(1 << 1)
 #define I965_PGETBL_SIZE_128KB	(2 << 1)
+#define G33_PGETBL_SIZE_MASK    (3 << 8)
+#define G33_PGETBL_SIZE_1M      (1 << 8)
+#define G33_PGETBL_SIZE_2M      (2 << 8)
+
 #define I810_DRAM_CTL		0x3000
 #define I810_DRAM_ROW_0		0x00000001
 #define I810_DRAM_ROW_0_SDRAM	0x00000001
drivers/char/agp/intel-agp.c +76 -2

135 lines not on this page · raw message

Signature · 1 line
1.4.4.4
#1 lore raw
Quoted 11 lines · Wang Zhenyu

This patch adds pci ids for G33, Q33 and Q35 chips

It bases on below intel-agp patches currently in -mm tree:
intel_agp-cleanup-intel-private-data.patch intel_agp-cleanup-intel-private-data-update.patch intel_agp-use-table-for-device-probe.patch intel_agp-use-table-for-device-probe-update.patch intel_agp-add-support-for-965gme-gle.patch intel_agp-add-support-for-945gme.patch

oops, found one break line was missed in detect GTT size switch. Here's the updated patch. Thanks Kent Liu for report.

[AGPGART] intel_agp: Add support for G33, Q33 and Q35 chipsets

This patch adds pci ids for G33, Q33 and Q35 chips, and update with new GTT size and stolen mem size detect method on these chips.

---
 drivers/char/agp/agp.h       |    6 +++-
 drivers/char/agp/intel-agp.c |   79 ++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 82 insertions(+), 3 deletions(-)
drivers/char/agp/agp.h +5 -1
index fdbca25..35ab1a9 100644
@@ -176,7 +176,7 @@ struct agp_bridge_data {
 #define I830_GMCH_MEM_MASK		0x1
 #define I830_GMCH_MEM_64M		0x1
 #define I830_GMCH_MEM_128M		0
-#define I830_GMCH_GMS_MASK		0x70
+#define I830_GMCH_GMS_MASK		0xF0
 #define I830_GMCH_GMS_DISABLED		0x00
 #define I830_GMCH_GMS_LOCAL		0x10
 #define I830_GMCH_GMS_STOLEN_512	0x20
@@ -231,6 +231,10 @@ struct agp_bridge_data {
 #define I965_PGETBL_SIZE_512KB	(0 << 1)
 #define I965_PGETBL_SIZE_256KB	(1 << 1)
 #define I965_PGETBL_SIZE_128KB	(2 << 1)
+#define G33_PGETBL_SIZE_MASK    (3 << 8)
+#define G33_PGETBL_SIZE_1M      (1 << 8)
+#define G33_PGETBL_SIZE_2M      (2 << 8)
+
 #define I810_DRAM_CTL		0x3000
 #define I810_DRAM_ROW_0		0x00000001
 #define I810_DRAM_ROW_0_SDRAM	0x00000001
drivers/char/agp/intel-agp.c +77 -2

136 lines not on this page · raw message

Signature · 1 line
1.4.4.4