Skip to contentSkip to conversation

drivers/input/joystick/grip_mp.c: ARRAY_SIZE

PATCH New Andi Drebes 1 participant 1 message Jun 6, 2007

Subsystems (3)
Kernel janitors HID Input drivers
lore
Share & tools
lore

Andi Drebes

author
#0 lore raw

PATCH 1/1 drivers/input/joystick/grip_mp.c: ARRAY_SIZE

This patch replaces an array size calculation in drivers/input/joystick/grip_mp.c that was done using sizeof with the ARRAY_SIZE macro. To be more specific, I replaced a variable called seq_len in the function dig_mode_start that stored the size of the array with ARRAY_SIZE. The variable was referenced only once, so I think removing it is ok.

Tested by compilation on an i386 box using "allyesconfig". Diffed against Linus' git-tree.

Signed-off-by Andi Drebes <[email protected]>

---

drivers/input/joystick/grip_mp.c +2 -2
index 555319e..4ed3a3e 100644
@@ -320,10 +320,10 @@ static int multiport_io(struct gameport* gameport, int sendflags, int sendcode,
 
 static int dig_mode_start(struct gameport *gameport, u32 *packet)
 {
-	int i, seq_len = sizeof(init_seq)/sizeof(int);
+	int i;
 	int flags, tries = 0, bads = 0;
 
-	for (i = 0; i < seq_len; i++) {     /* Send magic sequence */
+	for (i = 0; i < ARRAY_SIZE(init_seq); i++) {     /* Send magic sequence */
 		if (init_seq[i])
 			gameport_trigger(gameport);
 		udelay(GRIP_INIT_DELAY);

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors