divorce CONFIG_X86_PAE from CONFIG_HIGHMEM64G
PAE is useful for more than supporting more than 4GB RAM. It supports expanded swapspace and NX executable protections. Some users may want NX or expanded swapspace support without the overhead or instability of highmem. For these reasons, the following patch divorces CONFIG_X86_PAE from CONFIG_HIGHMEM64G.
vs. 2.6.22-rc4-mm2
arch/i386/Kconfig +11 -5
@@ -544,6 +544,7 @@ config HIGHMEM64G bool "64GB" depends on X86_CMPXCHG64 + select X86_PAE help Select this if you have a 32-bit processor and more than 4 gigabytes of physical RAM.
@@ -573,12 +574,12 @@ config VMSPLIT_3G bool "3G/1G user/kernel split" config VMSPLIT_3G_OPT - depends on !HIGHMEM + depends on !X86_PAE bool "3G/1G user/kernel split (for full 1G low memory)" config VMSPLIT_2G bool "2G/2G user/kernel split" config VMSPLIT_2G_OPT - depends on !HIGHMEM + depends on !X86_PAE bool "2G/2G user/kernel split (for full 2G low memory)" config VMSPLIT_1G bool "1G/3G user/kernel split"
@@ -598,10 +599,15 @@ default y config X86_PAE - bool - depends on HIGHMEM64G - default y + bool "PAE (Physical Address Extension) Support" + default n + depends on !HIGHMEM4G select RESOURCES_64BIT + help + PAE is required for NX support, and furthermore enables + larger swapspace support for non-overcommit purposes. It + has the cost of more pagetable lookup overhead, and also + consumes more pagetable space per process. # Common NUMA Features config NUMA
arch/i386/kernel/setup.c +4 -4
@@ -273,18 +273,18 @@printk (KERN_WARNING "Warning only %ldMB will be used.\n" ,MAXMEM >>20 );if (max_pfn >MAX_NONPAE_PFN ) -printk (KERN_WARNING "Use a PAE enabled kernel.\n" ); +printk (KERN_WARNING "Use a HIGHMEM64G enabled kernel.\n" );else printk (KERN_WARNING "Use a HIGHMEM enabled kernel.\n" ); max_pfn =MAXMEM_PFN ;#else /* !CONFIG_HIGHMEM */ -#ifndef CONFIG_X86_PAE +#ifndef CONFIG_HIGHMEM64G if (max_pfn >MAX_NONPAE_PFN ) { max_pfn =MAX_NONPAE_PFN ;printk (KERN_WARNING "Warning only 4GB will be used.\n" ); -printk (KERN_WARNING "Use a PAE enabled kernel.\n" ); +printk (KERN_WARNING "Use a HIGHMEM64G enabled kernel.\n" ); } -#endif /* !CONFIG_X86_PAE */ +#endif /* !CONFIG_HIGHMEM64G */ #endif /* !CONFIG_HIGHMEM */ }else {if (highmem_pages ==-1 )
Quoted 5 lines · On Thu, 7 Jun 2007 19:35:51 -0700 William Lee Irwin III <[email protected]>…
PAE is useful for more than supporting more than 4GB RAM. It supports expanded swapspace and NX executable protections. Some users may want NX or expanded swapspace support without the overhead or instability of highmem. For these reasons, the following patch divorces
CONFIG_X86_PAEfromCONFIG_HIGHMEM64G.
Do (CONFIG_X86_PAE && !CONFIG_HIGHMEM64G) and (!CONFIG_X86_PAE && CONFIG_HIGHMEM64G) kernels actually work? I wouldn't be surprised if there are places where we used the incorrect one.
Quoted 5 lines · On Thu, 7 Jun 2007 19:35:51 -0700 William Lee Irwin III <[email protected]>…
Quoted 5 lines
PAE is useful for more than supporting more than 4GB RAM. It supports expanded swapspace and NX executable protections. Some users may want NX or expanded swapspace support without the overhead or instability of highmem. For these reasons, the following patch divorces
CONFIG_X86_PAEfromCONFIG_HIGHMEM64G.
Quoted 3 lines · Andrew Morton
Do (
CONFIG_X86_PAE&& !CONFIG_HIGHMEM64G) and (!CONFIG_X86_PAE &&CONFIG_HIGHMEM64G) kernels actually work? I wouldn't be surprised if there are places where we used the incorrect one.
!CONFIG_X86_PAE && CONFIG_HIGHMEM64G doesn't make sense and is not allowed by this patch. CONFIG_X86_PAE && !CONFIG_HIGHMEM64G works here.
-- wli
Quoted 4 lines · William Lee Irwin III
!CONFIG_X86_PAE &&
CONFIG_HIGHMEM64Gdoesn't make sense and is not allowed by this patch.CONFIG_X86_PAE&& !CONFIG_HIGHMEM64G works here.
But what's the point?
If you're going to divorce these, at least do it in a way that makes sense, specifically the two independent variables are PAE and HIGHMEM. PAE and !HIGHMEM does make (some amount of) sense, due to no kmap overhead.
-hpa
Quoted 2 lines · William Lee Irwin III
Quoted 2 lines
!CONFIG_X86_PAE &&
CONFIG_HIGHMEM64Gdoesn't make sense and is not allowed by this patch.CONFIG_X86_PAE&& !CONFIG_HIGHMEM64G works here.
Quoted 4 lines · H. Peter Anvin
But what's the point?
If you're going to divorce these, at least do it in a way that makes sense, specifically the two independent variables are PAE and HIGHMEM. PAE and !HIGHMEM does make (some amount of) sense, due to no kmap overhead.
Beg your pardon? Are you reading the patch description correctly?
-- wli
Quoted 5 lines · William Lee Irwin III
Quoted 2 lines · William Lee Irwin III
Quoted 2 lines
!CONFIG_X86_PAE &&
CONFIG_HIGHMEM64Gdoesn't make sense and is not allowed by this patch.CONFIG_X86_PAE&& !CONFIG_HIGHMEM64G works here.
Quoted 8 lines
Quoted 4 lines · H. Peter Anvin
But what's the point?
If you're going to divorce these, at least do it in a way that makes sense, specifically the two independent variables are PAE and HIGHMEM. PAE and !HIGHMEM does make (some amount of) sense, due to no kmap overhead.Beg your pardon? Are you reading the patch description correctly?
I mean, with your patch CONFIG_HIGHMEM4G versus CONFIG_HIGHMEM64G really don't make sense as separate selections anymore.
-hpa
Quoted 1 line · William Lee Irwin III
Quoted 1 line
Beg your pardon? Are you reading the patch description correctly?
Quoted 2 lines · H. Peter Anvin
I mean, with your patch
CONFIG_HIGHMEM4GversusCONFIG_HIGHMEM64Greally don't make sense as separate selections anymore.
I thought about sweeping those up, but defaulted to minimal diffsize. I can sweep them up given more votes in favor of doing so.
-- wli
arch/i386/Kconfig line 610
Quoted 9 lines · William Lee Irwin III
...
configX86_PAE
...arch/i386/Kconfig +5
-0+ help + PAE is required for NX support, and furthermore enables + larger swapspace support for non-overcommit purposes. It + has the cost of more pagetable lookup overhead, and also + consumes more pagetable space per process.
It's not specific to this help text, but I start becoming a bit picky about this issues:
If you understand this help text after reading it, you don't need a help text for this option... ;-)
What is "NX support"?
What are "non-overcommit purposes"?
What is "pagetable lookup overhead"?
And if in doubt, should I say Y or N?
"System administrator who knows which hardware components he put into the computer and which filesystems his data is on" might be a good description for the average kconfig user, and these are the people who should understand this help text.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 4 lines · William Lee Irwin III
Quoted 4 lines
arch/i386/Kconfig +4
-0+ PAE is required for NX support, and furthermore enables + larger swapspace support for non-overcommit purposes. It + has the cost of more pagetable lookup overhead, and also + consumes more pagetable space per process.
Quoted 4 lines · Adrian Bunk
It's not specific to this help text, but I start becoming a bit picky about this issues:
If you understand this help text after reading it, you don't need a help text for this option... ;-)
Quoted 8 lines
What is "NX support"?
What are "non-overcommit purposes"?
What is "pagetable lookup overhead"?
And if in doubt, should I say Y or N?
"System administrator who knows which hardware components he put into the computer and which filesystems his data is on" might be a good description for the average kconfig user, and these are the people who should understand this help text.
I would like to have some place to explain issues such as those, but there are as of yet no designated places for tutorial-level information.
If such a place were provided, I would provide storybook commentary to explain all those. Similarly actually holds for kernel function docbook.
-- wli
Quoted 20 lines · William Lee Irwin III
Quoted 4 lines · William Lee Irwin III
Quoted 4 lines
arch/i386/Kconfig +4
-0+ PAE is required for NX support, and furthermore enables + larger swapspace support for non-overcommit purposes. It + has the cost of more pagetable lookup overhead, and also + consumes more pagetable space per process.Quoted 4 lines · Adrian Bunk
It's not specific to this help text, but I start becoming a bit picky about this issues:
If you understand this help text after reading it, you don't need a help text for this option... ;-)Quoted 8 lines
What is "NX support"?
What are "non-overcommit purposes"?
What is "pagetable lookup overhead"?
And if in doubt, should I say Y or N?
"System administrator who knows which hardware components he put into the computer and which filesystems his data is on" might be a good description for the average kconfig user, and these are the people who should understand this help text.
Quoted 5 lines
I would like to have some place to explain issues such as those, but there are as of yet no designated places for tutorial-level information.
If such a place were provided, I would provide storybook commentary to explain all those. Similarly actually holds for kernel function docbook.
There's no 4 line limit for Kconfig entries. If it takes a 10 line paragraph for a short explanation what the NX bit is and when enabling NX support makes sense (because it will be used) then that's completely appropriate here. The same goes for the other parts.
The kconfig help should give anyone running "make oldconfig" a rough understanding what this option is about and a clear understanding what to answer for this option ("If unsure, say Y/N." is a standard text we use for the latter).
Quoted 1 line
-- wli
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed