Skip to contentSkip to conversation

mac80211: Fix one more sparse error

PATCH In review Zhu Yi 2 participants 2 messages Jun 8, 2007 mac80211

lore
Share & tools
lore

Zhu Yi

author
#0 lore raw

PATCH 6/6 mac80211: Fix one more sparse error

Fix one more sparse error and comment variable for debugfs_rename TODO.

Signed-off-by Zhu Yi <[email protected]>
---
 net/mac80211/debugfs_netdev.c |    2 ++
 net/mac80211/debugfs_sta.c    |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)
net/mac80211/debugfs_netdev.c +2 -0
index 5e50817..52a32e4 100644
@@ -734,7 +734,9 @@ static int netdev_notify(struct notifier_block * nb,
 			 void *ndev)
 {
 	struct net_device *dev = ndev;
+	/* TODO
 	char buf[10+IFNAMSIZ];
+	*/
 
 	if (state != NETDEV_CHANGENAME)
 		return 0;
net/mac80211/debugfs_sta.c +1 -1
index fc1a024..6cfe35a 100644
@@ -158,7 +158,7 @@ static ssize_t sta_last_seq_ctrl_read(struct file *file, char __user *userbuf,
 	struct sta_info *sta = file->private_data;
 	for (i = 0; i < NUM_RX_DATA_QUEUES; i++)
 		p += scnprintf(p, sizeof(buf)+buf-p, "%x ",
-			       sta->last_seq_ctrl[i]);
+			       le16_to_cpu(sta->last_seq_ctrl[i]));
 	p += scnprintf(p, sizeof(buf)+buf-p, "\n");
 	return simple_read_from_buffer(userbuf, count, ppos, buf, p - buf);
 }
Signature · 1 line
1.5.0.rc2.g73a2
maintainer
#1 lore raw

net/mac80211/debugfs_netdev.c static int netdev_notify(struct notifier_block * nb, · line 739

Quoted 9 lines · Zhu Yi

Fix one more sparse error and comment variable for debugfs_rename TODO.

net/mac80211/debugfs_netdev.c +2 -0
@@ -734,7 +734,9 @@ static int netdev_notify(struct notifier_block * nb,
 			 void *ndev)
 {
 	struct net_device *dev = ndev;
+	/* TODO
 	char buf[10+IFNAMSIZ];
+	*/

Heh, I actually left that intentionally, but yeah, I guess it's fine.

johannes