Skip to contentSkip to conversation

UML - xterm driver tidying

PATCH New Jeff Dike 1 participant 1 message Jun 13, 2007 User-mode Linux (UML)

lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

PATCH 2/2 UML - xterm driver tidying

Major tidying of the xterm console driver:
got rid of the tt-mode gdb support
tidied up the includes
fixed lots of style violations
replaced os_* calls with glibc calls in xterm.c all printk calls now have a severity indicator the error paths of xterm_open are closer to being right

Signed-off-by Jeff Dike <[email protected]>

--

 arch/um/drivers/ssl.c           |    2 
 arch/um/drivers/stdio_console.c |    2 
 arch/um/drivers/xterm.c         |  173 ++++++++++++++++++++--------------------
 arch/um/drivers/xterm_kern.c    |   49 +++--------
 arch/um/include/chan_user.h     |    2 
 5 files changed, 105 insertions(+), 123 deletions(-)
arch/um/drivers/ssl.c +0 -2
Index: linux-2.6.21-mm/arch/um/drivers/ssl.c
===================================================================
@@ -42,8 +42,6 @@ static struct chan_opts opts = {
 	.announce 	= ssl_announce,
 	.xterm_title	= "Serial Line #%d",
 	.raw		= 1,
-	.tramp_stack 	= 0,
-	.in_kernel 	= 1,
 };
 
 static int ssl_config(char *str, char **error_out);
arch/um/drivers/stdio_console.c +0 -2
Index: linux-2.6.21-mm/arch/um/drivers/stdio_console.c
===================================================================
@@ -46,8 +46,6 @@ static struct chan_opts opts = {
 	.announce 	= stdio_announce,
 	.xterm_title	= "Virtual Console #%d",
 	.raw		= 1,
-	.tramp_stack 	= 0,
-	.in_kernel 	= 1,
 };
 
 static int con_config(char *str, char **error_out);
arch/um/drivers/xterm.c +88 -85

279 lines not on this page · raw message

arch/um/include/chan_user.h +0 -2
Index: linux-2.6.21-mm/arch/um/include/chan_user.h
===================================================================
@@ -12,8 +12,6 @@ struct chan_opts {
 	void (*const announce)(char *dev_name, int dev);
 	char *xterm_title;
 	const int raw;
-	const unsigned long tramp_stack;
-	const int in_kernel;
 };
 
 enum chan_init_pri { INIT_STATIC, INIT_ALL, INIT_ONE };
arch/um/drivers/xterm_kern.c +17 -32

85 lines not on this page · raw message

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel