Skip to contentSkip to conversation

Add a guilt-export(1) command to export a guilt series to quilt.

PATCH Applied Pierre Habouzit 3 participants 6 messages Jun 15, 2016 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add a guilt-export(1) command to export a guilt series to quilt.

---
 Documentation/guilt-export.txt |   30 ++++++++++++++++++++++++++++++
 guilt-export                   |   26 ++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/guilt-export.txt
 create mode 100755 guilt-export
Documentation/guilt-export.txt new file +30 -0
new file mode 100644
index 0000000..b7b0a4b
@@ -0,0 +1,30 @@
+guilt-export(1)
+===============
+
+NAME
+----
+guilt-export - Export a patch series (to be used by quilt)
+
+SYNOPSIS
+--------
+include::usage-guilt-export.txt[]
+
+DESCRIPTION
+-----------
+Export a guilt series to be used by quilt.
+
+OPTIONS
+-------
+<target_dir>::
+        Name of the directory to export the patch series to.
+        (defaults to patches).
+
+Author
+------
+Written by Pierre Habouzit <[email protected]>
+
+Documentation
+-------------
+Documentation by Pierre Habouzit <[email protected]>
+
+include::footer.txt[]
guilt-export new file +26 -0
new file mode 100755
index 0000000..9ff9924
@@ -0,0 +1,26 @@
+#!/bin/bash
+#
+# Copyright (c) Pierre Habouzit, 2007
+#
+
+USAGE="[<target_dir>]"
+. guilt
+
+if [ $# -gt 1 ]; then
+	usage
+fi
+target_dir=${1:-"patches"}
+
+if [ -e "$target_dir" ]; then
+	die "Specified directory already exists"
+fi
+
+trap "rm -rf \"$target_dir\"" 0
+mkdir -p "$target_dir"
+
+get_series | tee "$target_dir/series" | while read p; do
+	cp "$GUILT_DIR/$branch/$p" "$target_dir/$p"
+done
+
+trap - 0
+echo "Series exported to \"$target_dir\" sucessfully."
Signature · 1 line
1.5.2.1
#1 lore raw

For the shebang:
#!/usr/bin/env bash
should works well and should work on non-linux boxes that did not added a link in /bin/bash.

My 2 cents.

Quoted 84 lines · Pierre Habouzit
---
 Documentation/guilt-export.txt |   30 ++++++++++++++++++++++++++++++
 guilt-export                   |   26 ++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/guilt-export.txt
 create mode 100755 guilt-export
Documentation/guilt-export.txt new file +30 -0
new file mode 100644
index 0000000..b7b0a4b
@@ -0,0 +1,30 @@
+guilt-export(1)
+===============
+
+NAME
+----
+guilt-export - Export a patch series (to be used by quilt)
+
+SYNOPSIS
+--------
+include::usage-guilt-export.txt[]
+
+DESCRIPTION
+-----------
+Export a guilt series to be used by quilt.
+
+OPTIONS
+-------
+<target_dir>::
+        Name of the directory to export the patch series to.
+        (defaults to patches).
+
+Author
+------
+Written by Pierre Habouzit <[email protected]>
+
+Documentation
+-------------
+Documentation by Pierre Habouzit <[email protected]>
+
+include::footer.txt[]
guilt-export new file +26 -1
new file mode 100755
index 0000000..9ff9924
@@ -0,0 +1,26 @@
+#!/bin/bash
+#
+# Copyright (c) Pierre Habouzit, 2007
+#
+
+USAGE="[<target_dir>]"
+. guilt
+
+if [ $# -gt 1 ]; then
+       usage
+fi
+target_dir=${1:-"patches"}
+
+if [ -e "$target_dir" ]; then
+       die "Specified directory already exists"
+fi
+
+trap "rm -rf \"$target_dir\"" 0
+mkdir -p "$target_dir"
+
+get_series | tee "$target_dir/series" | while read p; do
+       cp "$GUILT_DIR/$branch/$p" "$target_dir/$p"
+done
+
+trap - 0
+echo "Series exported to \"$target_dir\" sucessfully."
--

1.5.2.1

-
To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 4 lines · Benjamin Sergeant

For the shebang:
#!/usr/bin/env bash
should works well and should work on non-linux boxes that did not added a link in /bin/bash.

FWIW it would spawn a process for nothin, and every other guilt
command uses that. People using it on non linux box would have to run a sed on every shebang at install time, that's not _that_ hard anyways, and is common practice with python or perl scripts e.g. IMHO it's not a problem.

Signature · 3 lines
·O·  Pierre Habouzit
··O                                                [email protected]
OOO                                                http://www.madism.org
#3 lore raw
In reply to Benjamin Sergeant
Quoted 4 lines · Benjamin Sergeant

For the shebang:
#!/usr/bin/env bash
should works well and should work on non-linux boxes that did not added a link in /bin/bash.

Ideally, the best thing to do is to change guilt to use /bin/sh. Right now, there are a number of bash-isms that are used. And if a system doesn't have /bin/sh, it doesn't deserve to run any useful software ;)

Patches are welcomed ;)

Josef "Jeff" Sipek.

Signature · 2 lines
Reality is merely an illusion, albeit a very persistent one.
		- Albert Einstein
#4 lore raw
Quoted 11 lines · Josef Sipek
Quoted 4 lines · Benjamin Sergeant

For the shebang:
#!/usr/bin/env bash
should works well and should work on non-linux boxes that did not added a link in /bin/bash.

Ideally, the best thing to do is to change guilt to use /bin/sh. Right now, there are a number of bash-isms that are used. And if a system doesn't have /bin/sh, it doesn't deserve to run any useful software ;)

Patches are welcomed ;)

Makes sense. I'm currently working on it (so that nobody loses time on
that issue).

I'm mostly done with guilt(1), I still need to take some "local"
variables down (especially in guilt_push or whatever the function name is). Most of the rest has been dealt with already.

I should send a patch serie towards POSIX-shell-isation soon, as soon
as I've tested the patches with bash, zsh, dash and posh.

Cheers,

Signature · 3 lines
·O·  Pierre Habouzit
··O                                                [email protected]
OOO                                                http://www.madism.org
Applied
#5 lore raw
In reply to Pierre Habouzit
Quoted 7 lines · Pierre Habouzit
---
 Documentation/guilt-export.txt |   30 ++++++++++++++++++++++++++++++
 guilt-export                   |   26 ++++++++++++++++++++++++++
 2 files changed, 56 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/guilt-export.txt
 create mode 100755 guilt-export

Applied.

Thanks.

Josef "Jeff" Sipek.

Signature · 3 lines
Computer Science is no more about computers than astronomy is about
telescopes.
		- Edsger Dijkstra