Fix stupid wol variable overflow bug

PATCH New Michael Buesch 1 participant 1 message Jun 17, 2007

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Michael Buesch

author

2007-06-17 11:41 UTC #0 lore raw

PATCH 1/1 Fix stupid wol variable overflow bug

This bug was introduced by me.
val is 16bit, but the read value is 32bit.
Seems like I was smoking crack when porting that part of the driver. I guess that's the last stupid bug in these 4 lines of code.

Signed-off-by Michael Buesch <[email protected]>

drivers/net/b44.c +1 -2

Index: bu3sch-wireless-dev/drivers/net/b44.c
===================================================================
@@ -1574,8 +1574,7 @@ static void b44_setup_wol_pci(struct b44
 	u16 val;
 
 	if (bp->sdev->bus->bustype != SSB_BUSTYPE_SSB) {
-		val = br32(bp, SSB_TMSLOW);
-		bw32(bp, SSB_TMSLOW, val | SSB_TMSLOW_PE);
+		bw32(bp, SSB_TMSLOW, br32(bp, SSB_TMSLOW) | SSB_TMSLOW_PE);
 		pci_read_config_word(bp->sdev->bus->host_pci, SSB_PMCSR, &val);
 		pci_write_config_word(bp->sdev->bus->host_pci, SSB_PMCSR, val | SSB_PE);
 	}

Please apply this to wireless-dev.

Signature · 1 line

Greetings Michael.