Skip to contentSkip to conversation

include/linux/kprobes.h: always offer show_registers() prototype

PATCH NAK Adrian Bunk 2 participants 2 messages Jun 17, 2007 – Jun 18, 2007 kprobes

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include/linux/kprobes.h: always offer show_registers() prototype

Allow gcc to perform show_registers() type checking also with CONFIG_KPROBES=n.

---

This patch has been sent on:
- 27 Apr 2007
- 27 Mar 2007

 include/linux/kprobes.h |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/linux/kprobes.h renamed from include/linux/kprobes.h.old +3 -1
@@ -163,7 +163,6 @@
 extern void arch_arm_kprobe(struct kprobe *p);
 extern void arch_disarm_kprobe(struct kprobe *p);
 extern int arch_init_kprobes(void);
-extern void show_registers(struct pt_regs *regs);
 extern kprobe_opcode_t *get_insn_slot(void);
 extern void free_insn_slot(kprobe_opcode_t *slot, int dirty);
 extern void kprobes_inc_nmissed_count(struct kprobe *p);
@@ -241,4 +240,7 @@
 {
 }
 #endif				/* CONFIG_KPROBES */
+
+void show_registers(struct pt_regs *regs);
+
 #endif				/* _LINUX_KPROBES_H */
#1 lore raw
Quoted 3 lines · Adrian Bunk

Allow gcc to perform show_registers() type checking also with CONFIG_KPROBES=n.

Adrian,

Please implement it as Andrew suggested, when this was patch was posted eariler. Refer this discussion thread below.

http://lkml.org/lkml/2007/4/27/576

NACK

Thanks
Prasanna

Quoted 29 lines

---

This patch has been sent on:
- 27 Apr 2007
- 27 Mar 2007

 include/linux/kprobes.h |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
include/linux/kprobes.h renamed from include/linux/kprobes.h.old +3 -1
@@ -163,7 +163,6 @@
 extern void arch_arm_kprobe(struct kprobe *p);
 extern void arch_disarm_kprobe(struct kprobe *p);
 extern int arch_init_kprobes(void);
-extern void show_registers(struct pt_regs *regs);
 extern kprobe_opcode_t *get_insn_slot(void);
 extern void free_insn_slot(kprobe_opcode_t *slot, int dirty);
 extern void kprobes_inc_nmissed_count(struct kprobe *p);
@@ -241,4 +240,7 @@
 {
 }
 #endif				/* CONFIG_KPROBES */
+
+void show_registers(struct pt_regs *regs);
+
 #endif				/* _LINUX_KPROBES_H */
Signature · 5 lines
Prasanna S.P.
Linux Technology Center
India Software Labs, IBM Bangalore
Email: [email protected]
Ph: 91-80-41776329