Skip to contentSkip to conversation

trivial: the memset operation on a automatic array variable should be optimized out by data initialization

PATCH In review Denis Cheng 5 participants 6 messages Jun 18, 2007 – Jun 21, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trivial: the memset operation on a automatic array variable should be optimized out by data initialization

From: Denis Cheng <[email protected]>

the explicit memset call could be optimized out by data initialization, thus all the fill working can be done by the compiler implicitly.

---
Is there some comments on this?

x86_64/mm/init.c renamed from x86_64/mm/init.c.orig +1 -2
@@ -406,8 +406,7 @@ void __cpuinit zap_low_mappings(int cpu)
 #ifndef CONFIG_NUMA
 void __init paging_init(void)
 {
-	unsigned long max_zone_pfns[MAX_NR_ZONES];
-	memset(max_zone_pfns, 0, sizeof(max_zone_pfns));
+	unsigned long max_zone_pfns[MAX_NR_ZONES] = { 0, };
 	max_zone_pfns[ZONE_DMA] = MAX_DMA_PFN;
 	max_zone_pfns[ZONE_DMA32] = MAX_DMA32_PFN;
 	max_zone_pfns[ZONE_NORMAL] = end_pfn;
#1 lore raw
Quoted 13 lines · Denis Cheng

From: Denis Cheng <[email protected]>

the explicit memset call could be optimized out by data initialization, thus all the fill working can be done by the compiler implicitly.

---
Is there some comments on this?

x86_64/mm/init.c void __cpuinit zap_low_mappings(int cpu) · line 409

Quoted 6 lines
x86_64/mm/init.c renamed from x86_64/mm/init.c.orig +1 -2
@@ -406,8 +406,7 @@ void __cpuinit zap_low_mappings(int cpu)
 #ifndef CONFIG_NUMA
 void __init paging_init(void)
 {
-	unsigned long max_zone_pfns[MAX_NR_ZONES];
-	memset(max_zone_pfns, 0, sizeof(max_zone_pfns));
+	unsigned long max_zone_pfns[MAX_NR_ZONES] = { 0, };

the drawback i see to this is that it's *visually* misleading. it *appears* that what the programmer is trying to do is just initialize the first element, not all of them -- regardless of the actual effect.

rday

Signature · 7 lines
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
#2 lore raw
Quoted 12 lines · Robert P. J. Day
Quoted 10 lines · Denis Cheng

From: Denis Cheng <[email protected]>

the explicit memset call could be optimized out by data initialization, thus all the fill working can be done by the compiler implicitly.

---
Is there some comments on this?

Quoted 14 lines

x86_64/mm/init.c void __cpuinit zap_low_mappings(int cpu) · line 409

Quoted 9 lines
x86_64/mm/init.c renamed from x86_64/mm/init.c.orig +1 -2
@@ -406,8 +406,7 @@ void __cpuinit zap_low_mappings(int cpu)
 #ifndef CONFIG_NUMA
 void __init paging_init(void)
 {
-	unsigned long max_zone_pfns[MAX_NR_ZONES];
-	memset(max_zone_pfns, 0, sizeof(max_zone_pfns));
+	unsigned long max_zone_pfns[MAX_NR_ZONES] = { 0, };

the drawback i see to this is that it's *visually* misleading. it *appears* that what the programmer is trying to do is just initialize the first element, not all of them -- regardless of the actual effect.

C standard can guarantee all of them are initialized, and this is _not_ hard to understand for a good C programmer.

Ack for Denis's change.

Regards!

#3 lore raw
In reply to Denis Cheng
Quoted 5 lines · Denis Cheng

From: Denis Cheng <[email protected]>

the explicit memset call could be optimized out by data initialization, thus all the fill working can be done by the compiler implicitly.

How does the generated code change? Does gcc do something stupid like statically allocate a prototype structure full of zeros, and then memcpy it in? Or does it generate a series of explicit assignments for each member? Or does it generate a memset anyway?

Seems to me that this gives gcc the opportunity to be more stupid, and the only right answer is what we're doing anyway.

J

#4 lore raw
Quoted 6 lines · Jeremy Fitzhardinge
Quoted 4 lines · Denis Cheng

From: Denis Cheng <[email protected]>

the explicit memset call could be optimized out by data initialization, thus all the fill working can be done by the compiler implicitly.

Quoted 7 lines

How does the generated code change? Does gcc do something stupid like statically allocate a prototype structure full of zeros, and then memcpy it in? Or does it generate a series of explicit assignments for each member? Or does it generate a memset anyway?

Seems to me that this gives gcc the opportunity to be more stupid, and the only right answer is what we're doing anyway.

I checked with gcc 4.2, and gcc is quite clever:

If an array is big, gcc uses memset.
If an array is small, gcc does it directly in assembler.

Quoted 1 line

J

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#5 lore raw
In reply to Jeremy Fitzhardinge
Quoted 12 lines · Jeremy Fitzhardinge
Quoted 5 lines · Denis Cheng

From: Denis Cheng <[email protected]>

the explicit memset call could be optimized out by data initialization, thus all the fill working can be done by the compiler implicitly.

How does the generated code change? Does gcc do something stupid like statically allocate a prototype structure full of zeros, and then memcpy it in? Or does it generate a series of explicit assignments for each member? Or does it generate a memset anyway?

Quoted 5 lines

Seems to me that this gives gcc the opportunity to be more stupid, and the only right answer is what we're doing anyway.

J

Technically speaking, C standard guarantees the data be initialized correctly; just from the point view of code style, let the compiler selects how to initialize will be better, this could let the compiler has more optimization points.

Signature · 2 lines
Denis Cheng
Linux Application Developer