Skip to contentSkip to conversation

How to improve the quality of the kernel?

DISCUSSION Al Boldi 4 participants 11 messages Jun 17, 2007 – Jun 22, 2007

lore
Share & tools
lore

Al Boldi

author
#0 lore raw
Quoted 10 lines · Bartlomiej Zolnierkiewicz
Quoted 6 lines · Andrew Morton

We of course do want to minimise the amount of overhead for each developer. I'm a strong believer in specialisation: rather than requiring that *every* developer/maintainer integrate new steps in their processes it would be better to allow them to proceed in a close-to-usual fashion and to provide for a specialist person (or team) to do the sorts of things which you're thinking about.

Makes sense... however we need to educate each and every developer about importance of the code review and proper recognition of reviewers.

That's as easy to manage as is currently done with rc-regressions.

Maybe Adrian can introduce a "Patch Review Tacking" system akin to the his "rc-Regression Tracking" system.

Thanks!

--
Al

#1 lore raw
Quoted 9 lines · Al Boldi
Quoted 8 lines · Bartlomiej Zolnierkiewicz
Quoted 6 lines · Andrew Morton

We of course do want to minimise the amount of overhead for each developer. I'm a strong believer in specialisation: rather than requiring that *every* developer/maintainer integrate new steps in their processes it would be better to allow them to proceed in a close-to-usual fashion and to provide for a specialist person (or team) to do the sorts of things which you're thinking about.

Quoted 4 lines
Quoted 2 lines

Makes sense... however we need to educate each and every developer about importance of the code review and proper recognition of reviewers.

That's as easy to manage as is currently done with rc-regressions.

Are you a volunteer?

It's not an easy task, there are more patches than regressions.

Regards,
Michal

Signature · 2 lines
LOG
http://www.stardust.webpages.pl/log/
author
#2 lore raw
Quoted 10 lines · Michal Piotrowski
Quoted 9 lines · Al Boldi
Quoted 8 lines · Bartlomiej Zolnierkiewicz
Quoted 6 lines · Andrew Morton

We of course do want to minimise the amount of overhead for each developer. I'm a strong believer in specialisation: rather than requiring that *every* developer/maintainer integrate new steps in their processes it would be better to allow them to proceed in a close-to-usual fashion and to provide for a specialist person (or team) to do the sorts of things which you're thinking about.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Makes sense... however we need to educate each and every developer about importance of the code review and proper recognition of reviewers.

That's as easy to manage as is currently done with rc-regressions.

Are you a volunteer?

Probably not, as this task requires a real PRO!

Quoted 1 line

It's not an easy task, there are more patches than regressions.

I didn't say it was an easy task, and it probably involves a lot of stamina.

But the management aspect looks rather straight forward, yet rewarding.

Thanks!

--
Al

#3 lore raw
Quoted 15 lines · Al Boldi
Quoted 14 lines · Michal Piotrowski
Quoted 13 lines · Al Boldi
Quoted 11 lines · Bartlomiej Zolnierkiewicz
Quoted 6 lines · Andrew Morton

We of course do want to minimise the amount of overhead for each developer. I'm a strong believer in specialisation: rather than requiring that *every* developer/maintainer integrate new steps in their processes it would be better to allow them to proceed in a close-to-usual fashion and to provide for a specialist person (or team) to do the sorts of things which you're thinking about.

Makes sense... however we need to educate each and every developer about importance of the code review and proper recognition of reviewers.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

That's as easy to manage as is currently done with rc-regressions.

Are you a volunteer?

Probably not, as this task requires a real PRO!
...

That's wrong.

We are talking about _tracking_.

I'm not sure whether it makes much sense, and it would cost an enormous amount of time, but tracking patches should be possible without any knowledge of the kernel.

Quoted 2 lines

Thanks!
Al

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#4 lore raw
Quoted 24 lines · Adrian Bunk
Quoted 16 lines · Al Boldi
Quoted 15 lines · Michal Piotrowski
Quoted 14 lines · Al Boldi
Quoted 12 lines · Bartlomiej Zolnierkiewicz
Quoted 7 lines · Andrew Morton

We of course do want to minimise the amount of overhead for each developer. I'm a strong believer in specialisation: rather than requiring that *every* developer/maintainer integrate new steps in their processes it would be better to allow them to proceed in a close-to-usual fashion and to provide for a specialist person (or team) to do the sorts of things which you're thinking about.

Makes sense... however we need to educate each and every developer about importance of the code review and proper recognition of reviewers.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

That's as easy to manage as is currently done with rc-regressions.

Are you a volunteer?

Probably not, as this task requires a real PRO!
...

Quoted 7 lines

That's wrong.

We are talking about _tracking_.

I'm not sure whether it makes much sense, and it would cost an enormous amount of time, but tracking patches should be possible without any knowledge of the kernel.

If that's really true, which I can't imagine, then the proper way forward would probably involve a fully automated system.

Thanks!

--
Al

#5 lore raw
Quoted 27 lines · Al Boldi
Quoted 26 lines · Adrian Bunk
Quoted 16 lines · Al Boldi
Quoted 15 lines · Michal Piotrowski
Quoted 14 lines · Al Boldi
Quoted 12 lines · Bartlomiej Zolnierkiewicz
Quoted 7 lines · Andrew Morton

We of course do want to minimise the amount of overhead for each developer. I'm a strong believer in specialisation: rather than requiring that *every* developer/maintainer integrate new steps in their processes it would be better to allow them to proceed in a close-to-usual fashion and to provide for a specialist person (or team) to do the sorts of things which you're thinking about.

Makes sense... however we need to educate each and every developer about importance of the code review and proper recognition of reviewers.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

That's as easy to manage as is currently done with rc-regressions.

Are you a volunteer?

Probably not, as this task requires a real PRO!
...

That's wrong.

Quoted 8 lines
Quoted 5 lines

We are talking about _tracking_.

I'm not sure whether it makes much sense, and it would cost an enormous amount of time, but tracking patches should be possible without any knowledge of the kernel.

If that's really true, which I can't imagine, then the proper way forward would probably involve a fully automated system.

If you consider any kind of patch tracking valuable, you should either do it yourself or write the tool yourself. In both cases, the interesting parts would be how to integrate it into the workflow of kernel development without creating extra work for anyone and how to get the information into the got commits.

"requires a real PRO" and "would probably involve" sound like cheap phrases for avoiding doing any work yourself.

Talk is cheap, but unless YOU will do it your emails will only be a waste of bandwidth.

Quoted 2 lines

Thanks!
Al

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#6 lore raw
Quoted 8 lines · Adrian Bunk
Quoted 7 lines · Al Boldi
Quoted 5 lines · Adrian Bunk

We are talking about _tracking_.

I'm not sure whether it makes much sense, and it would cost an enormous amount of time, but tracking patches should be possible without any knowledge of the kernel.

Quoted 8 lines
Quoted 2 lines

If that's really true, which I can't imagine, then the proper way forward would probably involve a fully automated system.

If you consider any kind of patch tracking valuable, you should either do it yourself or write the tool yourself. In both cases, the interesting parts would be how to integrate it into the workflow of kernel development without creating extra work for anyone and how to get the information into the got commits.

Integration is the easy part, really. Just filter all the patches from the mailing list into a patch-bin, then sort, categorize, and prioritize them, responding with a validation status to all parties involved.

And after that comes the Tracking part.

Quoted 2 lines

"requires a real PRO" and "would probably involve" sound like cheap phrases for avoiding doing any work yourself.

I have learned from this list that premature involvement is counterproductive.

Quoted 2 lines

Talk is cheap, but unless YOU will do it your emails will only be a waste of bandwidth.

Thanks, and good luck with involving people with this kind of response!

--
Al

#7 lore raw
Quoted 18 lines · Al Boldi
Quoted 8 lines · Adrian Bunk
Quoted 7 lines · Al Boldi
Quoted 5 lines · Adrian Bunk

We are talking about _tracking_.

I'm not sure whether it makes much sense, and it would cost an enormous amount of time, but tracking patches should be possible without any knowledge of the kernel.

Quoted 8 lines
Quoted 2 lines

If that's really true, which I can't imagine, then the proper way forward would probably involve a fully automated system.

If you consider any kind of patch tracking valuable, you should either do it yourself or write the tool yourself. In both cases, the interesting parts would be how to integrate it into the workflow of kernel development without creating extra work for anyone and how to get the information into the got commits.

Quoted 5 lines

Integration is the easy part, really. Just filter all the patches from the mailing list into a patch-bin, then sort, categorize, and prioritize them, responding with a validation status to all parties involved.

And after that comes the Tracking part.

Tracking shouldn't be much more than seeing what different threads are about the same patch and then do more or less the same as what you called "the easy part".

Quoted 10 lines
Quoted 2 lines

"requires a real PRO" and "would probably involve" sound like cheap phrases for avoiding doing any work yourself.

I have learned from this list that premature involvement is counterproductive.

Quoted 2 lines

Talk is cheap, but unless YOU will do it your emails will only be a waste of bandwidth.

Thanks, and good luck with involving people with this kind of response!

It's simply how kernel development works - not by talking but by doing the work.

Many people thought long-term maintainance for 2.6.16 wouldn't make sense. And I didn't start long discussions whether we need regression tracking - I simply did it.

These are things that simply happened because I thought they were important - and because I got my ass up to do them myself.

Don't expect anyone to jump up to do it only because of your talk. YOU must offer something, and it will work if it's then accepted by people.

If you think what you have in mind is both doable and important just do it. You will find out where the problems lie yourself.
You might be able to prove me and all other people who think it would not work wrong.
You might fail, e.g. because people will not adopt whatever you have in mind because they don't like it for some reason, but that's part of how development works, and you'll never know unless you try it.

Quoted 1 line

Al

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#8 lore raw
Quoted 9 lines · Adrian Bunk
Quoted 5 lines · Al Boldi
Quoted 2 lines · Adrian Bunk

Talk is cheap, but unless YOU will do it your emails will only be a waste of bandwidth.

Thanks, and good luck with involving people with this kind of response!

It's simply how kernel development works - not by talking but by doing the work.

This sounds like a brute-force approach, akin to hacking.

I think it's much more productive to analyze the problem and then design a solution accordingly.

Quoted 3 lines

Many people thought long-term maintainance for 2.6.16 wouldn't make sense. And I didn't start long discussions whether we need regression tracking - I simply did it.

Maybe because you are a PRO.

Quoted 7 lines

These are things that simply happened because I thought they were important - and because I got my ass up to do them myself.

Don't expect anyone to jump up to do it only because of your talk. YOU must offer something, and it will work if it's then accepted by people.

Quoted 7 lines

If you think what you have in mind is both doable and important just do it. You will find out where the problems lie yourself.
You might be able to prove me and all other people who think it would not work wrong.
You might fail, e.g. because people will not adopt whatever you have in mind because they don't like it for some reason, but that's part of how development works, and you'll never know unless you try it.

Thanks!

--
Al

#9 lore raw
Quoted 8 lines · Al Boldi
Quoted 7 lines · Adrian Bunk
Quoted 5 lines · Al Boldi
Quoted 2 lines · Adrian Bunk

Talk is cheap, but unless YOU will do it your emails will only be a waste of bandwidth.

Thanks, and good luck with involving people with this kind of response!

Quoted 7 lines
Quoted 2 lines

It's simply how kernel development works - not by talking but by doing the work.

This sounds like a brute-force approach, akin to hacking.

I think it's much more productive to analyze the problem and then design a solution accordingly.

Sure, that's part of creating your solution.

But when you've analyzed the problem and designed a solution, YOU have to implement it.

Quoted 6 lines
Quoted 3 lines

Many people thought long-term maintainance for 2.6.16 wouldn't make sense. And I didn't start long discussions whether we need regression tracking - I simply did it.

Maybe because you are a PRO.
...

No, simply because I got my ass up.

Quoted 2 lines

Thanks!
Al

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#10 lore raw
In reply to Al Boldi
Quoted 5 lines · Al Boldi
Quoted 4 lines · Adrian Bunk
Quoted 3 lines · Al Boldi
Quoted 2 lines · Michal Piotrowski
Quoted 1 line · Al Boldi

Bartlomiej Zolnierkiewicz wrote:

[on the tracking of review status of patches]

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

however we need to educate each and every developer about importance of the code review and proper recognition of reviewers.

That's as easy to manage as is currently done with rc-regressions.

Are you a volunteer?

Probably not, as this task requires a real PRO!
...

Quoted 7 lines
Quoted 7 lines

That's wrong.

We are talking about _tracking_.

I'm not sure whether it makes much sense, and it would cost an enormous amount of time, but tracking patches should be possible without any knowledge of the kernel.

I suspect you are...

Quoted 2 lines

If that's really true, which I can't imagine, then the proper way forward would probably involve a fully automated system.

...both wrong --- because patches have varying requirements WRT review and testing.

What you discuss here under the label "patch tracking" blends into, how shall I call it, "patch handling" as done by maintainers. Neither a layman nor an automaton is able to
1. measure required vs. accomplished review and testing of a patch,
2. recruit reviewers and testers.

And IMO *these* two are the points where we typically fail. We occasionally underestimate the required amount of review and testing, but more importantly, we are chronically short of reviewers and partially of testers. (Hmm, I think Adrian and one or another guy already said as much.)

A "Reviewed-by" tag in a patch is not a simple hard fact. Neither a layman nor an automaton can draw appropriate conclusions from it. That doesn't mean I'm against such tags, on the contrary. They may help us to (a) look harder for review, (b) have a better picture of actual lack of review, patch by patch, subsystem by subsystem, and (c) get more volunteer reviewers by emphasizing the merits of code review. Alas, experience and broad knowledge in kernel development are certainly prerequisites to become a good reviewer, so don't get high hopes that reviewers will suddenly come in droves when we appropriately credit their work.

Signature · 3 lines
Stefan Richter
-=====-=-=== -==- =-=-=
http://arcgraph.de/sr/