Skip to contentSkip to conversation

DLM: fix kconfig dependency

PATCH In review Andreas Herrmann 3 participants 3 messages Jun 22, 2007 Distributed lock manager (DLM)

lore
Share & tools
lore

Andreas Herrmann

author
#0 lore raw

PATCH 1/1 DLM: fix kconfig dependency

Avoid kernel build error (as DLM depends on SYSFS)

LD vmlinux
fs/built-in.o: In function `dlm_lockspace_init':
: undefined reference to `kernel_subsys'
fs/built-in.o: In function `configfs_init':
mount.c:(.init.text+0xef4): undefined reference to `kernel_subsys'

Signed-off-by Andreas Herrmann <[email protected]>
fs/dlm/Kconfig +1 -1
index 69a9469..c0e4c59 100644
@@ -1,5 +1,5 @@
 menu "Distributed Lock Manager"
-	depends on EXPERIMENTAL && INET
+	depends on EXPERIMENTAL && INET && SYSFS
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
maintainer
#1 lore raw
Quoted 15 lines · Andreas Herrmann

Avoid kernel build error (as DLM depends on SYSFS)

LD vmlinux
fs/built-in.o: In function `dlm_lockspace_init':
: undefined reference to `kernel_subsys'
fs/built-in.o: In function `configfs_init':
mount.c:(.init.text+0xef4): undefined reference to `kernel_subsys'

Signed-off-by Andreas Herrmann <[email protected]>
fs/dlm/Kconfig +0 -0
index 69a9469..c0e4c59 100644

fs/dlm/Kconfig line 5

Quoted 6 lines
fs/dlm/Kconfig +1 -1
@@ -1,5 +1,5 @@
 menu "Distributed Lock Manager"
-	depends on EXPERIMENTAL && INET
+	depends on EXPERIMENTAL && INET && SYSFS
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"

There's a been a lot of back and forth on this from a number of different people:

1/18/06 depends on SYSFS
4/25/06 - depends on SYSFS
2/05/07 + select SYSFS
2/05/07 - select SYSFS
+ depends on SYSFS
5/01/07 - depends on SYSFS

It looks like the last removal was in error and it should be added back.

Dave

#2 lore raw
Quoted 26 lines · David Teigland
Quoted 15 lines · Andreas Herrmann

Avoid kernel build error (as DLM depends on SYSFS)

LD vmlinux
fs/built-in.o: In function `dlm_lockspace_init':
: undefined reference to `kernel_subsys'
fs/built-in.o: In function `configfs_init':
mount.c:(.init.text+0xef4): undefined reference to `kernel_subsys'

Signed-off-by Andreas Herrmann <[email protected]>
fs/dlm/Kconfig +0 -0
index 69a9469..c0e4c59 100644

fs/dlm/Kconfig line 5

Quoted 6 lines
fs/dlm/Kconfig +1 -1
@@ -1,5 +1,5 @@
 menu "Distributed Lock Manager"
-     depends on EXPERIMENTAL && INET
+     depends on EXPERIMENTAL && INET && SYSFS
 
 config DLM
      tristate "Distributed Lock Manager (DLM)"

There's a been a lot of back and forth on this from a number of different people:

Quoted 8 lines

1/18/06 depends on SYSFS
4/25/06 - depends on SYSFS
2/05/07 + select SYSFS
2/05/07 - select SYSFS
+ depends on SYSFS
5/01/07 - depends on SYSFS

It looks like the last removal was in error and it should be added back.

DLM needs to depend on SYSFS for another reason: it directly "select"s CONFIGFS_FS when configfs itself "depends on SYSFS". I suspect it selects configfs directly to make it easier to pick DLM, by not forcing users to first go and pick configfs just to make DLM visible in menuconfig, but such usage of select is generally "evil".

There was a thread started by Al Viro some time back which started discussions on possible kbuild-solutions to this "select of a symbol that itself depends on another" problem, but I'm not sure what happened of that ...

Satyam