Skip to contentSkip to conversation

Kernel NFS nfs_update_inode Oops in 2.6.20.11

DISCUSSION Stuart Anderson 5 participants 12 messages Jun 23, 2007 – Jun 28, 2007

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

Stuart Anderson

author
#0 lore raw

We started receiving frequent kernel (2.6.20.11) Oops messages in nfs:nfs_update_inode on a pair of Sun X4600M2 machines once we started mounting an NFS V4 filesystem from a Solaris x86 ZFS server.

Any help in tracking this down would be greatly appreciated.

Thanks.

Jun 22 18:15:49 ldas-grid kernel: Unable to handle kernel NULL pointer dereference at 0000000000000020 RIP: 
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: PGD 3edd83067 PUD 3edd8b067 PMD 0 
Jun 22 18:15:49 ldas-grid kernel: Oops: 0000 [1] SMP 
Jun 22 18:15:49 ldas-grid kernel: CPU 7 
Jun 22 18:15:49 ldas-grid kernel: Modules linked in: nfsd exportfs autofs4 eeprom adm1026 hwmon_vid hwmon i2c_isa i2c_amd756
 i2c_amd8111 nfs lockd nfs_acl sunrpc ipt_REJECT xt_state usb_storage ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tab
les x_tables usbhid dm_mod ohci_hcd ehci_hcd i2c_nforce2 i2c_core e1000 usbcore mptsas scsi_transport_sas mptscsih mptbase s
d_mod scsi_mod
Jun 22 18:15:49 ldas-grid kernel: Pid: 33, comm: events/7 Not tainted 2.6.20.11-CIT #1
Jun 22 18:15:49 ldas-grid kernel: RIP: 0010:[<ffffffff88170989>]  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: RSP: 0018:ffff8103fbc3dc10  EFLAGS: 00010246
Jun 22 18:15:49 ldas-grid kernel: RAX: 0000000000000000 RBX: ffff81035d704ce8 RCX: 0000000000008180
Jun 22 18:15:49 ldas-grid kernel: RDX: ffff8101003cf8c0 RSI: ffff8103ace9c8d0 RDI: ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel: RBP: ffff8103ace9c8d0 R08: 0000000000008180 R09: ffff8103eddf0030
Jun 22 18:15:49 ldas-grid kernel: R10: 0000000000000026 R11: 0000000000000003 R12: ffff81035d704b10
Jun 22 18:15:49 ldas-grid kernel: R13: ffff81035d704ce8 R14: ffff8101fbc3e6c0 R15: ffff8103ace9c8d0
Jun 22 18:15:49 ldas-grid kernel: FS:  00002b526bf797a0(0000) GS:ffff810300141d40(0000) knlGS:00000000f7dbb6c0
Jun 22 18:15:49 ldas-grid kernel: CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
Jun 22 18:15:49 ldas-grid kernel: CR2: 0000000000000020 CR3: 00000003edd89000 CR4: 00000000000006e0
Jun 22 18:15:49 ldas-grid kernel: Process events/7 (pid: 33, threadinfo ffff8103fbc3c000, task ffff8102fbcb90c0)
Jun 22 18:15:49 ldas-grid kernel: Stack:  ffff81035d704ce8 ffff8103ace9c8d0 ffff81035d704da0 ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel:  ffff8101fbc3e6c0 ffffffff88170edb 0000000000000000 ffff8103ace9c800
Jun 22 18:15:49 ldas-grid kernel:  ffff810322664c00 ffffffff881817f0 ffff810376445de0 ffff8101003cf8c0
Jun 22 18:15:49 ldas-grid kernel: Call Trace:
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170edb>] :nfs:nfs_post_op_update_inode+0x4b/0x70
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff881817f0>] :nfs:nfs4_proc_delegreturn+0x160/0x1e0
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff8818e2ae>] :nfs:nfs_do_return_delegation+0x1e/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8816d0e3>] :nfs:nfs_dentry_iput+0x23/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802999a2>] shrink_dcache_for_umount_subtree+0x212/0x270
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80299a53>] shrink_dcache_for_umount+0x53/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288ce9>] generic_shutdown_super+0x19/0x100
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288e29>] kill_anon_super+0x9/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff881724ad>] :nfs:nfs_kill_super+0xd/0x20
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80289046>] deactivate_super+0x76/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a1573>] expire_mount_list+0x133/0x180
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7a0>] :nfs:nfs_expire_automounts+0x0/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a176b>] mark_mounts_for_expiry+0xab/0xc0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7b0>] :nfs:nfs_expire_automounts+0x10/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fd6e>] run_workqueue+0xae/0x160
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80240031>] worker_thread+0x151/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80229490>] default_wake_function+0x0/0x10
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243b79>] kthread+0xd9/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802298cc>] schedule_tail+0x4c/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a998>] child_rip+0xa/0x12
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80219250>] flat_send_IPI_mask+0x0/0x60
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243aa0>] kthread+0x0/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a98e>] child_rip+0x0/0x12
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: Code: 48 3b 58 20 75 31 48 8b 45 60 48 39 82 b0 00 00 00 48 8d 75 
Jun 22 18:15:50 ldas-grid kernel: RIP  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:50 ldas-grid kernel:  RSP <ffff8103fbc3dc10>
Jun 22 18:15:50 ldas-grid kernel: CR2: 0000000000000020
Signature · 11 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#1 lore raw

Does the attached patch (against 2.6.22) fix it?

Trond

Quoted 56 lines · Stuart Anderson

We started receiving frequent kernel (2.6.20.11) Oops messages in nfs:nfs_update_inode on a pair of Sun X4600M2 machines once we started mounting an NFS V4 filesystem from a Solaris x86 ZFS server.

Any help in tracking this down would be greatly appreciated.

Thanks.

Jun 22 18:15:49 ldas-grid kernel: Unable to handle kernel NULL pointer dereference at 0000000000000020 RIP: 
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: PGD 3edd83067 PUD 3edd8b067 PMD 0 
Jun 22 18:15:49 ldas-grid kernel: Oops: 0000 [1] SMP 
Jun 22 18:15:49 ldas-grid kernel: CPU 7 
Jun 22 18:15:49 ldas-grid kernel: Modules linked in: nfsd exportfs autofs4 eeprom adm1026 hwmon_vid hwmon i2c_isa i2c_amd756
 i2c_amd8111 nfs lockd nfs_acl sunrpc ipt_REJECT xt_state usb_storage ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tab
les x_tables usbhid dm_mod ohci_hcd ehci_hcd i2c_nforce2 i2c_core e1000 usbcore mptsas scsi_transport_sas mptscsih mptbase s
d_mod scsi_mod
Jun 22 18:15:49 ldas-grid kernel: Pid: 33, comm: events/7 Not tainted 2.6.20.11-CIT #1
Jun 22 18:15:49 ldas-grid kernel: RIP: 0010:[<ffffffff88170989>]  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: RSP: 0018:ffff8103fbc3dc10  EFLAGS: 00010246
Jun 22 18:15:49 ldas-grid kernel: RAX: 0000000000000000 RBX: ffff81035d704ce8 RCX: 0000000000008180
Jun 22 18:15:49 ldas-grid kernel: RDX: ffff8101003cf8c0 RSI: ffff8103ace9c8d0 RDI: ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel: RBP: ffff8103ace9c8d0 R08: 0000000000008180 R09: ffff8103eddf0030
Jun 22 18:15:49 ldas-grid kernel: R10: 0000000000000026 R11: 0000000000000003 R12: ffff81035d704b10
Jun 22 18:15:49 ldas-grid kernel: R13: ffff81035d704ce8 R14: ffff8101fbc3e6c0 R15: ffff8103ace9c8d0
Jun 22 18:15:49 ldas-grid kernel: FS:  00002b526bf797a0(0000) GS:ffff810300141d40(0000) knlGS:00000000f7dbb6c0
Jun 22 18:15:49 ldas-grid kernel: CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
Jun 22 18:15:49 ldas-grid kernel: CR2: 0000000000000020 CR3: 00000003edd89000 CR4: 00000000000006e0
Jun 22 18:15:49 ldas-grid kernel: Process events/7 (pid: 33, threadinfo ffff8103fbc3c000, task ffff8102fbcb90c0)
Jun 22 18:15:49 ldas-grid kernel: Stack:  ffff81035d704ce8 ffff8103ace9c8d0 ffff81035d704da0 ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel:  ffff8101fbc3e6c0 ffffffff88170edb 0000000000000000 ffff8103ace9c800
Jun 22 18:15:49 ldas-grid kernel:  ffff810322664c00 ffffffff881817f0 ffff810376445de0 ffff8101003cf8c0
Jun 22 18:15:49 ldas-grid kernel: Call Trace:
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170edb>] :nfs:nfs_post_op_update_inode+0x4b/0x70
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff881817f0>] :nfs:nfs4_proc_delegreturn+0x160/0x1e0
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff8818e2ae>] :nfs:nfs_do_return_delegation+0x1e/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8816d0e3>] :nfs:nfs_dentry_iput+0x23/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802999a2>] shrink_dcache_for_umount_subtree+0x212/0x270
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80299a53>] shrink_dcache_for_umount+0x53/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288ce9>] generic_shutdown_super+0x19/0x100
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288e29>] kill_anon_super+0x9/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff881724ad>] :nfs:nfs_kill_super+0xd/0x20
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80289046>] deactivate_super+0x76/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a1573>] expire_mount_list+0x133/0x180
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7a0>] :nfs:nfs_expire_automounts+0x0/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a176b>] mark_mounts_for_expiry+0xab/0xc0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7b0>] :nfs:nfs_expire_automounts+0x10/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fd6e>] run_workqueue+0xae/0x160
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80240031>] worker_thread+0x151/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80229490>] default_wake_function+0x0/0x10
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243b79>] kthread+0xd9/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802298cc>] schedule_tail+0x4c/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a998>] child_rip+0xa/0x12
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80219250>] flat_send_IPI_mask+0x0/0x60
Quoted 9 lines
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243aa0>] kthread+0x0/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a98e>] child_rip+0x0/0x12
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: Code: 48 3b 58 20 75 31 48 8b 45 60 48 39 82 b0 00 00 00 48 8d 75 
Jun 22 18:15:50 ldas-grid kernel: RIP  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:50 ldas-grid kernel:  RSP <ffff8103fbc3dc10>
Jun 22 18:15:50 ldas-grid kernel: CR2: 0000000000000020

We don't need to revalidate the fsid on the root directory. It suffices to revalidate it on the current directory.

Signed-off-by Trond Myklebust <[email protected]>

---

 fs/nfs/dir.c   |    9 ++++-----
 fs/nfs/inode.c |    4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)
fs/nfs/dir.c +4 -5
index 4948ec1..c02a796 100644
@@ -897,14 +897,13 @@ int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd)
 	return (nd->intent.open.flags & O_EXCL) != 0;
 }
 
-static inline int nfs_reval_fsid(struct vfsmount *mnt, struct inode *dir,
-				 struct nfs_fh *fh, struct nfs_fattr *fattr)
+static inline int nfs_reval_fsid(struct inode *dir, const struct nfs_fattr *fattr)
 {
 	struct nfs_server *server = NFS_SERVER(dir);
 
 	if (!nfs_fsid_equal(&server->fsid, &fattr->fsid))
-		/* Revalidate fsid on root dir */
-		return __nfs_revalidate_inode(server, mnt->mnt_root->d_inode);
+		/* Revalidate fsid using the parent directory */
+		return __nfs_revalidate_inode(server, dir);
 	return 0;
 }
 

@@ -946,7 +945,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru
 		res = ERR_PTR(error);
 		goto out_unlock;
 	}
-	error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);
+	error = nfs_reval_fsid(dir, &fattr);
 	if (error < 0) {
 		res = ERR_PTR(error);
 		goto out_unlock;
fs/nfs/inode.c +2 -2
index 23ecf03..7bcb3df 100644
@@ -961,8 +961,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 		goto out_changed;
 
 	server = NFS_SERVER(inode);
-	/* Update the fsid if and only if this is the root directory */
-	if (inode == inode->i_sb->s_root->d_inode
+	/* Update the fsid? */
+	if (S_ISDIR(inode->i_mode)
 			&& !nfs_fsid_equal(&server->fsid, &fattr->fsid))
 		server->fsid = fattr->fsid;

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

author
#2 lore raw

Trond,

We will give that a try today and let you know our results.

Do you know of any reasons why the same patch cannot be applied to 2.6.20.x (or 2.6.21.y)?

Would this patch also explain why we have a nearly identical Oops after we removed the automounter, i.e., "Modules linked in:" is no longer listed in "autofs4", yet the stack trace still has the "nfs_expire_automounts" entries?

Many thanks.

Quoted 133 lines · Trond Myklebust

Does the attached patch (against 2.6.22) fix it?

Trond

Quoted 56 lines · Stuart Anderson

We started receiving frequent kernel (2.6.20.11) Oops messages in nfs:nfs_update_inode on a pair of Sun X4600M2 machines once we started mounting an NFS V4 filesystem from a Solaris x86 ZFS server.

Any help in tracking this down would be greatly appreciated.

Thanks.

Jun 22 18:15:49 ldas-grid kernel: Unable to handle kernel NULL pointer dereference at 0000000000000020 RIP: 
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: PGD 3edd83067 PUD 3edd8b067 PMD 0 
Jun 22 18:15:49 ldas-grid kernel: Oops: 0000 [1] SMP 
Jun 22 18:15:49 ldas-grid kernel: CPU 7 
Jun 22 18:15:49 ldas-grid kernel: Modules linked in: nfsd exportfs autofs4 eeprom adm1026 hwmon_vid hwmon i2c_isa i2c_amd756
 i2c_amd8111 nfs lockd nfs_acl sunrpc ipt_REJECT xt_state usb_storage ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tab
les x_tables usbhid dm_mod ohci_hcd ehci_hcd i2c_nforce2 i2c_core e1000 usbcore mptsas scsi_transport_sas mptscsih mptbase s
d_mod scsi_mod
Jun 22 18:15:49 ldas-grid kernel: Pid: 33, comm: events/7 Not tainted 2.6.20.11-CIT #1
Jun 22 18:15:49 ldas-grid kernel: RIP: 0010:[<ffffffff88170989>]  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: RSP: 0018:ffff8103fbc3dc10  EFLAGS: 00010246
Jun 22 18:15:49 ldas-grid kernel: RAX: 0000000000000000 RBX: ffff81035d704ce8 RCX: 0000000000008180
Jun 22 18:15:49 ldas-grid kernel: RDX: ffff8101003cf8c0 RSI: ffff8103ace9c8d0 RDI: ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel: RBP: ffff8103ace9c8d0 R08: 0000000000008180 R09: ffff8103eddf0030
Jun 22 18:15:49 ldas-grid kernel: R10: 0000000000000026 R11: 0000000000000003 R12: ffff81035d704b10
Jun 22 18:15:49 ldas-grid kernel: R13: ffff81035d704ce8 R14: ffff8101fbc3e6c0 R15: ffff8103ace9c8d0
Jun 22 18:15:49 ldas-grid kernel: FS:  00002b526bf797a0(0000) GS:ffff810300141d40(0000) knlGS:00000000f7dbb6c0
Jun 22 18:15:49 ldas-grid kernel: CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
Jun 22 18:15:49 ldas-grid kernel: CR2: 0000000000000020 CR3: 00000003edd89000 CR4: 00000000000006e0
Jun 22 18:15:49 ldas-grid kernel: Process events/7 (pid: 33, threadinfo ffff8103fbc3c000, task ffff8102fbcb90c0)
Jun 22 18:15:49 ldas-grid kernel: Stack:  ffff81035d704ce8 ffff8103ace9c8d0 ffff81035d704da0 ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel:  ffff8101fbc3e6c0 ffffffff88170edb 0000000000000000 ffff8103ace9c800
Jun 22 18:15:49 ldas-grid kernel:  ffff810322664c00 ffffffff881817f0 ffff810376445de0 ffff8101003cf8c0
Jun 22 18:15:49 ldas-grid kernel: Call Trace:
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170edb>] :nfs:nfs_post_op_update_inode+0x4b/0x70
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff881817f0>] :nfs:nfs4_proc_delegreturn+0x160/0x1e0
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff8818e2ae>] :nfs:nfs_do_return_delegation+0x1e/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8816d0e3>] :nfs:nfs_dentry_iput+0x23/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802999a2>] shrink_dcache_for_umount_subtree+0x212/0x270
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80299a53>] shrink_dcache_for_umount+0x53/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288ce9>] generic_shutdown_super+0x19/0x100
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288e29>] kill_anon_super+0x9/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff881724ad>] :nfs:nfs_kill_super+0xd/0x20
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80289046>] deactivate_super+0x76/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a1573>] expire_mount_list+0x133/0x180
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7a0>] :nfs:nfs_expire_automounts+0x0/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a176b>] mark_mounts_for_expiry+0xab/0xc0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7b0>] :nfs:nfs_expire_automounts+0x10/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fd6e>] run_workqueue+0xae/0x160
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80240031>] worker_thread+0x151/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80229490>] default_wake_function+0x0/0x10
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243b79>] kthread+0xd9/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802298cc>] schedule_tail+0x4c/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a998>] child_rip+0xa/0x12
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80219250>] flat_send_IPI_mask+0x0/0x60
Quoted 9 lines
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243aa0>] kthread+0x0/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a98e>] child_rip+0x0/0x12
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: Code: 48 3b 58 20 75 31 48 8b 45 60 48 39 82 b0 00 00 00 48 8d 75 
Jun 22 18:15:50 ldas-grid kernel: RIP  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:50 ldas-grid kernel:  RSP <ffff8103fbc3dc10>
Jun 22 18:15:50 ldas-grid kernel: CR2: 0000000000000020

From: Trond Myklebust <[email protected]>
Date: Tue, 5 Jun 2007 13:26:15 -0400
NFS: Fix nfs_reval_fsid()
Subject: No Subject

We don't need to revalidate the fsid on the root directory. It suffices to revalidate it on the current directory.

Signed-off-by Trond Myklebust <[email protected]>

---

 fs/nfs/dir.c   |    9 ++++-----
 fs/nfs/inode.c |    4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)
fs/nfs/dir.c +4 -5
index 4948ec1..c02a796 100644
@@ -897,14 +897,13 @@ int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd)
 	return (nd->intent.open.flags & O_EXCL) != 0;
 }
 
-static inline int nfs_reval_fsid(struct vfsmount *mnt, struct inode *dir,
-				 struct nfs_fh *fh, struct nfs_fattr *fattr)
+static inline int nfs_reval_fsid(struct inode *dir, const struct nfs_fattr *fattr)
 {
 	struct nfs_server *server = NFS_SERVER(dir);
 
 	if (!nfs_fsid_equal(&server->fsid, &fattr->fsid))
-		/* Revalidate fsid on root dir */
-		return __nfs_revalidate_inode(server, mnt->mnt_root->d_inode);
+		/* Revalidate fsid using the parent directory */
+		return __nfs_revalidate_inode(server, dir);
 	return 0;
 }
 

@@ -946,7 +945,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru
 		res = ERR_PTR(error);
 		goto out_unlock;
 	}
-	error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);
+	error = nfs_reval_fsid(dir, &fattr);
 	if (error < 0) {
 		res = ERR_PTR(error);
 		goto out_unlock;
fs/nfs/inode.c +2 -2
index 23ecf03..7bcb3df 100644
@@ -961,8 +961,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 		goto out_changed;
 
 	server = NFS_SERVER(inode);
-	/* Update the fsid if and only if this is the root directory */
-	if (inode == inode->i_sb->s_root->d_inode
+	/* Update the fsid? */
+	if (S_ISDIR(inode->i_mode)
 			&& !nfs_fsid_equal(&server->fsid, &fattr->fsid))
 		server->fsid = fattr->fsid;
Signature · 11 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
author
#3 lore raw
In reply to Trond Myklebust

Trond,

This applied cleanly to 2.6.20.14 and so far so good with 2.5hr uptime on each of two machines that both previously had this Oops on an interval of minutes up to 24hr. The statistics are not conclusive yet, but it does boot and I was able to successfully run "make -j 8 boostrap" on the gcc source code using 8 out of 16 CPU-cores on an NFSV4 mount without crashing.

However, the gcc build did generate 19 of the following on this client machine:
NFS: v4 server returned a bad sequence-id error!
Are these serious? How to go about tracking these down?

The server is a Sun X4500 running ZFS on Solaris10 Update 3 and it did not log any error messages during the gcc build.

Very many thanks for incredible turn around a kernel patch--less than 40 minutes from Oops posting to patch posting!

Malte,
I suggest you give this patch a try as well to see if it solves your
similar/identical(?) Oops posted on lkml.

Quoted 133 lines · Trond Myklebust

Does the attached patch (against 2.6.22) fix it?

Trond

Quoted 56 lines · Stuart Anderson

We started receiving frequent kernel (2.6.20.11) Oops messages in nfs:nfs_update_inode on a pair of Sun X4600M2 machines once we started mounting an NFS V4 filesystem from a Solaris x86 ZFS server.

Any help in tracking this down would be greatly appreciated.

Thanks.

Jun 22 18:15:49 ldas-grid kernel: Unable to handle kernel NULL pointer dereference at 0000000000000020 RIP: 
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: PGD 3edd83067 PUD 3edd8b067 PMD 0 
Jun 22 18:15:49 ldas-grid kernel: Oops: 0000 [1] SMP 
Jun 22 18:15:49 ldas-grid kernel: CPU 7 
Jun 22 18:15:49 ldas-grid kernel: Modules linked in: nfsd exportfs autofs4 eeprom adm1026 hwmon_vid hwmon i2c_isa i2c_amd756
 i2c_amd8111 nfs lockd nfs_acl sunrpc ipt_REJECT xt_state usb_storage ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tab
les x_tables usbhid dm_mod ohci_hcd ehci_hcd i2c_nforce2 i2c_core e1000 usbcore mptsas scsi_transport_sas mptscsih mptbase s
d_mod scsi_mod
Jun 22 18:15:49 ldas-grid kernel: Pid: 33, comm: events/7 Not tainted 2.6.20.11-CIT #1
Jun 22 18:15:49 ldas-grid kernel: RIP: 0010:[<ffffffff88170989>]  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: RSP: 0018:ffff8103fbc3dc10  EFLAGS: 00010246
Jun 22 18:15:49 ldas-grid kernel: RAX: 0000000000000000 RBX: ffff81035d704ce8 RCX: 0000000000008180
Jun 22 18:15:49 ldas-grid kernel: RDX: ffff8101003cf8c0 RSI: ffff8103ace9c8d0 RDI: ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel: RBP: ffff8103ace9c8d0 R08: 0000000000008180 R09: ffff8103eddf0030
Jun 22 18:15:49 ldas-grid kernel: R10: 0000000000000026 R11: 0000000000000003 R12: ffff81035d704b10
Jun 22 18:15:49 ldas-grid kernel: R13: ffff81035d704ce8 R14: ffff8101fbc3e6c0 R15: ffff8103ace9c8d0
Jun 22 18:15:49 ldas-grid kernel: FS:  00002b526bf797a0(0000) GS:ffff810300141d40(0000) knlGS:00000000f7dbb6c0
Jun 22 18:15:49 ldas-grid kernel: CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
Jun 22 18:15:49 ldas-grid kernel: CR2: 0000000000000020 CR3: 00000003edd89000 CR4: 00000000000006e0
Jun 22 18:15:49 ldas-grid kernel: Process events/7 (pid: 33, threadinfo ffff8103fbc3c000, task ffff8102fbcb90c0)
Jun 22 18:15:49 ldas-grid kernel: Stack:  ffff81035d704ce8 ffff8103ace9c8d0 ffff81035d704da0 ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel:  ffff8101fbc3e6c0 ffffffff88170edb 0000000000000000 ffff8103ace9c800
Jun 22 18:15:49 ldas-grid kernel:  ffff810322664c00 ffffffff881817f0 ffff810376445de0 ffff8101003cf8c0
Jun 22 18:15:49 ldas-grid kernel: Call Trace:
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170edb>] :nfs:nfs_post_op_update_inode+0x4b/0x70
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff881817f0>] :nfs:nfs4_proc_delegreturn+0x160/0x1e0
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff8818e2ae>] :nfs:nfs_do_return_delegation+0x1e/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8816d0e3>] :nfs:nfs_dentry_iput+0x23/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802999a2>] shrink_dcache_for_umount_subtree+0x212/0x270
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80299a53>] shrink_dcache_for_umount+0x53/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288ce9>] generic_shutdown_super+0x19/0x100
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288e29>] kill_anon_super+0x9/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff881724ad>] :nfs:nfs_kill_super+0xd/0x20
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80289046>] deactivate_super+0x76/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a1573>] expire_mount_list+0x133/0x180
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7a0>] :nfs:nfs_expire_automounts+0x0/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a176b>] mark_mounts_for_expiry+0xab/0xc0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7b0>] :nfs:nfs_expire_automounts+0x10/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fd6e>] run_workqueue+0xae/0x160
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80240031>] worker_thread+0x151/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80229490>] default_wake_function+0x0/0x10
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243b79>] kthread+0xd9/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802298cc>] schedule_tail+0x4c/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a998>] child_rip+0xa/0x12
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80219250>] flat_send_IPI_mask+0x0/0x60
Quoted 9 lines
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243aa0>] kthread+0x0/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a98e>] child_rip+0x0/0x12
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: Code: 48 3b 58 20 75 31 48 8b 45 60 48 39 82 b0 00 00 00 48 8d 75 
Jun 22 18:15:50 ldas-grid kernel: RIP  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:50 ldas-grid kernel:  RSP <ffff8103fbc3dc10>
Jun 22 18:15:50 ldas-grid kernel: CR2: 0000000000000020

From: Trond Myklebust <[email protected]>
Date: Tue, 5 Jun 2007 13:26:15 -0400
NFS: Fix nfs_reval_fsid()
Subject: No Subject

We don't need to revalidate the fsid on the root directory. It suffices to revalidate it on the current directory.

Signed-off-by Trond Myklebust <[email protected]>

---

 fs/nfs/dir.c   |    9 ++++-----
 fs/nfs/inode.c |    4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)
fs/nfs/dir.c +4 -5
index 4948ec1..c02a796 100644
@@ -897,14 +897,13 @@ int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd)
 	return (nd->intent.open.flags & O_EXCL) != 0;
 }
 
-static inline int nfs_reval_fsid(struct vfsmount *mnt, struct inode *dir,
-				 struct nfs_fh *fh, struct nfs_fattr *fattr)
+static inline int nfs_reval_fsid(struct inode *dir, const struct nfs_fattr *fattr)
 {
 	struct nfs_server *server = NFS_SERVER(dir);
 
 	if (!nfs_fsid_equal(&server->fsid, &fattr->fsid))
-		/* Revalidate fsid on root dir */
-		return __nfs_revalidate_inode(server, mnt->mnt_root->d_inode);
+		/* Revalidate fsid using the parent directory */
+		return __nfs_revalidate_inode(server, dir);
 	return 0;
 }
 

@@ -946,7 +945,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru
 		res = ERR_PTR(error);
 		goto out_unlock;
 	}
-	error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);
+	error = nfs_reval_fsid(dir, &fattr);
 	if (error < 0) {
 		res = ERR_PTR(error);
 		goto out_unlock;
fs/nfs/inode.c +2 -2
index 23ecf03..7bcb3df 100644
@@ -961,8 +961,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 		goto out_changed;
 
 	server = NFS_SERVER(inode);
-	/* Update the fsid if and only if this is the root directory */
-	if (inode == inode->i_sb->s_root->d_inode
+	/* Update the fsid? */
+	if (S_ISDIR(inode->i_mode)
 			&& !nfs_fsid_equal(&server->fsid, &fattr->fsid))
 		server->fsid = fattr->fsid;
Signature · 11 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
author
#4 lore raw

This has patch has now been stable for 5 days on two different machines.

Any thoughts about the "bad sequence-id error"?

Thanks.

Quoted 163 lines · Stuart Anderson

Trond,

This applied cleanly to 2.6.20.14 and so far so good with 2.5hr uptime on each of two machines that both previously had this Oops on an interval of minutes up to 24hr. The statistics are not conclusive yet, but it does boot and I was able to successfully run "make -j 8 boostrap" on the gcc source code using 8 out of 16 CPU-cores on an NFSV4 mount without crashing.

However, the gcc build did generate 19 of the following on this client machine:
NFS: v4 server returned a bad sequence-id error!
Are these serious? How to go about tracking these down?

The server is a Sun X4500 running ZFS on Solaris10 Update 3 and it did not log any error messages during the gcc build.

Very many thanks for incredible turn around a kernel patch--less than 40 minutes from Oops posting to patch posting!

Malte,
I suggest you give this patch a try as well to see if it solves your
similar/identical(?) Oops posted on lkml.

Quoted 133 lines · Trond Myklebust

Does the attached patch (against 2.6.22) fix it?

Trond

Quoted 56 lines · Stuart Anderson

We started receiving frequent kernel (2.6.20.11) Oops messages in nfs:nfs_update_inode on a pair of Sun X4600M2 machines once we started mounting an NFS V4 filesystem from a Solaris x86 ZFS server.

Any help in tracking this down would be greatly appreciated.

Thanks.

Jun 22 18:15:49 ldas-grid kernel: Unable to handle kernel NULL pointer dereference at 0000000000000020 RIP: 
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: PGD 3edd83067 PUD 3edd8b067 PMD 0 
Jun 22 18:15:49 ldas-grid kernel: Oops: 0000 [1] SMP 
Jun 22 18:15:49 ldas-grid kernel: CPU 7 
Jun 22 18:15:49 ldas-grid kernel: Modules linked in: nfsd exportfs autofs4 eeprom adm1026 hwmon_vid hwmon i2c_isa i2c_amd756
 i2c_amd8111 nfs lockd nfs_acl sunrpc ipt_REJECT xt_state usb_storage ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tab
les x_tables usbhid dm_mod ohci_hcd ehci_hcd i2c_nforce2 i2c_core e1000 usbcore mptsas scsi_transport_sas mptscsih mptbase s
d_mod scsi_mod
Jun 22 18:15:49 ldas-grid kernel: Pid: 33, comm: events/7 Not tainted 2.6.20.11-CIT #1
Jun 22 18:15:49 ldas-grid kernel: RIP: 0010:[<ffffffff88170989>]  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: RSP: 0018:ffff8103fbc3dc10  EFLAGS: 00010246
Jun 22 18:15:49 ldas-grid kernel: RAX: 0000000000000000 RBX: ffff81035d704ce8 RCX: 0000000000008180
Jun 22 18:15:49 ldas-grid kernel: RDX: ffff8101003cf8c0 RSI: ffff8103ace9c8d0 RDI: ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel: RBP: ffff8103ace9c8d0 R08: 0000000000008180 R09: ffff8103eddf0030
Jun 22 18:15:49 ldas-grid kernel: R10: 0000000000000026 R11: 0000000000000003 R12: ffff81035d704b10
Jun 22 18:15:49 ldas-grid kernel: R13: ffff81035d704ce8 R14: ffff8101fbc3e6c0 R15: ffff8103ace9c8d0
Jun 22 18:15:49 ldas-grid kernel: FS:  00002b526bf797a0(0000) GS:ffff810300141d40(0000) knlGS:00000000f7dbb6c0
Jun 22 18:15:49 ldas-grid kernel: CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
Jun 22 18:15:49 ldas-grid kernel: CR2: 0000000000000020 CR3: 00000003edd89000 CR4: 00000000000006e0
Jun 22 18:15:49 ldas-grid kernel: Process events/7 (pid: 33, threadinfo ffff8103fbc3c000, task ffff8102fbcb90c0)
Jun 22 18:15:49 ldas-grid kernel: Stack:  ffff81035d704ce8 ffff8103ace9c8d0 ffff81035d704da0 ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel:  ffff8101fbc3e6c0 ffffffff88170edb 0000000000000000 ffff8103ace9c800
Jun 22 18:15:49 ldas-grid kernel:  ffff810322664c00 ffffffff881817f0 ffff810376445de0 ffff8101003cf8c0
Jun 22 18:15:49 ldas-grid kernel: Call Trace:
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170edb>] :nfs:nfs_post_op_update_inode+0x4b/0x70
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff881817f0>] :nfs:nfs4_proc_delegreturn+0x160/0x1e0
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff8818e2ae>] :nfs:nfs_do_return_delegation+0x1e/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8816d0e3>] :nfs:nfs_dentry_iput+0x23/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802999a2>] shrink_dcache_for_umount_subtree+0x212/0x270
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80299a53>] shrink_dcache_for_umount+0x53/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288ce9>] generic_shutdown_super+0x19/0x100
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288e29>] kill_anon_super+0x9/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff881724ad>] :nfs:nfs_kill_super+0xd/0x20
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80289046>] deactivate_super+0x76/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a1573>] expire_mount_list+0x133/0x180
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7a0>] :nfs:nfs_expire_automounts+0x0/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a176b>] mark_mounts_for_expiry+0xab/0xc0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7b0>] :nfs:nfs_expire_automounts+0x10/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fd6e>] run_workqueue+0xae/0x160
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80240031>] worker_thread+0x151/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80229490>] default_wake_function+0x0/0x10
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243b79>] kthread+0xd9/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802298cc>] schedule_tail+0x4c/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a998>] child_rip+0xa/0x12
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80219250>] flat_send_IPI_mask+0x0/0x60
Quoted 9 lines
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243aa0>] kthread+0x0/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a98e>] child_rip+0x0/0x12
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: Code: 48 3b 58 20 75 31 48 8b 45 60 48 39 82 b0 00 00 00 48 8d 75 
Jun 22 18:15:50 ldas-grid kernel: RIP  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:50 ldas-grid kernel:  RSP <ffff8103fbc3dc10>
Jun 22 18:15:50 ldas-grid kernel: CR2: 0000000000000020

From: Trond Myklebust <[email protected]>
Date: Tue, 5 Jun 2007 13:26:15 -0400
NFS: Fix nfs_reval_fsid()
Subject: No Subject

We don't need to revalidate the fsid on the root directory. It suffices to revalidate it on the current directory.

Signed-off-by Trond Myklebust <[email protected]>

---

 fs/nfs/dir.c   |    9 ++++-----
 fs/nfs/inode.c |    4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)
fs/nfs/dir.c +4 -5
index 4948ec1..c02a796 100644
@@ -897,14 +897,13 @@ int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd)
 	return (nd->intent.open.flags & O_EXCL) != 0;
 }
 
-static inline int nfs_reval_fsid(struct vfsmount *mnt, struct inode *dir,
-				 struct nfs_fh *fh, struct nfs_fattr *fattr)
+static inline int nfs_reval_fsid(struct inode *dir, const struct nfs_fattr *fattr)
 {
 	struct nfs_server *server = NFS_SERVER(dir);
 
 	if (!nfs_fsid_equal(&server->fsid, &fattr->fsid))
-		/* Revalidate fsid on root dir */
-		return __nfs_revalidate_inode(server, mnt->mnt_root->d_inode);
+		/* Revalidate fsid using the parent directory */
+		return __nfs_revalidate_inode(server, dir);
 	return 0;
 }
 

@@ -946,7 +945,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru
 		res = ERR_PTR(error);
 		goto out_unlock;
 	}
-	error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);
+	error = nfs_reval_fsid(dir, &fattr);
 	if (error < 0) {
 		res = ERR_PTR(error);
 		goto out_unlock;
fs/nfs/inode.c +2 -2
index 23ecf03..7bcb3df 100644
@@ -961,8 +961,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 		goto out_changed;
 
 	server = NFS_SERVER(inode);
-	/* Update the fsid if and only if this is the root directory */
-	if (inode == inode->i_sb->s_root->d_inode
+	/* Update the fsid? */
+	if (S_ISDIR(inode->i_mode)
 			&& !nfs_fsid_equal(&server->fsid, &fattr->fsid))
 		server->fsid = fattr->fsid;
Signature · 2 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson
Signature · 11 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#5 lore raw
Quoted 3 lines · Stuart Anderson

This has patch has now been stable for 5 days on two different machines.

Any thoughts about the "bad sequence-id error"?

I seem to remember that a couple of sources of state corruption were found in the server in and around the 2.6.20 series. Do I remember correctly, Bruce?

Cheers
Trond

Quoted 167 lines

Thanks.

Quoted 163 lines · Stuart Anderson

Trond,

This applied cleanly to 2.6.20.14 and so far so good with 2.5hr uptime on each of two machines that both previously had this Oops on an interval of minutes up to 24hr. The statistics are not conclusive yet, but it does boot and I was able to successfully run "make -j 8 boostrap" on the gcc source code using 8 out of 16 CPU-cores on an NFSV4 mount without crashing.

However, the gcc build did generate 19 of the following on this client machine:
NFS: v4 server returned a bad sequence-id error!
Are these serious? How to go about tracking these down?

The server is a Sun X4500 running ZFS on Solaris10 Update 3 and it did not log any error messages during the gcc build.

Very many thanks for incredible turn around a kernel patch--less than 40 minutes from Oops posting to patch posting!

Malte,
I suggest you give this patch a try as well to see if it solves your
similar/identical(?) Oops posted on lkml.

Quoted 133 lines · Trond Myklebust

Does the attached patch (against 2.6.22) fix it?

Trond

Quoted 56 lines · Stuart Anderson

We started receiving frequent kernel (2.6.20.11) Oops messages in nfs:nfs_update_inode on a pair of Sun X4600M2 machines once we started mounting an NFS V4 filesystem from a Solaris x86 ZFS server.

Any help in tracking this down would be greatly appreciated.

Thanks.

Jun 22 18:15:49 ldas-grid kernel: Unable to handle kernel NULL pointer dereference at 0000000000000020 RIP: 
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: PGD 3edd83067 PUD 3edd8b067 PMD 0 
Jun 22 18:15:49 ldas-grid kernel: Oops: 0000 [1] SMP 
Jun 22 18:15:49 ldas-grid kernel: CPU 7 
Jun 22 18:15:49 ldas-grid kernel: Modules linked in: nfsd exportfs autofs4 eeprom adm1026 hwmon_vid hwmon i2c_isa i2c_amd756
 i2c_amd8111 nfs lockd nfs_acl sunrpc ipt_REJECT xt_state usb_storage ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tab
les x_tables usbhid dm_mod ohci_hcd ehci_hcd i2c_nforce2 i2c_core e1000 usbcore mptsas scsi_transport_sas mptscsih mptbase s
d_mod scsi_mod
Jun 22 18:15:49 ldas-grid kernel: Pid: 33, comm: events/7 Not tainted 2.6.20.11-CIT #1
Jun 22 18:15:49 ldas-grid kernel: RIP: 0010:[<ffffffff88170989>]  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: RSP: 0018:ffff8103fbc3dc10  EFLAGS: 00010246
Jun 22 18:15:49 ldas-grid kernel: RAX: 0000000000000000 RBX: ffff81035d704ce8 RCX: 0000000000008180
Jun 22 18:15:49 ldas-grid kernel: RDX: ffff8101003cf8c0 RSI: ffff8103ace9c8d0 RDI: ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel: RBP: ffff8103ace9c8d0 R08: 0000000000008180 R09: ffff8103eddf0030
Jun 22 18:15:49 ldas-grid kernel: R10: 0000000000000026 R11: 0000000000000003 R12: ffff81035d704b10
Jun 22 18:15:49 ldas-grid kernel: R13: ffff81035d704ce8 R14: ffff8101fbc3e6c0 R15: ffff8103ace9c8d0
Jun 22 18:15:49 ldas-grid kernel: FS:  00002b526bf797a0(0000) GS:ffff810300141d40(0000) knlGS:00000000f7dbb6c0
Jun 22 18:15:49 ldas-grid kernel: CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
Jun 22 18:15:49 ldas-grid kernel: CR2: 0000000000000020 CR3: 00000003edd89000 CR4: 00000000000006e0
Jun 22 18:15:49 ldas-grid kernel: Process events/7 (pid: 33, threadinfo ffff8103fbc3c000, task ffff8102fbcb90c0)
Jun 22 18:15:49 ldas-grid kernel: Stack:  ffff81035d704ce8 ffff8103ace9c8d0 ffff81035d704da0 ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel:  ffff8101fbc3e6c0 ffffffff88170edb 0000000000000000 ffff8103ace9c800
Jun 22 18:15:49 ldas-grid kernel:  ffff810322664c00 ffffffff881817f0 ffff810376445de0 ffff8101003cf8c0
Jun 22 18:15:49 ldas-grid kernel: Call Trace:
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170edb>] :nfs:nfs_post_op_update_inode+0x4b/0x70
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff881817f0>] :nfs:nfs4_proc_delegreturn+0x160/0x1e0
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff8818e2ae>] :nfs:nfs_do_return_delegation+0x1e/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8816d0e3>] :nfs:nfs_dentry_iput+0x23/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802999a2>] shrink_dcache_for_umount_subtree+0x212/0x270
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80299a53>] shrink_dcache_for_umount+0x53/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288ce9>] generic_shutdown_super+0x19/0x100
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288e29>] kill_anon_super+0x9/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff881724ad>] :nfs:nfs_kill_super+0xd/0x20
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80289046>] deactivate_super+0x76/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a1573>] expire_mount_list+0x133/0x180
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7a0>] :nfs:nfs_expire_automounts+0x0/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a176b>] mark_mounts_for_expiry+0xab/0xc0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7b0>] :nfs:nfs_expire_automounts+0x10/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fd6e>] run_workqueue+0xae/0x160
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80240031>] worker_thread+0x151/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80229490>] default_wake_function+0x0/0x10
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243b79>] kthread+0xd9/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802298cc>] schedule_tail+0x4c/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a998>] child_rip+0xa/0x12
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80219250>] flat_send_IPI_mask+0x0/0x60
Quoted 9 lines
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243aa0>] kthread+0x0/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a98e>] child_rip+0x0/0x12
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: Code: 48 3b 58 20 75 31 48 8b 45 60 48 39 82 b0 00 00 00 48 8d 75 
Jun 22 18:15:50 ldas-grid kernel: RIP  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:50 ldas-grid kernel:  RSP <ffff8103fbc3dc10>
Jun 22 18:15:50 ldas-grid kernel: CR2: 0000000000000020

From: Trond Myklebust <[email protected]>
Date: Tue, 5 Jun 2007 13:26:15 -0400
NFS: Fix nfs_reval_fsid()
Subject: No Subject

We don't need to revalidate the fsid on the root directory. It suffices to revalidate it on the current directory.

Signed-off-by Trond Myklebust <[email protected]>

---

 fs/nfs/dir.c   |    9 ++++-----
 fs/nfs/inode.c |    4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)
fs/nfs/dir.c +4 -5
index 4948ec1..c02a796 100644
@@ -897,14 +897,13 @@ int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd)
 	return (nd->intent.open.flags & O_EXCL) != 0;
 }
 
-static inline int nfs_reval_fsid(struct vfsmount *mnt, struct inode *dir,
-				 struct nfs_fh *fh, struct nfs_fattr *fattr)
+static inline int nfs_reval_fsid(struct inode *dir, const struct nfs_fattr *fattr)
 {
 	struct nfs_server *server = NFS_SERVER(dir);
 
 	if (!nfs_fsid_equal(&server->fsid, &fattr->fsid))
-		/* Revalidate fsid on root dir */
-		return __nfs_revalidate_inode(server, mnt->mnt_root->d_inode);
+		/* Revalidate fsid using the parent directory */
+		return __nfs_revalidate_inode(server, dir);
 	return 0;
 }
 

@@ -946,7 +945,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru
 		res = ERR_PTR(error);
 		goto out_unlock;
 	}
-	error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);
+	error = nfs_reval_fsid(dir, &fattr);
 	if (error < 0) {
 		res = ERR_PTR(error);
 		goto out_unlock;
fs/nfs/inode.c +2 -2
index 23ecf03..7bcb3df 100644
@@ -961,8 +961,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 		goto out_changed;
 
 	server = NFS_SERVER(inode);
-	/* Update the fsid if and only if this is the root directory */
-	if (inode == inode->i_sb->s_root->d_inode
+	/* Update the fsid? */
+	if (S_ISDIR(inode->i_mode)
 			&& !nfs_fsid_equal(&server->fsid, &fattr->fsid))
 		server->fsid = fattr->fsid;
Signature · 2 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

author
#6 lore raw
Quoted 8 lines · Trond Myklebust
Quoted 3 lines · Stuart Anderson

This has patch has now been stable for 5 days on two different machines.

Any thoughts about the "bad sequence-id error"?

I seem to remember that a couple of sources of state corruption were found in the server in and around the 2.6.20 series. Do I remember correctly, Bruce?

In this case Solaris is the server and Linux 2.6.20.14 is the client.

Quoted 172 lines

Cheers
Trond

Quoted 167 lines

Thanks.

Quoted 163 lines · Stuart Anderson

Trond,

This applied cleanly to 2.6.20.14 and so far so good with 2.5hr uptime on each of two machines that both previously had this Oops on an interval of minutes up to 24hr. The statistics are not conclusive yet, but it does boot and I was able to successfully run "make -j 8 boostrap" on the gcc source code using 8 out of 16 CPU-cores on an NFSV4 mount without crashing.

However, the gcc build did generate 19 of the following on this client machine:
NFS: v4 server returned a bad sequence-id error!
Are these serious? How to go about tracking these down?

The server is a Sun X4500 running ZFS on Solaris10 Update 3 and it did not log any error messages during the gcc build.

Very many thanks for incredible turn around a kernel patch--less than 40 minutes from Oops posting to patch posting!

Malte,
I suggest you give this patch a try as well to see if it solves your
similar/identical(?) Oops posted on lkml.

Quoted 133 lines · Trond Myklebust

Does the attached patch (against 2.6.22) fix it?

Trond

Quoted 56 lines · Stuart Anderson

We started receiving frequent kernel (2.6.20.11) Oops messages in nfs:nfs_update_inode on a pair of Sun X4600M2 machines once we started mounting an NFS V4 filesystem from a Solaris x86 ZFS server.

Any help in tracking this down would be greatly appreciated.

Thanks.

Jun 22 18:15:49 ldas-grid kernel: Unable to handle kernel NULL pointer dereference at 0000000000000020 RIP: 
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: PGD 3edd83067 PUD 3edd8b067 PMD 0 
Jun 22 18:15:49 ldas-grid kernel: Oops: 0000 [1] SMP 
Jun 22 18:15:49 ldas-grid kernel: CPU 7 
Jun 22 18:15:49 ldas-grid kernel: Modules linked in: nfsd exportfs autofs4 eeprom adm1026 hwmon_vid hwmon i2c_isa i2c_amd756
 i2c_amd8111 nfs lockd nfs_acl sunrpc ipt_REJECT xt_state usb_storage ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tab
les x_tables usbhid dm_mod ohci_hcd ehci_hcd i2c_nforce2 i2c_core e1000 usbcore mptsas scsi_transport_sas mptscsih mptbase s
d_mod scsi_mod
Jun 22 18:15:49 ldas-grid kernel: Pid: 33, comm: events/7 Not tainted 2.6.20.11-CIT #1
Jun 22 18:15:49 ldas-grid kernel: RIP: 0010:[<ffffffff88170989>]  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:49 ldas-grid kernel: RSP: 0018:ffff8103fbc3dc10  EFLAGS: 00010246
Jun 22 18:15:49 ldas-grid kernel: RAX: 0000000000000000 RBX: ffff81035d704ce8 RCX: 0000000000008180
Jun 22 18:15:49 ldas-grid kernel: RDX: ffff8101003cf8c0 RSI: ffff8103ace9c8d0 RDI: ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel: RBP: ffff8103ace9c8d0 R08: 0000000000008180 R09: ffff8103eddf0030
Jun 22 18:15:49 ldas-grid kernel: R10: 0000000000000026 R11: 0000000000000003 R12: ffff81035d704b10
Jun 22 18:15:49 ldas-grid kernel: R13: ffff81035d704ce8 R14: ffff8101fbc3e6c0 R15: ffff8103ace9c8d0
Jun 22 18:15:49 ldas-grid kernel: FS:  00002b526bf797a0(0000) GS:ffff810300141d40(0000) knlGS:00000000f7dbb6c0
Jun 22 18:15:49 ldas-grid kernel: CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
Jun 22 18:15:49 ldas-grid kernel: CR2: 0000000000000020 CR3: 00000003edd89000 CR4: 00000000000006e0
Jun 22 18:15:49 ldas-grid kernel: Process events/7 (pid: 33, threadinfo ffff8103fbc3c000, task ffff8102fbcb90c0)
Jun 22 18:15:49 ldas-grid kernel: Stack:  ffff81035d704ce8 ffff8103ace9c8d0 ffff81035d704da0 ffff81035d704ce8
Jun 22 18:15:49 ldas-grid kernel:  ffff8101fbc3e6c0 ffffffff88170edb 0000000000000000 ffff8103ace9c800
Jun 22 18:15:49 ldas-grid kernel:  ffff810322664c00 ffffffff881817f0 ffff810376445de0 ffff8101003cf8c0
Jun 22 18:15:49 ldas-grid kernel: Call Trace:
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff88170edb>] :nfs:nfs_post_op_update_inode+0x4b/0x70
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff881817f0>] :nfs:nfs4_proc_delegreturn+0x160/0x1e0
Jun 22 18:15:49 ldas-grid kernel:  [<ffffffff8818e2ae>] :nfs:nfs_do_return_delegation+0x1e/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8816d0e3>] :nfs:nfs_dentry_iput+0x23/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802999a2>] shrink_dcache_for_umount_subtree+0x212/0x270
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80299a53>] shrink_dcache_for_umount+0x53/0x70
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288ce9>] generic_shutdown_super+0x19/0x100
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80288e29>] kill_anon_super+0x9/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff881724ad>] :nfs:nfs_kill_super+0xd/0x20
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80289046>] deactivate_super+0x76/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a1573>] expire_mount_list+0x133/0x180
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7a0>] :nfs:nfs_expire_automounts+0x0/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802a176b>] mark_mounts_for_expiry+0xab/0xc0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8817a7b0>] :nfs:nfs_expire_automounts+0x10/0x40
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fd6e>] run_workqueue+0xae/0x160
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80240031>] worker_thread+0x151/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80229490>] default_wake_function+0x0/0x10
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8023fee0>] worker_thread+0x0/0x190
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243b79>] kthread+0xd9/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff802298cc>] schedule_tail+0x4c/0xb0
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a998>] child_rip+0xa/0x12
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80219250>] flat_send_IPI_mask+0x0/0x60
Quoted 9 lines
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff80243aa0>] kthread+0x0/0x120
Jun 22 18:15:50 ldas-grid kernel:  [<ffffffff8020a98e>] child_rip+0x0/0x12
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: 
Jun 22 18:15:50 ldas-grid kernel: Code: 48 3b 58 20 75 31 48 8b 45 60 48 39 82 b0 00 00 00 48 8d 75 
Jun 22 18:15:50 ldas-grid kernel: RIP  [<ffffffff88170989>] :nfs:nfs_update_inode+0x99/0x5a0
Jun 22 18:15:50 ldas-grid kernel:  RSP <ffff8103fbc3dc10>
Jun 22 18:15:50 ldas-grid kernel: CR2: 0000000000000020

From: Trond Myklebust <[email protected]>
Date: Tue, 5 Jun 2007 13:26:15 -0400
NFS: Fix nfs_reval_fsid()
Subject: No Subject

We don't need to revalidate the fsid on the root directory. It suffices to revalidate it on the current directory.

Signed-off-by Trond Myklebust <[email protected]>

---

 fs/nfs/dir.c   |    9 ++++-----
 fs/nfs/inode.c |    4 ++--
 2 files changed, 6 insertions(+), 7 deletions(-)
fs/nfs/dir.c +4 -5
index 4948ec1..c02a796 100644
@@ -897,14 +897,13 @@ int nfs_is_exclusive_create(struct inode *dir, struct nameidata *nd)
 	return (nd->intent.open.flags & O_EXCL) != 0;
 }
 
-static inline int nfs_reval_fsid(struct vfsmount *mnt, struct inode *dir,
-				 struct nfs_fh *fh, struct nfs_fattr *fattr)
+static inline int nfs_reval_fsid(struct inode *dir, const struct nfs_fattr *fattr)
 {
 	struct nfs_server *server = NFS_SERVER(dir);
 
 	if (!nfs_fsid_equal(&server->fsid, &fattr->fsid))
-		/* Revalidate fsid on root dir */
-		return __nfs_revalidate_inode(server, mnt->mnt_root->d_inode);
+		/* Revalidate fsid using the parent directory */
+		return __nfs_revalidate_inode(server, dir);
 	return 0;
 }
 

@@ -946,7 +945,7 @@ static struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, stru
 		res = ERR_PTR(error);
 		goto out_unlock;
 	}
-	error = nfs_reval_fsid(nd->mnt, dir, &fhandle, &fattr);
+	error = nfs_reval_fsid(dir, &fattr);
 	if (error < 0) {
 		res = ERR_PTR(error);
 		goto out_unlock;
fs/nfs/inode.c +2 -2
index 23ecf03..7bcb3df 100644
@@ -961,8 +961,8 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 		goto out_changed;
 
 	server = NFS_SERVER(inode);
-	/* Update the fsid if and only if this is the root directory */
-	if (inode == inode->i_sb->s_root->d_inode
+	/* Update the fsid? */
+	if (S_ISDIR(inode->i_mode)
 			&& !nfs_fsid_equal(&server->fsid, &fattr->fsid))
 		server->fsid = fattr->fsid;
Signature · 2 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson
Signature · 11 lines
Stuart Anderson  [email protected]
http://www.ligo.caltech.edu/~anderson

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#7 lore raw
Quoted 11 lines · Stuart Anderson
Quoted 8 lines · Trond Myklebust
Quoted 3 lines · Stuart Anderson

This has patch has now been stable for 5 days on two different machines.

Any thoughts about the "bad sequence-id error"?

I seem to remember that a couple of sources of state corruption were found in the server in and around the 2.6.20 series. Do I remember correctly, Bruce?

In this case Solaris is the server and Linux 2.6.20.14 is the client.

Sigh... In that case we'll need a binary tcpdump of the problem (tcpdump -s 9000 -w /tmp/dump.out).

I'd be surprised if we have many cases of sequence id errors left in the client. It has been ages since I saw one.

Trond

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#8 lore raw
In reply to Stuart Anderson
Quoted 10 lines · Stuart Anderson
Quoted 7 lines · Trond Myklebust
Quoted 3 lines · Stuart Anderson

This has patch has now been stable for 5 days on two different machines.

Any thoughts about the "bad sequence-id error"?

I seem to remember that a couple of sources of state corruption were found in the server in and around the 2.6.20 series. Do I remember correctly, Bruce?

In this case Solaris is the server and Linux 2.6.20.14 is the client.

Just a "me too" -- I see loads of these messages on a static NFSv4 home directory mount point to Solaris Nevada b63. Clients are 2.6.21 and above.

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA email;internet:chuck dot lever at nospam oracle dot com title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#9 lore raw
Quoted 6 lines · Chuck Lever
Quoted 5 lines · Stuart Anderson
Quoted 4 lines · Trond Myklebust
Quoted 3 lines · Stuart Anderson

This has patch has now been stable for 5 days on two different machines.

Any thoughts about the "bad sequence-id error"?

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I seem to remember that a couple of sources of state corruption were found in the server in and around the 2.6.20 series. Do I remember correctly, Bruce?

In this case Solaris is the server and Linux 2.6.20.14 is the client.

Just a "me too" -- I see loads of these messages on a static NFSv4 home directory mount point to Solaris Nevada b63. Clients are 2.6.21 and above.

tcpdump please

Trond

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#10 lore raw
In reply to Trond Myklebust
Quoted 8 lines · Trond Myklebust
Quoted 3 lines · Stuart Anderson

This has patch has now been stable for 5 days on two different machines.

Any thoughts about the "bad sequence-id error"?

I seem to remember that a couple of sources of state corruption were found in the server in and around the 2.6.20 series. Do I remember correctly, Bruce?

I don't remember any (and don't see any relevant patches in a quick skim of 'git log fs/nfsd').

Which isn't to say we couldn't have some problem there....

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#11 lore raw
In reply to Stuart Anderson
Quoted 3 lines · On Sat, 23 Jun 2007 14:51:31 -0700 Stuart Anderson <[email protected]>…

Malte,
I suggest you give this patch a try as well to see if it solves your
similar/identical(?) Oops posted on lkml.

I did not encounter problems with this patch yet. I will report if this changes.

Signature · 5 lines
---------------------------------------
Malte Schröder
[email protected]
ICQ# 68121508
---------------------------------------

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs