Skip to contentSkip to conversation

drivers/mtd/devices/at91_dataflash26.c

DISCUSSION David Brownell 3 participants 6 messages May 10, 2007 – Jun 25, 2007 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 7 lines · David Brownell
Quoted 5 lines · Hans-Jürgen Koch
Quoted 3 lines

the m25p80 driver
was pretty close to working with those Atmel devices too ... most of the commands are identical.

Thanks for that hint, I'll have a look at the data sheet.

Any progress on that? I looked again, and yes most commands are identical.

- That driver relies on an AT91-only SPI stack that's not going upstream, instead of drivers/spi/atmel_spi.c;

- Driver can't even be selected on kernel.org kernel (!!);

- The m25p80 driver will need at most minor tweaks to handle those AT26 (and AT25) series chips;

So 340ea370c2ce89d1c15fbf785460f2f74314ce58 should be reverted.

- Dave

#4 lore raw

David,

Quoted 15 lines · David Brownell
Quoted 7 lines · David Brownell
Quoted 5 lines · Hans-Jürgen Koch
Quoted 3 lines

the m25p80 driver
was pretty close to working with those Atmel devices too ... most of the commands are identical.

Thanks for that hint, I'll have a look at the data sheet.

Any progress on that? I looked again, and yes most commands are identical.

- That driver relies on an AT91-only SPI stack that's not going upstream, instead of drivers/spi/atmel_spi.c;

Quoted 6 lines

- Driver can't even be selected on kernel.org kernel (!!);

- The m25p80 driver will need at most minor tweaks to handle those AT26 (and AT25) series chips;

So 340ea370c2ce89d1c15fbf785460f2f74314ce58 should be reverted.

We look into this and fix the problem. There is no need to revert it right now. It does no harm and we remove it with the merge into the m25p80 driver, ok ?

tglx

#5 lore raw
Quoted 12 lines · Thomas Gleixner

David,

Quoted 9 lines · David Brownell
Quoted 7 lines · David Brownell
Quoted 5 lines · Hans-Jürgen Koch
Quoted 3 lines

the m25p80 driver
was pretty close to working with those Atmel devices too ... most of the commands are identical.

Thanks for that hint, I'll have a look at the data sheet.

Quoted 8 lines
Quoted 4 lines

Any progress on that? I looked again, and yes most commands are identical...

So 340ea370c2ce89d1c15fbf785460f2f74314ce58 should be reverted.

We look into this and fix the problem. There is no need to revert it right now. It does no harm and we remove it with the merge into the m25p80 driver, ok ?

Sounds like a plan ... but I'd still revert ASAP.

Either way, I'd hope it's all resolved before we
get very far into the 2.6.22-rc series.

- Dave

#6 lore raw
In reply to David Brownell

Am Donnerstag 10 Mai 2007 22:07 schrieb David Brownell:

Quoted 15 lines · David Brownell
Quoted 7 lines · Hans-Jürgen Koch
Quoted 6 lines
Quoted 4 lines

the m25p80 driver
was pretty close to working with those Atmel devices too ... most of the commands are identical.

Thanks for that hint, I'll have a look at the data sheet.

Any progress on that? I looked again, and yes most commands are identical.

- That driver relies on an AT91-only SPI stack that's not going upstream, instead of drivers/spi/atmel_spi.c;

Quoted 9 lines

- Driver can't even be selected on kernel.org kernel (!!);

- The m25p80 driver will need at most minor tweaks to handle those AT26 (and AT25) series chips;

So 340ea370c2ce89d1c15fbf785460f2f74314ce58 should be reverted.

- Dave

Dave,
sorry for not responding earlier, I was busy with lots of other stuff. At the moment, I'm working on this again. I had a bit of trouble getting a recent kernel working on my test system, but that seems to be OK now.

You'll hear from me soon.

Thanks,
Hans

#7 lore raw
Quoted 12 lines · Hans-Jürgen Koch

Am Donnerstag 10 Mai 2007 22:07 schrieb David Brownell:

Quoted 11 lines · David Brownell
Quoted 7 lines · Hans-Jürgen Koch
Quoted 6 lines
Quoted 4 lines

the m25p80 driver
was pretty close to working with those Atmel devices too ... most of the commands are identical.

Thanks for that hint, I'll have a look at the data sheet.

Any progress on that? I looked again, and yes most commands are identical.

Still true. :)

For that and a boatload of other SPI flash chips. I'm wondering just what that JEDEC standard covers; either it's got useful command coverage, or vendors of SPI flash noticed that converging command sets is a Good Thing.

Quoted 9 lines
Quoted 9 lines

- That driver relies on an AT91-only SPI stack that's not going upstream, instead of drivers/spi/atmel_spi.c;

- Driver can't even be selected on kernel.org kernel (!!);

- The m25p80 driver will need at most minor tweaks to handle those AT26 (and AT25) series chips;

So 340ea370c2ce89d1c15fbf785460f2f74314ce58 should be reverted.

Also still true...

Quoted 11 lines
Quoted 3 lines

- Dave

Dave,
sorry for not responding earlier, I was busy with lots of other stuff. At the moment, I'm working on this again. I had a bit of trouble getting a recent kernel working on my test system, but that seems to be OK now.

You'll hear from me soon.

Ping? Have a look at

    http://lists.infradead.org/pipermail/linux-mtd/2007-June/018706.html

which depends on the resent mutex conversion patch in the "previous message" link of that patch.

That should highlight more reasons why at91_dataflash should be reverted ASAP. I'd expect you would be able to just drop that in and have it work ... unless you're seeing that nCS0 issue built out of at91rm9200 errata, in which case there's an experiment I can forward to you. :)

- Dave

#8 lore raw

Am Montag 25 Juni 2007 04:51 schrieb David Brownell:

Quoted 9 lines · Hans-Jürgen Koch
Quoted 8 lines

Am Donnerstag 10 Mai 2007 22:07 schrieb David Brownell:

Quoted 7 lines · David Brownell
Quoted 6 lines · Hans-Jürgen Koch
Quoted 5 lines
Quoted 4 lines

the m25p80 driver
was pretty close to working with those Atmel devices too ... most of the commands are identical.

Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line

Thanks for that hint, I'll have a look at the data sheet.

Any progress on that? I looked again, and yes most commands are identical.

Still true. :)

I came to the same conclusion.

Quoted 10 lines

For that and a boatload of other SPI flash chips. I'm wondering just what that JEDEC standard covers; either it's got useful command coverage, or vendors of SPI flash noticed that converging command sets is a Good Thing.

Quoted 3 lines
Quoted 3 lines

- That driver relies on an AT91-only SPI stack that's not going upstream, instead of drivers/spi/atmel_spi.c;

Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

- Driver can't even be selected on kernel.org kernel (!!);

- The m25p80 driver will need at most minor tweaks to handle those AT26 (and AT25) series chips;

So 340ea370c2ce89d1c15fbf785460f2f74314ce58 should be reverted.

Also still true...

I agree.

Quoted 12 lines
Quoted 12 lines
Quoted 5 lines

- Dave

Dave,
sorry for not responding earlier, I was busy with lots of other stuff. At the moment, I'm working on this again. I had a bit of trouble getting a recent kernel working on my test system, but that seems to be OK now.

Quoted 5 lines
Quoted 1 line

You'll hear from me soon.

Ping? Have a look at

    http://lists.infradead.org/pipermail/linux-mtd/2007-June/018706.html

Great! Didn't notice that one.

Quoted 7 lines

which depends on the resent mutex conversion patch in the "previous message" link of that patch.

That should highlight more reasons why at91_dataflash should be reverted ASAP. I'd expect you would be able to just drop that in and have it work ...

Looks like that.

Quoted 3 lines

unless you're seeing that nCS0
issue built out of at91rm9200 errata, in which case there's an experiment I can forward to you. :)

I'll look at that ASAP. I had tons of other work on my desk and last time I tried, SPI was broken on my device. It would be OK for me if you threw out that at91_dataflash/at91_dataflash26 stuff now.

Thanks,
Hans