Skip to contentSkip to conversation

scripts/decodecode: fix for /bin/sh

PATCH In review Randy Dunlap 2 participants 2 messages Jun 28, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts/decodecode: fix for /bin/sh

From: Randy Dunlap <[email protected]>

Convert substring expressions to be sh-compatible.

Tested by Arne Georg Gleditsch <[email protected]>

---
 scripts/decodecode |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/decodecode +2 -2
@@ -28,7 +28,7 @@ if [ $marker -eq 0 ]; then
 fi
 
 if [ $marker -ne 0 ]; then
-	beforemark=${code:0:$((marker - 1))}
+	beforemark=`echo "$code" | cut -c-$((${marker} - 1))`
 	echo -n "	.byte 0x" > $T.s
 	echo $beforemark | sed -e 's/ /,0x/g' >> $T.s
 	as -o $T.o $T.s
@@ -36,7 +36,7 @@ if [ $marker -ne 0 ]; then
 	rm $T.o $T.s
 
 # and fix code at-and-after marker
-	code=${code:$marker}
+	code=`echo "$code" | cut -c$((${marker} + 1))-`
 fi
 
 code=`echo $code | sed -e 's/ [<(]/ /;s/[>)] / /;s/ /,0x/g'`
#1 lore raw

Re: [PATCH -mm] scripts/decodecode: fix for /bin/sh (cc your enemies)

* Date: Thu, 28 Jun 2007 10:51:37 -0700

I didn't want to respond to your prev. messages, because i felt, that they will be mis-read again as my original NAK (ASCII negative acknowledgement symbol, no other "fsky" meaning inside). Also i wanted to come up with more nice tool, like colour support (like ls' or quilt diff'), CROSS toolchains support, nicer sed magic in implementation, etc.

All this was in my short original comment. Yes that message was short and somebody even thought i was not so polite -- from my POV that was concrete description of the bug, with clear goodwill to help. Therefore, IMNSHO one *must* suppress any personal angriness before replying to (very simple and small in this case) technical issues.

Now i feel the same as Bartlomiej described in the discussion of regression tracking, that got even quoted in LWN prev. kernel page [0].

I will not say i'm sad, i will say it's awesome to have so much attention to silly issues like /bin/sh->/bin/bash. By the way it was Linus who pointed out *my*, possibly bad, usage of GNU find extensions in the Makefile near you. After that, i started to check at least busybox's tools before i will go to GNU's luxury of features. And as you may noticed, Ubuntu even defaults shell like dash in its setup, while in Debian i have questions and/or `update-alternatives'.

It's obvious for me now, why that regression tracking thread has ended without useful implementation ideas or counter-arguments against Debian BTS....

[0] The Kernel page with link to "Cc those reviwers, who, you think, are

    your enemies" <http://lwn.net/Articles/238283/>
Quoted 5 lines

From: Randy Dunlap <[email protected]>

Convert substring expressions to be sh-compatible.

Tested by Arne Georg Gleditsch <[email protected]>

____