get rid of CONFIG_DISABLE_CONSOLE_SUSPEND
Subsystems (6)
RFC 1/1 get rid of CONFIG_DISABLE_CONSOLE_SUSPEND
Hi!
What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?
Pavel
Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at all, instead, we should automatically keep console alive when possible.
drivers/char/lp.c +8 -9
@@ -144,7 +144,7 @@ static unsigned int lp_count = 0;static struct class *lp_class;#ifdef CONFIG_LP_CONSOLE -static struct parport *console_registered;// initially NULL +static struct parport *console_registered;#endif /* CONFIG_LP_CONSOLE */ #undef LP_DEBUG
@@ -749,8 +749,8 @@ #endif /* console on line printer *//* --- initialisation code ------------------------------------- */ static int parport_nr[LP_NO ] = { [0 ...LP_NO -1 ] =LP_PARPORT_UNSPEC }; -static char *parport[LP_NO ] = {NULL , }; -static int reset =0 ; +static char *parport[LP_NO ]; +static int reset;module_param_array (parport, charp,NULL ,0 );module_param (reset, bool,0 );
@@ -758,10 +758,10 @@ module_param(reset, bool, 0);#ifndef MODULE static int __init lp_setup (char *str) { -static int parport_ptr;// initially zero +static int parport_ptr;int x; -if (get_option (&str, &x)) { +if (get_option (&str, &x)) {if (x ==0 ) {/* disable driver on "lp=" or "lp=0" */ parport_nr[0 ] =LP_PARPORT_OFF ;
@@ -808,7 +808,7 @@ static int lp_register(int nr, struct pa#ifdef CONFIG_LP_CONSOLE if (!nr) {if (port->modes &PARPORT_MODE_SAFEININT ) { -register_console (&lpcons); +register_console (&lpcons); console_registered = port;printk (KERN_INFO "lp%d: console ready\n" ,CONSOLE_LP ); }else
@@ -824,8 +824,7 @@ static void lp_attach (struct parport *p {unsigned int i; -switch (parport_nr[0 ]) - { +switch (parport_nr[0 ]) {case LP_PARPORT_UNSPEC :case LP_PARPORT_AUTO : if (parport_nr[0] == LP_PARPORT_AUTO &&
@@ -856,7 +855,7 @@ static void lp_detach (struct parport *p/* Write this some day. */ #ifdef CONFIG_LP_CONSOLE if (console_registered == port) { -unregister_console (&lpcons); +unregister_console (&lpcons); console_registered =NULL ; }#endif /* CONFIG_LP_CONSOLE */
drivers/net/netconsole.c +5 -3
@@ -75,7 +75,7 @@ static void write_msg(struct console *colocal_irq_save (flags); -for (left = len; left; ) { +for (left = len; left; ) { frag =min (left,MAX_PRINT_CHUNK );netpoll_send_udp (&np, msg, frag); msg += frag;
@@ -103,10 +103,10 @@ static int init_netconsole(void) {int err; -if (strlen (config)) +if (strlen (config))option_setup (config); -if (!configured) { +if (!configured) {printk ("netconsole: not configured, aborting\n" );return 0 ; }
@@ -115,6 +115,7 @@ static int init_netconsole(void)if (err)return err; + disable_console_on_suspend++;register_console (&netconsole);printk (KERN_INFO "netconsole: network logging started\n" );return 0 ;
@@ -123,6 +124,7 @@ static int init_netconsole(void)static void cleanup_netconsole (void ) {unregister_console (&netconsole); + disable_console_on_suspend--;netpoll_cleanup (&np); }
drivers/serial/serial_core.c +0 -4
@@ -1934,12 +1934,10 @@ int uart_suspend_port(struct uart_drivermutex_lock (&state->mutex); -#ifdef CONFIG_DISABLE_CONSOLE_SUSPEND if (uart_console (port)) {mutex_unlock (&state->mutex);return 0 ; } -#endif if (state->info && state->info->flags &UIF_INITIALIZED ) {const struct uart_ops *ops = port->ops;
@@ -1982,12 +1980,10 @@ int uart_resume_port(struct uart_drivermutex_lock (&state->mutex); -#ifdef CONFIG_DISABLE_CONSOLE_SUSPEND if (uart_console (port)) {mutex_unlock (&state->mutex);return 0 ; } -#endif uart_change_pm (state,0 );
include/linux/console.h +2 -5
@@ -120,14 +120,11 @@ extern void console_stop(struct consoleextern void console_start (struct console *);extern int is_console_locked (void ); -#ifndef CONFIG_DISABLE_CONSOLE_SUSPEND +extern int disable_console_on_suspend; +/* Suspend and resume console messages over PM events */ extern void suspend_console (void );extern void resume_console (void ); -#else -static inline void suspend_console (void ) {} -static inline void resume_console (void ) {} -#endif /* CONFIG_DISABLE_CONSOLE_SUSPEND */ int mda_console_init (void );void prom_con_init (void );
kernel/power/Kconfig +2 -13
@@ -37,17 +37,6 @@ config PM_DEBUG code. This is helpful when debugging and reporting various PM bugs, like suspend support. -config DISABLE_CONSOLE_SUSPEND - bool "Keep console(s) enabled during suspend/resume (DANGEROUS)" - depends on PM && PM_DEBUG - default n - ---help--- - This option turns off the console suspend mechanism that prevents - debug messages from reaching the console during the suspend/resume - operations. This may be helpful when debugging device drivers' - suspend/resume routines, but may itself lead to problems, for example - if netconsole is used. - config PM_TRACE bool "Suspend/resume event tracing" depends on PM && PM_DEBUG && X86_32 && EXPERIMENTAL
@@ -57,8 +46,8 @@ config PM_TRACE RTC across reboots, so that you can debug a machine that just hangs during suspend (or more commonly, during resume). - To use this debugging feature you should attempt to suspend the machine, - then reboot it, then run + To use this debugging feature you should attempt to suspend the + machine, then reboot it, then run dmesg -s 1000000 | grep 'hash matches'
kernel/printk.c +13 -7
@@ -726,7 +726,8 @@ int __init add_preferred_console(char *nreturn 0 ; } -#ifndef CONFIG_DISABLE_CONSOLE_SUSPEND +int disable_console_on_suspend; +/** * suspend_console - suspend the console subsystem *
@@ -734,17 +735,22 @@ #ifndef CONFIG_DISABLE_CONSOLE_SUSPEND*/ void suspend_console (void ) { -printk ("Suspending console(s)\n" ); -acquire_console_sem (); - console_suspended =1 ; +if (disable_console_on_suspend) { +printk ("Suspending console(s)\n" ); +acquire_console_sem (); + console_suspended =1 ; + } }void resume_console (void ) { - console_suspended =0 ; -release_console_sem (); +if (console_suspended) { +BUG_ON (!disable_console_on_suspend); + console_suspended =0 ; +release_console_sem (); + } } -#endif /* CONFIG_DISABLE_CONSOLE_SUSPEND */ +/** * acquire_console_sem - lock the console system for exclusive use.
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 5 lines · Pavel Machek
Hi!
What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?
Violent agreement from me. Not taking down serial console would help a lot too. Storing dmesg from the image-loading kernel during resume from hibernation would be another nice addition.
Signature · 1 line
tejun
Hi,
Quoted 18 lines · Pavel Machek
Hi!
What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?
PavelKill
CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at all, instead, we should automatically keep console alive when possible.Signed-off-by Pavel Machek <[email protected]>drivers/char/lp.c +0
-0
drivers/char/lp.c static unsigned int lp_count = 0; · line 148
Quoted 6 lines
drivers/char/lp.c +1
-1@@ -144,7 +144,7 @@ static unsigned int lp_count = 0;static struct class *lp_class;#ifdef CONFIG_LP_CONSOLE -static struct parport *console_registered;// initially NULL +static struct parport *console_registered;#endif /* CONFIG_LP_CONSOLE */
Could you please avoid fixing things like this, white space etc. in this patch? It would be easier to read ...
Quoted 203 lines
drivers/char/lp.c +7
-8#undef LP_DEBUG@@ -749,8 +749,8 @@ #endif /* console on line printer *//* --- initialisation code ------------------------------------- */ static int parport_nr[LP_NO ] = { [0 ...LP_NO -1 ] =LP_PARPORT_UNSPEC }; -static char *parport[LP_NO ] = {NULL , }; -static int reset =0 ; +static char *parport[LP_NO ]; +static int reset;module_param_array (parport, charp,NULL ,0 );module_param (reset, bool,0 );@@ -758,10 +758,10 @@ module_param(reset, bool, 0);#ifndef MODULE static int __init lp_setup (char *str) { -static int parport_ptr;// initially zero +static int parport_ptr;int x; -if (get_option (&str, &x)) { +if (get_option (&str, &x)) {if (x ==0 ) {/* disable driver on "lp=" or "lp=0" */ parport_nr[0 ] =LP_PARPORT_OFF ;@@ -808,7 +808,7 @@ static int lp_register(int nr, struct pa#ifdef CONFIG_LP_CONSOLE if (!nr) {if (port->modes &PARPORT_MODE_SAFEININT ) { -register_console (&lpcons); +register_console (&lpcons); console_registered = port;printk (KERN_INFO "lp%d: console ready\n" ,CONSOLE_LP ); }else @@ -824,8 +824,7 @@ static void lp_attach (struct parport *p {unsigned int i; -switch (parport_nr[0 ]) - { +switch (parport_nr[0 ]) {case LP_PARPORT_UNSPEC :case LP_PARPORT_AUTO : if (parport_nr[0] == LP_PARPORT_AUTO &&@@ -856,7 +855,7 @@ static void lp_detach (struct parport *p/* Write this some day. */ #ifdef CONFIG_LP_CONSOLE if (console_registered == port) { -unregister_console (&lpcons); +unregister_console (&lpcons); console_registered =NULL ; }#endif /* CONFIG_LP_CONSOLE */ drivers/net/netconsole.c +5
-3@@ -75,7 +75,7 @@ static void write_msg(struct console *colocal_irq_save (flags); -for (left = len; left; ) { +for (left = len; left; ) { frag =min (left,MAX_PRINT_CHUNK );netpoll_send_udp (&np, msg, frag); msg += frag;@@ -103,10 +103,10 @@ static int init_netconsole(void) {int err; -if (strlen (config)) +if (strlen (config))option_setup (config); -if (!configured) { +if (!configured) {printk ("netconsole: not configured, aborting\n" );return 0 ; }@@ -115,6 +115,7 @@ static int init_netconsole(void)if (err)return err; + disable_console_on_suspend++;register_console (&netconsole);printk (KERN_INFO "netconsole: network logging started\n" );return 0 ;@@ -123,6 +124,7 @@ static int init_netconsole(void)static void cleanup_netconsole (void ) {unregister_console (&netconsole); + disable_console_on_suspend--;netpoll_cleanup (&np); }drivers/serial/serial_core.c +0
-4@@ -1934,12 +1934,10 @@ int uart_suspend_port(struct uart_drivermutex_lock (&state->mutex); -#ifdef CONFIG_DISABLE_CONSOLE_SUSPEND if (uart_console (port)) {mutex_unlock (&state->mutex);return 0 ; } -#endif if (state->info && state->info->flags &UIF_INITIALIZED ) {const struct uart_ops *ops = port->ops;@@ -1982,12 +1980,10 @@ int uart_resume_port(struct uart_drivermutex_lock (&state->mutex); -#ifdef CONFIG_DISABLE_CONSOLE_SUSPEND if (uart_console (port)) {mutex_unlock (&state->mutex);return 0 ; } -#endif uart_change_pm (state,0 );include/linux/console.h +2
-5@@ -120,14 +120,11 @@ extern void console_stop(struct consoleextern void console_start (struct console *);extern int is_console_locked (void ); -#ifndef CONFIG_DISABLE_CONSOLE_SUSPEND +extern int disable_console_on_suspend; +/* Suspend and resume console messages over PM events */ extern void suspend_console (void );extern void resume_console (void ); -#else -static inline void suspend_console (void ) {} -static inline void resume_console (void ) {} -#endif /* CONFIG_DISABLE_CONSOLE_SUSPEND */ int mda_console_init (void );void prom_con_init (void );kernel/power/Kconfig +2
-13@@ -37,17 +37,6 @@ config PM_DEBUG code. This is helpful when debugging and reporting various PM bugs, like suspend support. -config DISABLE_CONSOLE_SUSPEND - bool "Keep console(s) enabled during suspend/resume (DANGEROUS)" - depends on PM && PM_DEBUG - default n - ---help--- - This option turns off the console suspend mechanism that prevents - debug messages from reaching the console during the suspend/resume - operations. This may be helpful when debugging device drivers' - suspend/resume routines, but may itself lead to problems, for example - if netconsole is used. - config PM_TRACE bool "Suspend/resume event tracing" depends on PM && PM_DEBUG && X86_32 && EXPERIMENTAL@@ -57,8 +46,8 @@ config PM_TRACE RTC across reboots, so that you can debug a machine that just hangs during suspend (or more commonly, during resume). - To use this debugging feature you should attempt to suspend the machine, - then reboot it, then run + To use this debugging feature you should attempt to suspend the + machine, then reboot it, then run dmesg -s 1000000 | grep 'hash matches'kernel/printk.c +5
-4@@ -726,7 +726,8 @@ int __init add_preferred_console(char *nreturn 0 ; } -#ifndef CONFIG_DISABLE_CONSOLE_SUSPEND +int disable_console_on_suspend; +/** * suspend_console - suspend the console subsystem * @@ -734,17 +735,22 @@ #ifndef CONFIG_DISABLE_CONSOLE_SUSPEND*/ void suspend_console (void ) { -printk ("Suspending console(s)\n" ); -acquire_console_sem (); - console_suspended =1 ; +if (disable_console_on_suspend) { +printk ("Suspending console(s)\n" ); +acquire_console_sem ();
kernel/printk.c #ifndef CONFIG_DISABLE_CONSOLE_SUSPEND · line 748
Quoted 10 lines
kernel/printk.c +4
-2+ console_suspended =1 ; + } }void resume_console (void ) { - console_suspended =0 ; -release_console_sem (); +if (console_suspended) { +BUG_ON (!disable_console_on_suspend);
Isn't that a bit extreme?
kernel/printk.c #ifndef CONFIG_DISABLE_CONSOLE_SUSPEND · line 756
Quoted 9 lines
kernel/printk.c +4
-1+ console_suspended =0 ; +release_console_sem (); + } } -#endif /* CONFIG_DISABLE_CONSOLE_SUSPEND */ +/** * acquire_console_sem - lock the console system for exclusive use.
I generally agree with the idea, but the patch needs a clean up, IMHO.
Greetings,
Rafael
Signature · 1 line
"Premature optimization is the root of all evil." - Donald Knuth
(CC'ing Linus, since disabling consoles during suspend was his idea IIRC)
Quoted 23 lines · Rafael J. Wysocki
Hi,
Quoted 20 lines · Pavel Machek
Hi!
What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?
PavelKill
CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at all, instead, we should automatically keep console alive when possible.Signed-off-by Pavel Machek <[email protected]>drivers/char/lp.c +0
-0@@ -144,7 +144,7 @@ static unsigned int lp_count = 0;static struct class *lp_class;
Quoted 7 lines
drivers/char/lp.c static unsigned int lp_count = 0; · line 148
Quoted 4 lines
drivers/char/lp.c +1
-1#ifdef CONFIG_LP_CONSOLE -static struct parport *console_registered;// initially NULL +static struct parport *console_registered;#endif /* CONFIG_LP_CONSOLE */ Could you please avoid fixing things like this, white space etc. in this patch? It would be easier to read ...
Yes.
Quoted 1 line
I generally agree with the idea, but the patch needs a clean up, IMHO.
However, we don't know which consoles are safe to stay alive during suspend. Generally, defaulting to suspending them all is not a bad idea IMHO. And IIRC it is plain luck if a serial console survives the suspend (or was the serial code fixed recently?)
So i do not care too much, but my / Frank's patch was shorter :-) and safer.
Signature · 6 lines
Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Quoted 34 lines · Stefan Seyfried
(CC'ing Linus, since disabling consoles during suspend was his idea IIRC)
Quoted 23 lines · Rafael J. Wysocki
Hi,
Quoted 20 lines · Pavel Machek
Hi!
What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?
PavelKill
CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at all, instead, we should automatically keep console alive when possible.Signed-off-by Pavel Machek <[email protected]>drivers/char/lp.c +0
-0@@ -144,7 +144,7 @@ static unsigned int lp_count = 0;static struct class *lp_class;Quoted 7 lines
drivers/char/lp.c static unsigned int lp_count = 0; · line 148
Quoted 4 lines
drivers/char/lp.c +1
-1#ifdef CONFIG_LP_CONSOLE -static struct parport *console_registered;// initially NULL +static struct parport *console_registered;#endif /* CONFIG_LP_CONSOLE */ Could you please avoid fixing things like this, white space etc. in this patch? It would be easier to read ...
Quoted 8 lines
Yes.
Quoted 1 line
I generally agree with the idea, but the patch needs a clean up, IMHO.
However, we don't know which consoles are safe to stay alive during suspend. Generally, defaulting to suspending them all is not a bad idea IMHO. And IIRC it is plain luck if a serial console survives the suspend (or was the serial code fixed recently?)
Well, I don't think so, but I'm not sure.
The VGA/fb console also should be off during suspend (not necessarily during hibernation, though). IIRC, that's what caused Linus to introduce the suspending of consoles after all.
Quoted 1 line
So i do not care too much, but my / Frank's patch was shorter :-) and safer.
I'm not sure which way to go. On the one hand, I agree that we should rather fix the consoles so that we know which one is suspend-safe and which is not and disable the unsafe ones, but on the other hand we are not there yet and it _sometimes_ is useful not to suspend a console even if we know that it will break things.
Greetings,
Rafael
Signature · 1 line
"Premature optimization is the root of all evil." - Donald Knuth
Quoted 13 lines · Rafael J. Wysocki
Quoted 5 lines · Stefan Seyfried
However, we don't know which consoles are safe to stay alive during suspend. Generally, defaulting to suspending them all is not a bad idea IMHO. And IIRC it is plain luck if a serial console survives the suspend (or was the serial code fixed recently?)
Well, I don't think so, but I'm not sure.
The VGA/fb console also should be off during suspend (not necessarily during hibernation, though). IIRC, that's what caused Linus to introduce the suspending of consoles after all.
Quoted 7 lines
Quoted 1 line
So i do not care too much, but my / Frank's patch was shorter :-) and safer.
I'm not sure which way to go. On the one hand, I agree that we should rather fix the consoles so that we know which one is suspend-safe and which is not and disable the unsafe ones, but on the other hand we are not there yet and it _sometimes_ is useful not to suspend a console even if we know that it will break things.
This is what my / Frank's patch was aimed at: give the user the ability to (painlessly, without rebuilding the kernel) debug suspend problems. Keep the default safe, like Linus likes it (consoles suspended), but give the user a switch to make it unsafe (consoles not suspended) for the sake of debugging.
Of course, fixing up all console drivers is an option that i'd very much like to see. It is however debatable if it is really worth the effort. If it works with consoles suspended, the user does not care. If it doesn't, he turns on debugging (knowing, or being told that this will break using netconsole).
I strongly oppose Pavel's approach to "declare all console drivers as nonbroken except netconsole". Even if he has not seen any failures apart from netconsole, in general i had the impression that suspending consoles did help. At least suspend works on many more machines than half a year ago, and i'd not be surprised if this was partly due to suspending the consoles.
Remember that wrt. suspend "i did not get a bugreport" very often just means "people tried it, it did not work, but they expected that and just turned
away". It does not mean "it just works for everyone".
Signature · 6 lines
Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Hi!
Quoted 18 lines
Quoted 18 lines
What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?
PavelKill
CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at all, instead, we should automatically keep console alive when possible.Signed-off-by Pavel Machek <[email protected]>drivers/char/lp.c +0
-0@@ -144,7 +144,7 @@ static unsigned int lp_count = 0;static struct class *lp_class;
Quoted 7 lines
drivers/char/lp.c static unsigned int lp_count = 0; · line 148
Quoted 4 lines
drivers/char/lp.c +1
-1#ifdef CONFIG_LP_CONSOLE -static struct parport *console_registered;// initially NULL +static struct parport *console_registered;#endif /* CONFIG_LP_CONSOLE */ Could you please avoid fixing things like this, white space etc. in this patch? It would be easier to read ...
Yep, sorry, it should be separate patch. I hope the idea is still simple enough.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 28 lines · Pavel Machek
Hi!
Quoted 18 lines
Quoted 18 lines
What about this? (Only compile tested, but looks pretty obvious to me). Something like this should get us rid of ugly option, and still solve debugging problems... Hmmm?
PavelKill
CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at all, instead, we should automatically keep console alive when possible.Signed-off-by Pavel Machek <[email protected]>drivers/char/lp.c +0
-0@@ -144,7 +144,7 @@ static unsigned int lp_count = 0;static struct class *lp_class;Quoted 7 lines
drivers/char/lp.c static unsigned int lp_count = 0; · line 148
Quoted 4 lines
drivers/char/lp.c +1
-1#ifdef CONFIG_LP_CONSOLE -static struct parport *console_registered;// initially NULL +static struct parport *console_registered;#endif /* CONFIG_LP_CONSOLE */ Could you please avoid fixing things like this, white space etc. in this patch? It would be easier to read ...
Quoted 2 lines
Yep, sorry, it should be separate patch. I hope the idea is still simple enough.
Yes, but I'm not sure if netconsole is the only one that we will want to have disabled. Moreover, what if someone wants to use the netconsole regardless of the fact that it can crash the box?
Greetings,
Rafael
Signature · 1 line
"Premature optimization is the root of all evil." - Donald Knuth
Hi!
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
drivers/char/lp.c static unsigned int lp_count = 0; · line 148
Quoted 11 lines
drivers/char/lp.c +1
-1@@ -144,7 +144,7 @@ static unsigned int lp_count = 0;static struct class *lp_class;#ifdef CONFIG_LP_CONSOLE -static struct parport *console_registered;// initially NULL +static struct parport *console_registered;#endif /* CONFIG_LP_CONSOLE */ Could you please avoid fixing things like this, white space etc. in this patch? It would be easier to read ...
Quoted 4 lines
Quoted 2 lines
Yep, sorry, it should be separate patch. I hope the idea is still simple enough.
Yes, but I'm not sure if netconsole is the only one that we will want to have
Well, netconsole is the only one we know of.
Quoted 2 lines
disabled. Moreover, what if someone wants to use the netconsole regardless of the fact that it can crash the box?
He'll have to edit the sources at that point. I'd prefer not to have too many "please crash the box" options.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi,
Quoted 5 lines · Pavel Machek
Hi!
Quoted 1 line
Yes, but I'm not sure if netconsole is the only one that we will want to have
Well, netconsole is the only one we know of.
AFAIR it is plain luck that serial console sometimes works.
I repeat: "no bugreport" is not the same as "it works for everyone" wrt. suspend. It seems (i unfortunately have no numbers, since my machines always worked without suspending the consoles) as if suspending consoles generally helped reliability of suspend.
Quoted 5 lines
Quoted 2 lines
disabled. Moreover, what if someone wants to use the netconsole regardless of the fact that it can crash the box?
He'll have to edit the sources at that point. I'd prefer not to have too many "please crash the box" options.
So should we remove sysrq-C?
This is a debugging option. Only root can set it. Its purpose is to make "machine hangs during suspend" (even before it goes to sleep) debuggable. It will only be set if the machine crashes anyways.
(We can taint the kernel if this control is set, if that helps you).
Signature · 6 lines
Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)