Skip to contentSkip to conversation

Creation of version_autogenerated.h only triggered for new and different contents...

PATCH New Carsten Schlote 3 participants 5 messages Jun 29, 2007 – Jul 1, 2007 Kbuild

lore
Share & tools
lore

Carsten Schlote

author
#0 lore raw

PATCH 1/1 Creation of version_autogenerated.h only triggered for new and different contents...

Hi,

below a simple patch for the make rule, which creates the version_autogenerated.h file. Instead of just updating this file any time make is started, now the file is checked for different contents. If it differs, the version header is updated, otherwise not.

This saves unnessesary rebuilds of several files in the tree.

Regards
Carsten

---------

Makefile +0 -0
index c52b21b..7999870 100755
@@ -290,11 +290,13 @@ $(U_BOOT_NAND):   $(NAND_SPL) $(obj)u-boot.bin
                cat $(obj)nand_spl/u-boot-spl-16k.bin $(obj)u-boot.bin >

$(obj)u-boot-nand.bin

version:
- @echo -n "#define U_BOOT_VERSION \"U-Boot " >
$(VERSION_FILE); \
- echo -n "$(U_BOOT_VERSION)" >> $(VERSION_FILE); \
+ @echo -n "#define U_BOOT_VERSION \"U-Boot " >
$(VERSION_FILE).tmp; \

+               echo -n "$(U_BOOT_VERSION)" >> $(VERSION_FILE).tmp; \
                echo -n $(shell $(CONFIG_SHELL)

$(TOPDIR)/tools/setlocalversion \
- $(TOPDIR)) >> $(VERSION_FILE); \
- echo "\"" >> $(VERSION_FILE)
+ $(TOPDIR)) >> $(VERSION_FILE).tmp; \
+ echo "\"" >> $(VERSION_FILE).tmp
+ @diff --brief $(VERSION_FILE) $(VERSION_FILE).tmp || cp
$(VERSION_FILE).tmp $(VERSION_FILE)
+ @rm $(VERSION_FILE).tmp

gdbtools:

                $(MAKE) -C tools/gdb all || exit 1
#1 lore raw

PATCH 1/1 Creation of version_autogenerated.h only triggered for new and different contents...

Quoted 6 lines · Carsten Schlote

below a simple patch for the make rule, which creates the version_autogenerated.h file. Instead of just updating this file any time make is started, now the file is checked for different contents. If it differs, the version header is updated, otherwise not.

This saves unnessesary rebuilds of several files in the tree.

your e-mail client munged the patch ... but ignoring that, ive posted a patch for this issue before, but no one seems to respond
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/29424
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070629/82a47a2c/attachment.pgp

author
#2 lore raw

PATCH 1/1 Creation of version_autogenerated.h only triggered for new and different contents...

Hi

Quoted 1 line

for this issue before, but no one seems to respond

That's my problem as well :-( And this is just one of many trivial changes that could be done to improve things...

Maybe we should wait for u2boot and check if this development handles things correctly.

Regards
Carsten

#3 lore raw

PATCH 1/1 Creation of version_autogenerated.h only triggered for new and different contents...

In reply to Carsten Schlote
Quoted 11 lines · Carsten Schlote

Hi,

below a simple patch for the make rule, which creates the version_autogenerated.h file. Instead of just updating this file any time make is started, now the file is checked for different contents. If it differs, the version header is updated, otherwise not.

This saves unnessesary rebuilds of several files in the tree.

Regards
Carsten

Looks good to me. I'll apply it to my tree, but I need a signed-off-by line from you first.

Cheers,
g.

Quoted 44 lines

---------

Makefile +0 -0
index c52b21b..7999870 100755
@@ -290,11 +290,13 @@ $(U_BOOT_NAND):   $(NAND_SPL) $(obj)u-boot.bin
                cat $(obj)nand_spl/u-boot-spl-16k.bin $(obj)u-boot.bin >

$(obj)u-boot-nand.bin

version:
- @echo -n "#define U_BOOT_VERSION \"U-Boot " >
$(VERSION_FILE); \

Makefile +1 -1
-               echo -n "$(U_BOOT_VERSION)" >> $(VERSION_FILE); \
+               @echo -n "#define U_BOOT_VERSION \"U-Boot " >

$(VERSION_FILE).tmp; \

+               echo -n "$(U_BOOT_VERSION)" >> $(VERSION_FILE).tmp; \
                echo -n $(shell $(CONFIG_SHELL)

$(TOPDIR)/tools/setlocalversion \

Makefile +3 -2
-                        $(TOPDIR)) >> $(VERSION_FILE); \
-               echo "\"" >> $(VERSION_FILE)
+                        $(TOPDIR)) >> $(VERSION_FILE).tmp; \
+               echo "\"" >> $(VERSION_FILE).tmp
+               @diff --brief $(VERSION_FILE) $(VERSION_FILE).tmp || cp

$(VERSION_FILE).tmp $(VERSION_FILE)
+ @rm $(VERSION_FILE).tmp

gdbtools:

                $(MAKE) -C tools/gdb all || exit 1

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Signature · 4 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195
author
#4 lore raw

PATCH 1/1 Creation of version_autogenerated.h only triggered for new and different contents...

Hi,

as Evolution now starts to f**k up ASCII Mails I attached the fixed patch as attachment this time. Might not not work due to list limitations, but worth a try. Otherwise I might start to use mutt again ;-&

Regards
Carsten

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Creation-of-version_autogenerated.h-only-triggered-for-new-contents.txt
Type: application/mbox
Size: 1603 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070701/ef4e11df/attachment.bin