frv: fix fallout from "remove sched.h from mm.h" patch
PATCH 1/1 frv: fix fallout from "remove sched.h from mm.h" patch
---
include/asm-frv/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/asm-frv/pgtable.h +1 -1
@@ -25,7 +25,7 @@#include <linux/slab.h> #include <linux/list.h> #include <linux/spinlock.h> -struct mm_struct ; +#include <linux/sched.h> struct vm_area_struct ;#endif
Quoted 9 lines · On Thu, 28 Jun 2007 18:09:21 +0400 Alexey Dobriyan <[email protected]> wrote:
Signed-off-by Alexey Dobriyan <[email protected]>---
include/asm-frv/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/asm-frv/pgtable.h line 31
Quoted 8 lines
include/asm-frv/pgtable.h +1
-1@@ -25,7 +25,7 @@#include <linux/slab.h> #include <linux/list.h> #include <linux/spinlock.h> -struct mm_struct ; +#include <linux/sched.h> struct vm_area_struct ;#endif
Please provide changelogs.
I assume this patch fixes some build error or something.
Quoted 23 lines · Andrew Morton
Quoted 9 lines · On Thu, 28 Jun 2007 18:09:21 +0400 Alexey Dobriyan <[email protected]> wrote:
Signed-off-by Alexey Dobriyan <[email protected]>---
include/asm-frv/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/asm-frv/pgtable.h line 31
Quoted 8 lines
include/asm-frv/pgtable.h +1
-1@@ -25,7 +25,7 @@#include <linux/slab.h> #include <linux/list.h> #include <linux/spinlock.h> -struct mm_struct ; +#include <linux/sched.h> struct vm_area_struct ;#endif Please provide changelogs.
Quoted 1 line
I assume this patch fixes some build error or something.
i actually asked about this on either the janitors or newbies list
the other day -- one of the early examples from the LDD3 device drivers book which built fine all this time suddenly stopped building, until i explicitly included <linux/sched.h> to be able to dereference a pointer to "task_struct":
/home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type /home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type
clearly, until now, that header file was being picked up
*somewhere*, but not now. so i'm guessing there's going to be code all over the place that suddenly needs to add that inclusion of sched.h.
rday
Signature · 7 lines
======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ========================================================================
Quoted 32 lines · Robert P. J. Day
Quoted 23 lines · Andrew Morton
Quoted 9 lines · On Thu, 28 Jun 2007 18:09:21 +0400 Alexey Dobriyan <[email protected]> wrote:
Signed-off-by Alexey Dobriyan <[email protected]>---
include/asm-frv/pgtable.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/asm-frv/pgtable.h line 31
Quoted 8 lines
include/asm-frv/pgtable.h +1
-1@@ -25,7 +25,7 @@#include <linux/slab.h> #include <linux/list.h> #include <linux/spinlock.h> -struct mm_struct ; +#include <linux/sched.h> struct vm_area_struct ;#endif Please provide changelogs.
Quoted 1 line
I assume this patch fixes some build error or something.
i actually asked about this on either the janitors or newbies list
the other day -- one of the early examples from the LDD3 device drivers book which built fine all this time suddenly stopped building, until i explicitly included <linux/sched.h> to be able to dereference a pointer to "task_struct":
Quoted 5 lines
/home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type/home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete typeclearly, until now, that header file was being picked up
*somewhere*,
from include/linux/mm.h , yes
Quoted 1 line
but not now.
dammit!
Quoted 3 lines
so i'm guessing there's going to be code
all over the place that suddenly needs to add that inclusion ofsched.h.
this is the last known to me bit of compile breakage that was caused by commit e8edc6e03a5c8562dc70a6d969f732bdb355a7e7 aka
"[PATCH] Detach sched.h from mm.h"
And after you'll check diffstat and build current kernel for different archs yourself, I hope you'll take that "all over the place" back.
P.S.: Al may know more because he is building different set of configs, but I
was larted about frv only.
Quoted 23 lines · Alexey Dobriyan
Quoted 11 lines · Robert P. J. Day
i actually asked about this on either the janitors or newbies
list the other day -- one of the early examples from the LDD3 device drivers book which built fine all this time suddenly stopped building, until i explicitly included <linux/sched.h> to be able to dereference a pointer to "task_struct":
/home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type/home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete typeclearly, until now, that header file was being picked up
*somewhere*,from
include/linux/mm.h, yesQuoted 1 line
but not now.
dammit!
Quoted 2 lines
so i'm guessing there's going to be code all over the place that suddenly needs to add that inclusion of
sched.h.
Quoted 7 lines
this is the last known to me bit of compile breakage that was caused by commit
e8edc6e03a5c8562dc70a6d969f732bdb355a7e7aka
"[PATCH] Detachsched.hfrommm.h"And after you'll check diffstat and build current kernel for different archs yourself, I hope you'll take that "all over the place" back.
i didn't mean code *in the kernel* necessarily, merely code representing out-of-tree loadable drivers that will now need to include sched.h that didn't need it before. such as that very example out of LDD3.
sorry that i wasn't more clear about that.
rday
Signature · 7 lines
======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ========================================================================
Quoted 3 lines · On Fri, 29 Jun 2007 09:10:52 -0400 (EDT) "Robert P. J. Day"…
Quoted 3 lines
Please provide changelogs.
I assume this patch fixes some build error or something.
I am still awaiting a description of what this patch does.
Quoted 8 lines
i actually asked about this on either the janitors or newbies list
the other day -- one of the early examples from the LDD3 device drivers book which built fine all this time suddenly stopped building, until i explicitly included <linux/sched.h> to be able to dereference a pointer to "task_struct":
/home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type/home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type
I'll proceed, assuming that the patch fixes the above build errors.