: Add linux/pagemap.h to asm/tlb.h
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 30 lines · Linux Kernel Mailing List
Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f462a1a5de06503fd247186b91d4205ac1cf1ba Commit: 9f462a1a5de06503fd247186b91d4205ac1cf1ba Parent: a357b8f42e7b85e2522c3ad2b29b685bc28743b4 Author: Alexey Dobriyan <[email protected]> AuthorDate: Thu Jun 28 21:25:31 2007 -0700 Committer: David S. Miller <[email protected]> CommitDate: Thu Jun 28 21:25:31 2007 -0700[SPARC64]: Add
linux/pagemap.htoasm/tlb.hAs seen on sparc64-allnoconfig:
CC
arch/sparc64/mm/tlb.o
In file included fromarch/sparc64/mm/tlb.c:19:
include/asm/tlb.h: In function 'tlb_flush_mmu':
include/asm/tlb.h:60: warning: implicit declaration of function 'release_pages'include/asm/tlb.h: In function 'tlb_remove_page':
include/asm/tlb.h:92: warning: implicit declaration of function 'page_cache_release'Signed-off-by Alexey Dobriyan <[email protected]>Signed-off-by David S. Miller <[email protected]>--- include/asm-sparc64/tlb.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/asm-sparc64/tlb.h +0
-0
include/asm-sparc64/tlb.h line 8
Quoted 7 lines
include/asm-sparc64/tlb.h +1
-0@@ -2,6 +2,7 @@#define _SPARC64_TLB_H#include <linux/swap.h> +#include <linux/pagemap.h> #include <asm/pgalloc.h> #include <asm/tlbflush.h> #include <asm/mmu_context.h>
How is the guideline these days?
If a header file exists in both linux/ and asm-$(ARCH)/ then always include the linux/ veriant??
If this is the guideline then the better fix would be to let tlb.c include the linux/ variant.
But I dunno - it seems to be a bit inconsistent.
Sam