ide: ide_start_power_step() fix WRT disabling DMA

PATCH In review Bartlomiej Zolnierkiewicz 1 participant 1 message Jun 30, 2007 libata

Share & tools

Bartlomiej Zolnierkiewicz

author

2007-06-30 19:00 UTC #0 lore raw

PATCH 3/15 ide: ide_start_power_step() fix WRT disabling DMA

* Do the same thing as probe_hwif() and always disable DMA so chipset DMA enabled bit gets cleared (if the drive doesn't support DMA ide_set_dma() won't try to tune it anyway).

* Add TODO comment about respecting ->using_dma setting.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 drivers/ide/ide-io.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/ide/ide-io.c +3 -2

Index: b/drivers/ide/ide-io.c
===================================================================
@@ -219,11 +219,12 @@ static ide_startstop_t ide_start_power_s
 		 * we could be smarter and check for current xfer_speed
 		 * in struct drive etc...
 		 */
-		if ((drive->id->capability & 1) == 0)
-			break;
 		if (drive->hwif->ide_dma_check == NULL)
 			break;
 		drive->hwif->dma_off_quietly(drive);
+		/*
+		 * TODO: respect ->using_dma setting
+		 */
 		ide_set_dma(drive);
 		break;
 	}