Skip to contentSkip to conversation

it821x: fix incorrect SWDMA mask

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 3 messages Jul 2, 2007 – Jul 3, 2007 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 1/1 it821x: fix incorrect SWDMA mask

SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always fail (due to sanity check in ->speedproc) and result in PIO being tuned.

* Fix incorrect SWDMA mask so core code won't try these modes and will just tune PIO if no other DMA modes are available.

* Bump driver version.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
for 2.6.22-final

 drivers/ide/pci/it821x.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/ide/pci/it821x.c +1 -2
Index: b/drivers/ide/pci/it821x.c
===================================================================
@@ -1,6 +1,6 @@
 
 /*
- * linux/drivers/ide/pci/it821x.c		Version 0.15	Jun 2 2007
+ * linux/drivers/ide/pci/it821x.c		Version 0.16	Jul 3 2007
  *
  * Copyright (C) 2004		Red Hat <[email protected]>
  * Copyright (C) 2007		Bartlomiej Zolnierkiewicz

@@ -660,7 +660,6 @@ static void __devinit init_hwif_it821x(i
 
 	hwif->ultra_mask = 0x7f;
 	hwif->mwdma_mask = 0x07;
-	hwif->swdma_mask = 0x07;
 
 	hwif->ide_dma_check = &it821x_config_drive_for_dma;
 	if (!(hwif->udma_four))
Acked-by on v1 1/1
#1 lore raw

Hello.

Quoted 9 lines · Bartlomiej Zolnierkiewicz

SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always fail (due to sanity check in ->speedproc) and result in PIO being tuned.

* Fix incorrect SWDMA mask so core code won't try these modes and will just tune PIO if no other DMA modes are available.

* Bump driver version.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Sergei Shtylyov <[email protected]>

MBR, Sergei

author
#2 lore raw
Quoted 7 lines · Sergei Shtylyov

Hello.

Quoted 2 lines · Bartlomiej Zolnierkiewicz

SWDMA modes are unsupported by it821x. Attempts to tune SWDMA modes always fail (due to sanity check in ->speedproc) and result in PIO being tuned.

Quoted 8 lines
Quoted 6 lines

* Fix incorrect SWDMA mask so core code won't try these modes and will just tune PIO if no other DMA modes are available.

* Bump driver version.

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Sergei Shtylyov <[email protected]>

added