Skip to contentSkip to conversation

finding the author of the patches in ext4-patch-queue

PATCH Aneesh Kumar K.V 5 participants 5 messages Jul 4, 2007 – Jul 5, 2007

lore
Share & tools
lore

Aneesh Kumar K.V

author
#0 lore raw

Hi Mingming,

With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch. I guess we can solve this by adding From: < author name > in the patches. This will make sure when the patches get applied to linus tree we have the right author.

with the below diff to noextent_mount option patch i get the below history when applying the patches using stgit via stgit --import --series

ext4_noextent_mount_opt.patch +1 -0
index c349afb..e9a8d6f 100644
@@ -1,3 +1,4 @@
+From: Mingming Cao <[email protected]>

Add a mount option to turn off extents.

Signed-off-by Mingming Cao <[email protected]>
$ git log commit f89bcb4ca03dde8b12d3c722483aae84c3d2072d
Author: Mingming Cao <[email protected]>
Date:   Wed Jul 4 10:32:19 2007 +0530

Add a mount option to turn off extents.

Signed-off-by Mingming Cao <[email protected]>

Without the change: I get below

commit 4a4f228f99e263767fe5b395cdb843a5c5d083fe

Author: Aneesh Kumar K.V <[email protected]>
Date:   Wed Jul 4 10:05:19 2007 +0530

Turn on extents feature by default in ext4 filesystem. User could use -o noextents to turn it off.

Signed-off-by Mingming Cao <[email protected]>

-aneesh

#1 lore raw
Quoted 6 lines · Aneesh Kumar K.V

Hi Mingming,

With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch. I guess we can solve this by adding From: < author name > in the patches. This will make sure when the patches get applied to linus tree we have the right author.

Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch queue.

Mingming

Quoted 40 lines

with the below diff to noextent_mount option patch i get the below history when applying the patches using stgit via stgit --import --series

ext4_noextent_mount_opt.patch +1 -0
index c349afb..e9a8d6f 100644
@@ -1,3 +1,4 @@
+From: Mingming Cao <[email protected]>
 Add a mount option to turn off extents.
 
 Signed-off-by: Mingming Cao <[email protected]>

$ git log 
commit f89bcb4ca03dde8b12d3c722483aae84c3d2072d
Author: Mingming Cao <[email protected]>
Date:   Wed Jul 4 10:32:19 2007 +0530

Add a mount option to turn off extents.

Signed-off-by Mingming Cao <[email protected]>

Without the change: I get below

commit 4a4f228f99e263767fe5b395cdb843a5c5d083fe

Author: Aneesh Kumar K.V <[email protected]>
Date:   Wed Jul 4 10:05:19 2007 +0530

Turn on extents feature by default in ext4 filesystem. User could use -o noextents to turn it off.

Signed-off-by Mingming Cao <[email protected]>
ext4_noextent_mount_opt.patch +0 -2
-aneesh
-

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 8 lines · Mingming Cao
Quoted 4 lines · Aneesh Kumar K.V

With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch. I guess we can solve this by adding From: < author name > in the patches. This will make sure when the patches get applied to linus tree we have the right author.

Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch queue.

You may as well add "Signed-off-by: <author>", since that is the standard way to do this. If you have any questions about who wrote a particular CFS patch I can tell you.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

#3 lore raw
Quoted 7 lines · Andreas Dilger
Quoted 6 lines · Mingming Cao
Quoted 4 lines · Aneesh Kumar K.V

With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch. I guess we can solve this by adding From: < author name > in the patches. This will make sure when the patches get applied to linus tree we have the right author.

Quoted 6 lines
Quoted 2 lines

Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch queue.

You may as well add "Signed-off-by: <author>", since that is the standard way to do this. If you have any questions about who wrote a particular CFS patch I can tell you.

You should never add someone else's Signed-off-by without being explicitly asked to do so.

Shaggy

Signature · 2 lines
David Kleikamp
IBM Linux Technology Center
#4 lore raw
In reply to Andreas Dilger
Quoted 7 lines · Andreas Dilger
Quoted 6 lines · Mingming Cao
Quoted 4 lines · Aneesh Kumar K.V

With respect to ext4-patch-queue it is kind of difficult to find who wrote the patch. I guess we can solve this by adding From: < author name > in the patches. This will make sure when the patches get applied to linus tree we have the right author.

Quoted 6 lines
Quoted 2 lines

Thanks, Aneesh, I will add From: <authro> for all patches in ext4 patch queue.

You may as well add "Signed-off-by: <author>", since that is the standard way to do this. If you have any questions about who wrote a particular CFS patch I can tell you.

In general the first Signed-off-by: is the author, yes. I believe what Aneesh is talking about is formatting the patches so that when they are pulled into git, "git log" shows the correct author information.

- Ted