Skip to contentSkip to conversation

Sky Cpu and Nexus: check for create_proc_entry ret code

PATCH In review Cyrill Gorcunov 1 participant 1 message Jul 5, 2007 Char and misc drivers

lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 4/4 Sky Cpu and Nexus: check for create_proc_entry ret code

This patch adds checking of create_proc_entry call to prevent possible NULL pointer usage.

Signed-off-by Cyrill Gorcunov <[email protected]>

---

 drivers/misc/hdpuftrs/hdpu_nexus.c |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)
drivers/misc/hdpuftrs/hdpu_nexus.c +12 -2
index 01bc917..cc81853 100644
@@ -78,10 +78,20 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
 	}
 
 	hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, &proc_root);
-	hdpu_slot_id->read_proc = hdpu_slot_id_read;
+	if (!hdpu_slot_id) {
+		printk(KERN_WARNING "sky_nexus: "
+		       "Unable to create proc dir entry: sky_slot_id\n");
+	} else {
+		hdpu_slot_id->read_proc = hdpu_slot_id_read;
+	}
 
 	hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, &proc_root);
-	hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
+	if (!hdpu_chassis_id) {
+		printk(KERN_WARNING "sky_nexus: "
+		       "Unable to create proc dir entry: sky_chassis_id\n");
+	} else {
+		hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
+	}
 
 	return 0;
 }