Skip to contentSkip to conversation

Sky Cpu: use C99 style for struct init

PATCH In review Cyrill Gorcunov 2 participants 3 messages Jul 5, 2007 – Jul 6, 2007 Char and misc drivers

lore
Share & tools
lore

Cyrill Gorcunov

author
#0 lore raw

PATCH 1/1 Sky Cpu: use C99 style for struct init

This patch change structure item init
format to C99.

Signed-off-by Cyrill Gorcunov <[email protected]>

---

The patch is over my prev patch named:

[PATCH 1/4] Sky Cpu and Nexus: code style improvement

 drivers/misc/hdpuftrs/hdpu_cpustate.c |   24 ++++++++++++------------
 1 files changed, 12 insertions(+), 12 deletions(-)
drivers/misc/hdpuftrs/hdpu_cpustate.c +12 -12
index 51e4963..cc33f24 100644
@@ -171,21 +171,21 @@ static struct platform_driver hdpu_cpustate_driver = {
  *	The various file operations we support.
  */
 static const struct file_operations cpustate_fops = {
-      owner:	THIS_MODULE,
-      open:	cpustate_open,
-      release:	cpustate_release,
-      read:	cpustate_read,
-      write:	cpustate_write,
-      fasync:	NULL,
-      poll:	NULL,
-      ioctl:	NULL,
-      llseek:	no_llseek,
+      .owner	= THIS_MODULE,
+      .open	= cpustate_open,
+      .release	= cpustate_release,
+      .read	= cpustate_read,
+      .write	= cpustate_write,
+      .fasync	= NULL,
+      .poll	= NULL,
+      .ioctl	= NULL,
+      .llseek	= no_llseek,
 };
 
 static struct miscdevice cpustate_dev = {
-	MISC_DYNAMIC_MINOR,
-	"sky_cpustate",
-	&cpustate_fops,
+	.minor	= MISC_DYNAMIC_MINOR,
+	.name	= "sky_cpustate",
+	.fops	= &cpustate_fops,
 };
 
 static int hdpu_cpustate_probe(struct platform_device *pdev)
#1 lore raw

drivers/misc/hdpuftrs/hdpu_cpustate.c static struct platform_driver hdpu_cpustate_driver = { · line 181

Quoted 3 lines · Cyrill Gorcunov
drivers/misc/hdpuftrs/hdpu_cpustate.c +3 -0
+      .fasync	= NULL,
+      .poll	= NULL,
+      .ioctl	= NULL,

you can remove those since C99 automaticly initialize missing fields to 0.

Cheers,

Signature · 1 line
Vincent Hanquez
author
#2 lore raw

[Vincent Hanquez - Fri, Jul 06, 2007 at 11:21:00AM +0200]

| On Thu, Jul 05, 2007 at 09:59:10PM +0400, Cyrill Gorcunov wrote:
| > +      .fasync	= NULL,
| > +      .poll	= NULL,
| > +      .ioctl	= NULL,
| 
| you can remove those since C99 automaticly initialize missing fields to 0.
| 
| Cheers,
| -- 
| Vincent Hanquez
|

ok, thanks
Cyrill