Skip to contentSkip to conversation

DLM must depend on SYSFS

2.6.22 regression fix Adrian Bunk 2 participants 4 messages Jul 7, 2007 Distributed lock manager (DLM)

lore
Share & tools
lore
#0 lore raw

The dependency of DLM on SYSFS got lost in
commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:

<-- snip -->

...
LD .tmp_vmlinux1
fs/built-in.o: In function `dlm_lockspace_init':
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/fs/dlm/lockspace.c:231: undefined reference to kernel_subsys' fs/built-in.o: In function configfs_init':
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/fs/configfs/mount.c:143: undefined reference to `kernel_subsys' make[1]: *** [.tmp_vmlinux1] Error 1

<-- snip -->

---

fs/dlm/Kconfig renamed from fs/dlm/Kconfig.old +1 -1
@@ -3,7 +3,7 @@
 
 config DLM
 	tristate "Distributed Lock Manager (DLM)"
-	depends on IPV6 || IPV6=n
+	depends on SYSFS && (IPV6 || IPV6=n)
 	select CONFIGFS_FS
 	select IP_SCTP
 	help
#1 lore raw
Quoted 4 lines · Adrian Bunk

The dependency of DLM on SYSFS got lost in
commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:

Hmm. Shouldn't we make that a "select", the way we already do for CONFIGFS_FS?

Linus

#2 lore raw
Quoted 10 lines · Linus Torvalds
Quoted 4 lines · Adrian Bunk

The dependency of DLM on SYSFS got lost in
commit 6ed7257b46709e87d79ac2b6b819b7e0c9184998 resulting in the following compile error with CONFIG_DLM=y, CONFIG_SYSFS=n:

Hmm. Shouldn't we make that a "select", the way we already do for CONFIGFS_FS?

"select" is more user friendly while "depends on" makes it easier to disable options.

Usually I'm for the usage of "select" in such cases, but since this is with CONFIG_EMBEDDED=y where users can be expected to know better what they are doing I'd say a "depends on" is fine.

CONFIGFS_FS as a helper for some few file systems is also a different situation from SYSFS that is a dependency of much more options.

Quoted 1 line

Linus

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 4 lines · Adrian Bunk

Usually I'm for the usage of "select" in such cases, but since this is with CONFIG_EMBEDDED=y where users can be expected to know better what they are doing I'd say a "depends on" is fine.

Fair enough.

Linus