cdparanoia not setting count and/or reply_len properly
Hi all :)
I know, this has been treated on the list before (year 2005) but
without any real solution I'm aware of.
I'm running kernel 2.6.20.14, and I have an ATAPI DVD writer that I
use with an IDE-to-USB adapter, so it appears as an SCSI drive to the kernel.
Anytime I rip anything with it, the log fills with the same message:
some numbers about a certain number of bytes and the old friend message that I've put in the subject.
I assume that the warning makes sense, but the fact is that my log
is full with the same message, the ripping is correct (so cdparanoia is working OK WRT ripping) and if weren't for the printk_ratelimit, the system will freeze.
I don't know if cdparanoia should be fixed, but certainly the
warning could be issued only if CONFIG_SCSI_VERBOSE is set. This way you will have the message if something goes wrong and you want more info, but in cases where the warning is harmless your log will be clean...
Anyway, this message is not for make suggestions, but for asking for
information: why is this warning happening? naugthy cdparanoia? naughty kernel? I'm a bit confused and I want to use my external DVD drive for ripping from time to time, to "exercise" it...
Thanks a lot in advance :)
Raúl Núñez de Arenas Coronado
Signature · 2 lines
Linux Registered User 88736 | http://www.dervishd.net It's my PC and I'll cry if I want to... RAmen!
DervishD wrote at lkml:
Quoted 23 lines
Hi all :)
I know, this has been treated on the list before (year 2005) but
without any real solution I'm aware of.I'm running kernel 2.6.20.14, and I have an ATAPI DVD writer that I
use with an IDE-to-USB adapter, so it appears as an SCSI drive to the kernel.Anytime I rip anything with it, the log fills with the same message:
some numbers about a certain number of bytes and the old friend message that I've put in the subject.I assume that the warning makes sense, but the fact is that my log
is full with the same message, the ripping is correct (so cdparanoia is working OK WRT ripping) and if weren't for theprintk_ratelimit, the system will freeze.I don't know if cdparanoia should be fixed, but certainly the
warning could be issued only ifCONFIG_SCSI_VERBOSEis set. This way you will have the message if something goes wrong and you want more info, but in cases where the warning is harmless your log will be clean...
Quoted 9 lines
Anyway, this message is not for make suggestions, but for asking for
information: why is this warning happening? naugthy cdparanoia? naughty kernel? I'm a bit confused and I want to use my external DVD drive for ripping from time to time, to "exercise" it...Thanks a lot in advance :)
Raúl Núñez de Arenas Coronado
This question is better asked at lsml. (Therefore I'm quoting in full.)
Signature · 7 lines
Stefan Richter -=====-=-=== -=== -=--- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 29 lines · Stefan Richter
DervishD wrote at lkml:
Quoted 28 lines
Hi all :)
I know, this has been treated on the list before (year 2005) but
without any real solution I'm aware of.I'm running kernel 2.6.20.14, and I have an ATAPI DVD writer that I
use with an IDE-to-USB adapter, so it appears as an SCSI drive to the kernel.Anytime I rip anything with it, the log fills with the same message:
some numbers about a certain number of bytes and the old friend message that I've put in the subject.I assume that the warning makes sense, but the fact is that my log
is full with the same message, the ripping is correct (so cdparanoia is working OK WRT ripping) and if weren't for theprintk_ratelimit, the system will freeze.I don't know if cdparanoia should be fixed, but certainly the
warning could be issued only ifCONFIG_SCSI_VERBOSEis set. This way you will have the message if something goes wrong and you want more info, but in cases where the warning is harmless your log will be clean...Anyway, this message is not for make suggestions, but for asking for
information: why is this warning happening? naugthy cdparanoia? naughty kernel? I'm a bit confused and I want to use my external DVD drive for ripping from time to time, to "exercise" it...
Quoted 6 lines
Quoted 4 lines
Thanks a lot in advance :)
Raúl Núñez de Arenas Coronado
This question is better asked at lsml. (Therefore I'm quoting in full.)
In Fedora 7 I see this:
# cdparanoia --version cdparanoia III release 9.8 (March 23, 2001) (C) 2001 Monty <[email protected]> and Xiphophorus
Report bugs to [email protected]
http://www.xiph.org/paranoia/
So, given that date, lk 2.4.2 was out but it was probably a bit early to start using the sg version 3 interface which first appeared in lk 2.4.1 . So that "lets annoy the user" message was added by someone who got burnt by the old sg version 2 interface and decided people needed to be warned. The warning comes from this code is sg.c :
/*
* SG_DXFER_TO_FROM_DEV is functionally equivalent to SG_DXFER_FROM_DEV,
* but is is possible that the app intended SG_DXFER_TO_DEV, because the
re
* is a non-zero input_size, so emit a warning.
*/
if (hp->dxfer_direction == SG_DXFER_TO_FROM_DEV)
if (printk_ratelimit())
printk(KERN_WARNING
"sg_write: data in/out %d/%d bytes for SCSI comma
nd 0x%x--"
"guessing data in;\n" KERN_WARNING " "
"program %s not setting count and/or reply_len pr
operly\n",
old_hdr.reply_len - (int)SZ_SG_HEADER, input_size, (unsigned int) cmnd[0], current->comm);
That code wasn't written be me and I would gladly remove it. For anyone who has read the sg driver documentation, SG_DXFER_TO_FROM_DEV implies a _read_ from the device. The reason SG_DXFER_TO_FROM_DEV exists is for backward compatibility to the sg version 1 interface. It was a hack to get around the fact that the SCSI subsystem didn't report short reads (what folks should use 'resid' for) back in those days.
It is probably about time that cdparanoia was updated ...
Doug Gilbert
Hi Douglas :)
* Douglas Gilbert <[email protected]> dixit:
Quoted 10 lines
Quoted 9 lines
Quoted 9 lines
I don't know if cdparanoia should be fixed, but certainly the
warning could be issued only ifCONFIG_SCSI_VERBOSEis set. This way you will have the message if something goes wrong and you want more info, but in cases where the warning is harmless your log will be clean...Anyway, this message is not for make suggestions, but for asking for
information: why is this warning happening? naugthy cdparanoia? naughty kernel? I'm a bit confused and I want to use my external DVD drive for ripping from time to time, to "exercise" it...
Quoted 5 lines
In Fedora 7 I see this:
# cdparanoia --version cdparanoia III release 9.8 (March 23, 2001) (C) 2001 Monty <[email protected]> and Xiphophorus
Same version here.
Quoted 6 lines
So, given that date, lk 2.4.2 was out but it was probably a bit early to start using the sg version 3 interface which first appeared in lk 2.4.1 . So that "lets annoy the user" message was added by someone who got burnt by the old sg version 2 interface and decided people needed to be warned. The warning comes from this code is
sg.c:
OK, grand. So it's cdparanoia's fault.
Quoted 9 lines
/*
*SG_DXFER_TO_FROM_DEVis functionally equivalent toSG_DXFER_FROM_DEV,
* but is is possible that the app intendedSG_DXFER_TO_DEV, because the
re
* is a non-zeroinput_size, so emit a warning.
*/
if (hp->dxfer_direction==SG_DXFER_TO_FROM_DEV)
if (printk_ratelimit())
printk(KERN_WARNING
Quoted 8 lines
"
sg_write: data in/out %d/%d bytes for SCSI comma
nd 0x%x--"
"guessing data in;\n"KERN_WARNING" "
"program %s not setting count and/orreply_lenpr
operly\n",
old_hdr.reply_len - (int)SZ_SG_HEADER,input_size, (unsigned int) cmnd[0],current->comm);
Yes, I did read the code, and I didn't find any reason for it to
exist, but I didn't understand the purpose of SG_DXFER_TO_FROM_DEV. Thanks for explaining this :))
Quoted 1 line
It is probably about time that cdparanoia was updated ...
I think the same, but given that it works, Monty probably doesn't
have much motivation to update it. I don't know if the problem resides in the cdparanoia program itself (so using the DAE problem from cdrkit will fix the issue) or in the paranoia library. In this case, the problem will affect any program using the library.
Anyway, if you need any testing, just tell :)
Thanks a lot!
Raúl Núñez de Arenas Coronado
Signature · 2 lines
Linux Registered User 88736 | http://www.dervishd.net It's my PC and I'll cry if I want to... RAmen!
Hi Stefan :)
* Stefan Richter <[email protected]> dixit:
Quoted 11 lines
Quoted 9 lines
I don't know if cdparanoia should be fixed, but certainly the
warning could be issued only ifCONFIG_SCSI_VERBOSEis set. This way you will have the message if something goes wrong and you want more info, but in cases where the warning is harmless your log will be clean...Anyway, this message is not for make suggestions, but for asking for
information: why is this warning happening? naugthy cdparanoia? naughty kernel? I'm a bit confused and I want to use my external DVD drive for ripping from time to time, to "exercise" it...This question is better asked at lsml. (Therefore I'm quoting in full.)
First time I hear about that list, sorry O:))) Thanks a lot for
forwarding, Stefan :)
Raúl Núñez de Arenas Coronado
Signature · 2 lines
Linux Registered User 88736 | http://www.dervishd.net It's my PC and I'll cry if I want to... RAmen!