Skip to contentSkip to conversation

the scheduled i2c-rpx removal

PATCH In review Adrian Bunk 2 participants 3 messages Jul 9, 2007 – Jul 12, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 the scheduled i2c-rpx removal

This patch contains the scheduled removal of the i2c-rpx driver.

---

 Documentation/feature-removal-schedule.txt |    8 -
 Documentation/i2c/summary                  |    1 
 drivers/i2c/algos/Kconfig                  |    4 
 drivers/i2c/busses/Kconfig                 |    5 -
 drivers/i2c/busses/Makefile                |    1 
 drivers/i2c/busses/i2c-rpx.c               |  101 ---------------------
 6 files changed, 120 deletions(-)
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +0 -8
@@ -285,14 +285,6 @@
 
 ---------------------------
 
-What:	i2c-rpx driver
-When:	June 2007
-Why:	Broken. It depends on i2c-algo-8xx which has never been in the
-	mainline kernel.
-Who:	Jean Delvare <[email protected]>
-
----------------------------
-
 What:	legacy RTC drivers (under drivers/i2c/chips)
 When:	November 2007
 Why:	Obsolete. We have a RTC subsystem with better drivers.
drivers/i2c/busses/Kconfig renamed from drivers/i2c/busses/Kconfig.old +0 -5
@@ -391,11 +391,6 @@
 	  This support is also available as a module.  If so, the module 
 	  will be called i2c-prosavage.
 
-config I2C_RPXLITE
-	tristate "Embedded Planet RPX Lite/Classic support"
-	depends on RPXLITE || RPXCLASSIC
-	select I2C_ALGO8XX
-
 config I2C_S3C2410
 	tristate "S3C2410 I2C Driver"
 	depends on ARCH_S3C2410
drivers/i2c/algos/Kconfig renamed from drivers/i2c/algos/Kconfig.old +0 -4
@@ -34,10 +34,6 @@
 	  This support is also available as a module.  If so, the module 
 	  will be called i2c-algo-pca.
 
-config I2C_ALGO8XX
-	tristate "MPC8xx CPM I2C interface"
-	depends on 8xx
-
 config I2C_ALGO_SGI
 	tristate "I2C SGI interfaces"
 	depends on SGI_IP22 || SGI_IP32 || X86_VISWS
drivers/i2c/busses/Makefile renamed from drivers/i2c/busses/Makefile.old +0 -1
@@ -35,7 +35,6 @@
 obj-$(CONFIG_I2C_PNX)		+= i2c-pnx.o
 obj-$(CONFIG_I2C_PROSAVAGE)	+= i2c-prosavage.o
 obj-$(CONFIG_I2C_PXA)		+= i2c-pxa.o
-obj-$(CONFIG_I2C_RPXLITE)	+= i2c-rpx.o
 obj-$(CONFIG_I2C_S3C2410)	+= i2c-s3c2410.o
 obj-$(CONFIG_I2C_SAVAGE4)	+= i2c-savage4.o
 obj-$(CONFIG_I2C_SIBYTE)	+= i2c-sibyte.o
Documentation/i2c/summary renamed from Documentation/i2c/summary.old +0 -1
@@ -81,6 +81,5 @@
 i2c-philips-par: Philips style parallel port adapter (uses i2c-algo-bit)
 i2c-adap-ibm_ocp: IBM 4xx processor I2C device (uses i2c-algo-ibm_ocp) (NOT BUILT BY DEFAULT)
 i2c-pport:       Primitive parallel port adapter (uses i2c-algo-bit)
-i2c-rpx:         RPX board Motorola 8xx I2C device (uses i2c-algo-8xx) (NOT BUILT BY DEFAULT)
 i2c-velleman:    Velleman K8000 parallel port adapter (uses i2c-algo-bit)
 
drivers/i2c/busses/i2c-rpx.c deleted +0 -101

101 lines not on this page · raw message

#1 lore raw

Hi Adrian,

Quoted 6 lines · Adrian Bunk

This patch contains the scheduled removal of the i2c-rpx driver.

---

Quoted 7 lines
 Documentation/feature-removal-schedule.txt |    8 -
 Documentation/i2c/summary                  |    1 
 drivers/i2c/algos/Kconfig                  |    4 
 drivers/i2c/busses/Kconfig                 |    5 -
 drivers/i2c/busses/Makefile                |    1 
 drivers/i2c/busses/i2c-rpx.c               |  101 ---------------------
 6 files changed, 120 deletions(-)

I already have a patch doing this in my tree.

Also note that the entry in feature-removal-schedule.txt never made it to mainline (it was in -mm only), so it can't be removed.

In theory there is a driver rewrite in progress, so my plan is to include this removal patch into -mm for now, and send it to Linus only for 2.6.24 if I don't receive an acceptable driver meanwhile.

Thanks,

Signature · 1 line
Jean Delvare
#2 lore raw

Hi again Adrian,

Quoted 15 lines · Jean Delvare
Quoted 6 lines · Adrian Bunk

This patch contains the scheduled removal of the i2c-rpx driver.

---

Quoted 7 lines
 Documentation/feature-removal-schedule.txt |    8 -
 Documentation/i2c/summary                  |    1 
 drivers/i2c/algos/Kconfig                  |    4 
 drivers/i2c/busses/Kconfig                 |    5 -
 drivers/i2c/busses/Makefile                |    1 
 drivers/i2c/busses/i2c-rpx.c               |  101 ---------------------
 6 files changed, 120 deletions(-)
Quoted 8 lines

I already have a patch doing this in my tree.

Also note that the entry in feature-removal-schedule.txt never made it to mainline (it was in -mm only), so it can't be removed.

In theory there is a driver rewrite in progress, so my plan is to include this removal patch into -mm for now, and send it to Linus only for 2.6.24 if I don't receive an acceptable driver meanwhile.

I've changed my mind. The new driver will be so much bigger and different from the current i2c-rpx driver that there's hardly any benefit in keeping the old driver around. So I'll push this cleanup patch to Linus for 2.6.23.

Signature · 1 line
Jean Delvare