Skip to contentSkip to conversation

the scheduled sk98lin removal

PATCH In review Adrian Bunk 4 participants 5 messages Jul 9, 2007 – Jul 10, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 the scheduled sk98lin removal

This patch contains the scheduled removal of the sk98lin driver.

---

Due to its size, the patch is attached compressed.

 Documentation/feature-removal-schedule.txt |    8 
 Documentation/networking/00-INDEX          |    3 
 Documentation/networking/sk98lin.txt       |  568 -
 drivers/net/Kconfig                        |   87 
 drivers/net/Makefile                       |    1 
 drivers/net/sk98lin/Makefile               |   87 
 drivers/net/sk98lin/h/lm80.h               |  179 
 drivers/net/sk98lin/h/skaddr.h             |  285 
 drivers/net/sk98lin/h/skcsum.h             |  213 
 drivers/net/sk98lin/h/skdebug.h            |   74 
 drivers/net/sk98lin/h/skdrv1st.h           |  188 
 drivers/net/sk98lin/h/skdrv2nd.h           |  447 -
 drivers/net/sk98lin/h/skerror.h            |   55 
 drivers/net/sk98lin/h/skgedrv.h            |   51 
 drivers/net/sk98lin/h/skgehw.h             | 2126 -----
 drivers/net/sk98lin/h/skgehwt.h            |   48 
 drivers/net/sk98lin/h/skgei2c.h            |  210 
 drivers/net/sk98lin/h/skgeinit.h           |  797 --
 drivers/net/sk98lin/h/skgepnm2.h           |  334 
 drivers/net/sk98lin/h/skgepnmi.h           |  962 --
 drivers/net/sk98lin/h/skgesirq.h           |  110 
 drivers/net/sk98lin/h/ski2c.h              |  174 
 drivers/net/sk98lin/h/skqueue.h            |   94 
 drivers/net/sk98lin/h/skrlmt.h             |  438 -
 drivers/net/sk98lin/h/sktimer.h            |   63 
 drivers/net/sk98lin/h/sktypes.h            |   69 
 drivers/net/sk98lin/h/skversion.h          |   38 
 drivers/net/sk98lin/h/skvpd.h              |  248 
 drivers/net/sk98lin/h/xmac_ii.h            | 1579 ----
 drivers/net/sk98lin/skaddr.c               | 1788 ----
 drivers/net/sk98lin/skdim.c                |  742 -
 drivers/net/sk98lin/skethtool.c            |  628 -
 drivers/net/sk98lin/skge.c                 | 5211 -------------
 drivers/net/sk98lin/skgehwt.c              |  171 
 drivers/net/sk98lin/skgeinit.c             | 2005 -----
 drivers/net/sk98lin/skgemib.c              | 1075 --
 drivers/net/sk98lin/skgepnmi.c             | 8210 ---------------------
 drivers/net/sk98lin/skgesirq.c             | 2229 -----
 drivers/net/sk98lin/ski2c.c                | 1296 ---
 drivers/net/sk98lin/sklm80.c               |  141 
 drivers/net/sk98lin/skqueue.c              |  179 
 drivers/net/sk98lin/skrlmt.c               | 3257 --------
 drivers/net/sk98lin/sktimer.c              |  250 
 drivers/net/sk98lin/skvpd.c                | 1091 --
 drivers/net/sk98lin/skxmac2.c              | 4160 ----------
 45 files changed, 41969 deletions(-)
#2 lore raw
Quoted 6 lines · On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 3 lines · Adrian Bunk

This patch contains the scheduled removal of the sk98lin driver.

Stephen -- ACK?

Yes. Existing driver is dead, if there are any ancient boards that don't work with skge, I haven't heard any complaints in at least a year. As a fallback users, can always go with vendor driver.

#3 lore raw
Quoted 6 lines · Stephen Hemminger
Quoted 3 lines · On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 2 lines · Adrian Bunk

This patch contains the scheduled removal of the sk98lin driver.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Stephen -- ACK?

Yes. Existing driver is dead, if there are any ancient boards that don't work with skge, I haven't heard any complaints in at least a year. As a fallback users, can always go with vendor driver.

I have a several SK-9872s that do not work reliably with skge but work fine with sklin. The SK-9872 is a dual port card. Doing the following causes a hard lock:

modprobe bonding miimon=100 mode=active-backup
modprobe skge
ifup bond0
ifdown bond0

This happens with every version of skge I've tested, including whatever is in 2.6.22. /etc/network/interfaces contains:

iface bond0 inet static

        network 192.168.1.0
        address 192.168.1.1
        broadcast 192.168.1.255
        netmask 255.255.255.0

        up ifenslave bond0 eth0 eth1
        down ifenslave -d bond0 eth0 eth1

lspci -vv -s 02:01
02:01.0 Ethernet controller: SysKonnect SK-9872 Gigabit Ethernet Server Adapter (SK-NET GE-ZX dual link) (rev 11)
Subsystem: SysKonnect SK-9844 Gigabit Ethernet Server Adapter (SK-NET GE-SX dual link)
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 64 (5750ns min, 7750ns max), Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 22
Region 0: Memory at febfc000 (32-bit, non-prefetchable) [size=16K]
Region 1: I/O ports at e800 [size=256]
Expansion ROM at febc0000 [disabled] [size=128K]
Capabilities: <access denied>

-Chris

#4 lore raw
Quoted 6 lines · Chris Stromsoe
Quoted 5 lines · Stephen Hemminger
Quoted 3 lines · On Tue, 10 Jul 2007 12:44:35 -0400 Jeff Garzik <[email protected]> wrote:
Quoted 2 lines · Adrian Bunk

This patch contains the scheduled removal of the sk98lin driver.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Stephen -- ACK?

Yes. Existing driver is dead, if there are any ancient boards that don't work with skge, I haven't heard any complaints in at least a year. As a fallback users, can always go with vendor driver.

I have a several SK-9872s that do not work reliably with skge but work fine with sklin. The SK-9872 is a dual port card. Doing the following causes a hard lock:

sorry - SK-9844, not 9872.

Quoted 17 lines

modprobe bonding miimon=100 mode=active-backup
modprobe skge
ifup bond0
ifdown bond0

This happens with every version of skge I've tested, including whatever is in 2.6.22. /etc/network/interfaces contains:

iface bond0 inet static

       network 192.168.1.0
       address 192.168.1.1
       broadcast 192.168.1.255
       netmask 255.255.255.0

       up ifenslave bond0 eth0 eth1
       down ifenslave -d bond0 eth0 eth1
Quoted 14 lines

lspci -vv -s 02:01
02:01.0 Ethernet controller: SysKonnect SK-9872 Gigabit Ethernet Server Adapter (SK-NET GE-ZX dual link) (rev 11)
Subsystem: SysKonnect SK-9844 Gigabit Ethernet Server Adapter (SK-NET
GE-SX dual link)
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV+ VGASnoop- ParErr-
Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 64 (5750ns min, 7750ns max), Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 22
Region 0: Memory at febfc000 (32-bit, non-prefetchable) [size=16K]
Region 1: I/O ports at e800 [size=256]
Expansion ROM at febc0000 [disabled] [size=128K]
Capabilities: <access denied>

-Chris