Skip to contentSkip to conversation

x86 setup code rewrite in C

DISCUSSION Al Boldi 5 participants 9 messages Jul 10, 2007 – Jul 13, 2007

lore
Share & tools
lore

Al Boldi

author
#0 lore raw
Quoted 7 lines · H. Peter Anvin

This patch set replaces the x86 setup code, which is currently all in assembly, with a version written in C, using the ".code16gcc" feature of binutils (which has been present since at least 2001.)

The new code is vastly easier to read, and, I hope, debug. It should be noted that I found a fair number of minor bugs while going through this code, and have attempted to correct them.

I have an i810 which supends-to-ram just fine, but when booted over pxe it just hangs. Will these patches fix this, and if so, is there an easy tar-ball against 2.6.22?

Thanks!

--
Al

#1 lore raw
Quoted 5 lines · Al Boldi
Quoted 4 lines · H. Peter Anvin

This patch set replaces the x86 setup code, which is currently all in assembly, with a version written in C, using the ".code16gcc" feature of binutils (which has been present since at least 2001.)

Quoted 7 lines
Quoted 3 lines

The new code is vastly easier to read, and, I hope, debug. It should be noted that I found a fair number of minor bugs while going through this code, and have attempted to correct them.

I have an i810 which supends-to-ram just fine, but when booted over pxe it just hangs. Will these patches fix this, and if so, is there an easy tar-ball against 2.6.22?

There is absolutely no way to know, other than testing it. There isn't any real reason to suspect the setup code in your case, but it's worth a shot, I guess.

There is a git tree on git.kernel.org you can pull, which is current against 2.6.22.

-hpa

author
#2 lore raw
Quoted 10 lines · H. Peter Anvin
Quoted 9 lines · Al Boldi
Quoted 7 lines · H. Peter Anvin

This patch set replaces the x86 setup code, which is currently all in assembly, with a version written in C, using the ".code16gcc" feature of binutils (which has been present since at least 2001.)

The new code is vastly easier to read, and, I hope, debug. It should be noted that I found a fair number of minor bugs while going through this code, and have attempted to correct them.

Quoted 7 lines
Quoted 3 lines

I have an i810 which supends-to-ram just fine, but when booted over pxe it just hangs. Will these patches fix this, and if so, is there an easy tar-ball against 2.6.22?

There is absolutely no way to know, other than testing it. There isn't any real reason to suspect the setup code in your case, but it's worth a shot, I guess.

Well it's a bit far fetched to suspect the setup code, but I have another i440 that suspends-to-ram when booted over pxe without any problems. And, booting the i810 through dos-lilo also hangs STR, so that's why assumed it may be a setup code thing.

Quoted 2 lines

There is a git tree on git.kernel.org you can pull, which is current against 2.6.22.

How can I pull a tar-ball from that without using a git client?

Thanks!

--
Al

#3 lore raw
Quoted 6 lines · Al Boldi
Quoted 3 lines

There is a git tree on git.kernel.org you can pull, which is current against 2.6.22.

How can I pull a tar-ball from that without using a git client?

I don't think you can.

-hpa

#4 lore raw
Quoted 9 lines · On Tue, 10 Jul 2007 14:13:50 -0700 H. Peter Anvin wrote:
Quoted 6 lines · Al Boldi
Quoted 3 lines

There is a git tree on git.kernel.org you can pull, which is current against 2.6.22.

How can I pull a tar-ball from that without using a git client?

I don't think you can.

Too bad, not just for x86-newsetup but lots of other gits as well.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

#5 lore raw
Quoted 3 lines · Randy Dunlap

Too bad, not just for x86-newsetup but lots of other gits as well.

Well, it's a function of gitweb, but we have been forced to disable it because it interferes hideously with the caching system. We'll hopefully eventually get around to fixing it, but it's not a high priority unfortunately.

So far our effort at getting paid staff seems to have fallen through :(

-hpa

#6 lore raw
Quoted 3 lines · H. Peter Anvin

So far our effort at getting paid staff seems to have fallen through :(

-hpa

Presumably the 501c status hasn't changed since OLS?
If a paid position isn't forthcoming, perhaps there can be a bounty system for people to contribute $ towards desired functionality.

Signature · 1 line
Christopher Smith
#7 lore raw
Quoted 8 lines · Chris Smith
Quoted 3 lines · H. Peter Anvin

So far our effort at getting paid staff seems to have fallen through :(

-hpa

Presumably the 501c status hasn't changed since OLS?
If a paid position isn't forthcoming, perhaps there can be a bounty system for people to contribute $ towards desired functionality.

501(c)3 is still pending, unfortunately.

We actually get a lot of offer for volunteers, but we can't use them because we lack the kind of management structure needed to run them. As a result, we can only take on people willing to spend a sizable chunk of time doing kernel.org stuff, *and* are already known by the rest of the admin team to be self-starters.

However, even that is really difficult enough. kernel.org definitely takes a lot more of my time than I would like.

-hpa

#8 lore raw
In reply to H. Peter Anvin
Quoted 9 lines · H. Peter Anvin
Quoted 6 lines · Al Boldi
Quoted 3 lines

There is a git tree on git.kernel.org you can pull, which is current against 2.6.22.

How can I pull a tar-ball from that without using a git client?

I don't think you can.

gitweb has a snapshot feature that should offer this, but git.kernel.org seems to only give garbage when you click on it.

Quoted 1 line

-hpa

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed