Skip to contentSkip to conversation

jmicron: PIO fixes

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 3 messages Jul 8, 2007 – Jul 10, 2007 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 6/12 jmicron: PIO fixes

* Set transfer mode on the device in jmicron_tuneproc(), also add pio == 255 == "auto-tune" handling.

* Use jmicron_tuneproc() in jmicron_config_drive_for_dma().

* Remove no longer needed config_jmicron_chipset_for_pio().

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/pci/jmicron.c |   21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)
drivers/ide/pci/jmicron.c +4 -17
Index: b/drivers/ide/pci/jmicron.c
===================================================================
@@ -83,23 +83,10 @@ static u8 __devinit ata66_jmicron(ide_hw
 	return ATA_CBL_PATA80;
 }
 
-static void jmicron_tuneproc (ide_drive_t *drive, byte mode_wanted)
+static void jmicron_tuneproc(ide_drive_t *drive, u8 pio)
 {
-	return;
-}
-
-/**
- *	config_jmicron_chipset_for_pio	-	set drive timings
- *	@drive: drive to tune
- *	@speed we want
- *
- */
-
-static void config_jmicron_chipset_for_pio (ide_drive_t *drive, byte set_speed)
-{
-	u8 speed = XFER_PIO_0 + ide_get_best_pio_mode(drive, 255, 5);
-	if (set_speed)
-		(void) ide_config_drive_speed(drive, speed);
+	pio = ide_get_best_pio_mode(drive, pio, 5);
+	ide_config_drive_speed(drive, XFER_PIO_0 + pio);
 }
 
 /**

@@ -132,7 +119,7 @@ static int jmicron_config_drive_for_dma 
 	if (ide_tune_dma(drive))
 		return 0;
 
-	config_jmicron_chipset_for_pio(drive, 1);
+	jmicron_tuneproc(drive, 255);
 
 	return -1;
 }
author
#2 lore raw
Quoted 5 lines · Sergei Shtylyov
Quoted 2 lines · Bartlomiej Zolnierkiewicz

* Set transfer mode on the device in jmicron_tuneproc(), also add pio == 255 == "auto-tune" handling.

Quoted 7 lines
Quoted 5 lines

* Use jmicron_tuneproc() in jmicron_config_drive_for_dma().

* Remove no longer needed config_jmicron_chipset_for_pio().

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Sergei Shtylyov <[email protected]>

added